Re: [PATCH 1/2] panthor: Allow specifying offset when mapping a BO against a VM

[Boris Brezillon <boris.brezillon@collabora.com>]

Hello Adrian,

Quick note for v2, make sure you use "PATCH i-g-t vX" as a
--subject-prefix, so it's clear those are IGT patches.

On Thu, 27 Nov 2025 03:01:43 +0000
Adrián Larumbe <adrian.larumbe@collabora.com> wrote:

> A future commit that tests VM_BIND unmapping of regions backed by huge
> pages will make use of it. Leave the old interface as an inlined
> function that passes 0 as a default BO offset.
> 
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

with a minor formatting improvement suggested below.

> ---
>  lib/igt_panthor.c | 5 +++--
>  lib/igt_panthor.h | 9 +++++++--
>  2 files changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/lib/igt_panthor.c b/lib/igt_panthor.c
> index 73ada9c59bfc..49b427d4f162 100644
> --- a/lib/igt_panthor.c
> +++ b/lib/igt_panthor.c
> @@ -234,12 +234,13 @@ void igt_panthor_vm_destroy(int fd, uint32_t vm_id, int err)
>   *
>   * Bind a buffer object to a virtual address in the specified VM.
>   */
> -void igt_panthor_vm_bind(int fd, uint32_t vm_id, uint32_t bo_handle,
> -			 uint64_t va, uint64_t size, uint32_t flags, int err)
> +void igt_panthor_vm_bind_offset(int fd, uint32_t vm_id, uint32_t bo_handle, uint64_t va,
> +				uint64_t size, uint64_t offset, uint32_t flags, int err)
>  {
>  	struct drm_panthor_vm_bind_op bind_op = {
>  		.flags = flags,
>  		.bo_handle = bo_handle,
> +		.bo_offset = offset,
>  		.va = va,
>  		.size = size,
>  	};
> diff --git a/lib/igt_panthor.h b/lib/igt_panthor.h
> index dc90033c0ad4..1fe0271d48c9 100644
> --- a/lib/igt_panthor.h
> +++ b/lib/igt_panthor.h
> @@ -19,8 +19,8 @@ struct panthor_bo {
>  void igt_panthor_query(int fd, int32_t type, void *data, size_t size, int err);
>  void igt_panthor_vm_create(int fd, uint32_t *vm_id, int err);
>  void igt_panthor_vm_destroy(int fd, uint32_t vm_id, int err);
> -void igt_panthor_vm_bind(int fd, uint32_t vm_id, uint32_t bo_handle, uint64_t va,
> -			 uint64_t size, uint32_t flags, int err);
> +void igt_panthor_vm_bind_offset(int fd, uint32_t vm_id, uint32_t bo_handle, uint64_t va,
> +			 uint64_t size, uint64_t ofsfet, uint32_t flags, int err);
>  void igt_panthor_bo_create(int fd, struct panthor_bo *bo, uint64_t size, uint32_t flags, int err);
>  uint64_t igt_panthor_bo_mmap_offset(int fd, uint32_t handle, int err);
>  void igt_panthor_free_bo(int fd, struct panthor_bo *bo);
> @@ -38,6 +38,11 @@ void igt_panthor_group_submit_simple(int fd, uint32_t group_handle,
>  				     int err);
>  uint64_t igt_panthor_get_first_core(uint64_t cores_present);
>  
> +static inline void igt_panthor_vm_bind(int fd, uint32_t vm_id, uint32_t bo_handle,
> +				       uint64_t va, uint64_t size, uint32_t flags, int err) {
> +	igt_panthor_vm_bind_offset(fd, vm_id, bo_handle, va, size, 0, flags, err);
> +}

formatting nit:

static inline void
igt_panthor_vm_bind(int fd, uint32_t vm_id, uint32_t bo_handle, uint64_t va,
		    uint64_t size, uint32_t flags, int err)
{
	igt_panthor_vm_bind_offset(fd, vm_id, bo_handle, va, size, 0, flags, err);
}

> +
>  enum cs_opcode {
>  	CS_OPCODE_NOP = 0,
>  	CS_OPCODE_MOVE48 = 1,
> 
> base-commit: 7bc8d310594c1dc1a851451845d1ea3c15fbd53d