From: Andrzej Hajda <andrzej.hajda@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
Priyanka Dandamudi <priyanka.dandamudi@intel.com>,
Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>,
Jan Maslak <jan.maslak@intel.com>,
Andrzej Hajda <andrzej.hajda@intel.com>
Subject: [PATCH 08/11] tests/intel/xe_eudebug_online: rename threads_count to thread_hit_count
Date: Fri, 28 Nov 2025 15:12:12 +0100 [thread overview]
Message-ID: <20251128-pagefault-one-of-many-v1-8-a8377a93da8f@intel.com> (raw)
In-Reply-To: <20251128-pagefault-one-of-many-v1-0-a8377a93da8f@intel.com>
threads_count is used to count threads which hit something, either
pagefault, either breakpoint. Let's rename it to thread_hit_count
and keep the former name for future.
Signed-off-by: Andrzej Hajda <andrzej.hajda@intel.com>
---
tests/intel/xe_eudebug_online.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c
index e3aa13a39082..b4c8674cb0e6 100644
--- a/tests/intel/xe_eudebug_online.c
+++ b/tests/intel/xe_eudebug_online.c
@@ -381,7 +381,7 @@ struct online_debug_data {
struct drm_xe_engine_class_instance hwe;
uint64_t flags;
/* client out */
- int threads_count;
+ int thread_hit_count;
/* debugger internals */
uint64_t client_handle;
uint64_t exec_queue_handle;
@@ -1147,8 +1147,8 @@ static void run_online_client(struct xe_eudebug_client *c)
if (!(c->flags & DO_NOT_EXPECT_CANARIES)) {
ptr = xe_bo_mmap_ext(fd, buf->handle, buf->size, PROT_READ);
- data->threads_count = count_canaries_neq(ptr, w_dim, 0);
- igt_assert_f(data->threads_count, "No canaries found, nothing executed?\n");
+ data->thread_hit_count = count_canaries_neq(ptr, w_dim, 0);
+ igt_assert_f(data->thread_hit_count, "No canaries found, nothing executed?\n");
if ((c->flags & SHADER_BREAKPOINT || c->flags & TRIGGER_RESUME_SET_BP ||
c->flags & SHADER_N_NOOP_BREAKPOINT) && !(c->flags & DISABLE_DEBUG_MODE)) {
@@ -1156,8 +1156,9 @@ static void run_online_client(struct xe_eudebug_client *c)
igt_assert_f(aip != SHADER_CANARY,
"Workload executed but breakpoint not hit!\n");
- igt_assert_eq(count_canaries_eq(ptr, w_dim, aip), data->threads_count);
- igt_debug("Breakpoint hit in %d threads, AIP=0x%08x\n", data->threads_count,
+ igt_assert_eq(count_canaries_eq(ptr, w_dim, aip), data->thread_hit_count);
+ igt_debug("Breakpoint hit in %d threads, AIP=0x%08x\n",
+ data->thread_hit_count,
aip);
}
@@ -1338,7 +1339,7 @@ static void online_session_check(struct xe_eudebug_session *s, int flags)
* if we have a breakpoint set and we resume all threads always.
*/
if (flags == SHADER_BREAKPOINT || flags == TRIGGER_UFENCE_SET_BREAKPOINT)
- igt_assert_eq(sum, data->threads_count);
+ igt_assert_eq(sum, data->thread_hit_count);
if (expect_exception)
igt_assert(sum > 0);
--
2.43.0
next prev parent reply other threads:[~2025-11-28 14:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-28 14:12 [PATCH 00/11] tests/intel/xe_eudebug_online: add pagefault-one-of-many test Andrzej Hajda
2025-11-28 14:12 ` [PATCH 01/11] lib/igt_aux: add hweight helper for bitmaps Andrzej Hajda
2025-11-28 14:12 ` [PATCH 02/11] lib/xe/xe_query: add helpers to return count of EUs and EU threads Andrzej Hajda
2025-11-28 14:12 ` [PATCH 03/11] lib/gpgpu_shader: use recently introduced helper to get EU thread count Andrzej Hajda
2025-11-28 14:12 ` [PATCH 04/11] tests/intel/xe_eudebug_online: use igt_bitmap_hweight Andrzej Hajda
2025-11-28 14:12 ` [PATCH 05/11] lib/igt_aux: add fls helper for bitmaps Andrzej Hajda
2025-11-28 14:12 ` [PATCH 06/11] tests/intel/xe_eudebug_online: use igt_bitmap_fls to calculate max dss count Andrzej Hajda
2025-11-28 14:12 ` [PATCH 07/11] tests/intel/xe_eudebug_online: add fd and flags to online_debug_data Andrzej Hajda
2025-11-28 14:12 ` Andrzej Hajda [this message]
2025-11-28 14:12 ` [PATCH 09/11] tests/intel/xe_eudebug_online: use online_debug_data in get_(shader|sip) Andrzej Hajda
2025-11-28 14:12 ` [PATCH 10/11] tests/intel/xe_eudebug_online: cache thread count value Andrzej Hajda
2025-11-28 14:12 ` [PATCH 11/11] tests/intel/xe_eudebug_online: add pagefault-one-of-many test Andrzej Hajda
2025-11-28 15:01 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-11-28 15:39 ` ✓ i915.CI.BAT: " Patchwork
2025-11-28 15:58 ` ✗ Xe.CI.Full: failure " Patchwork
2025-12-01 13:24 ` â " Hajda, Andrzej
2025-11-28 16:24 ` ✗ i915.CI.Full: " Patchwork
2025-12-01 14:54 ` â " Hajda, Andrzej
2025-12-03 11:16 ` [PATCH 00/11] " Maciej Patelczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251128-pagefault-one-of-many-v1-8-a8377a93da8f@intel.com \
--to=andrzej.hajda@intel.com \
--cc=gwan-gyeong.mun@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jan.maslak@intel.com \
--cc=kamil.konieczny@linux.intel.com \
--cc=priyanka.dandamudi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).