public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Xin Wang <x.wang@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: alex.zuo@intel.com, shuicheng.lin@intel.com,
	stuart.summers@intel.com, kamil.konieczny@intel.com,
	matthew.d.roper@intel.com, ravi.kumar.vodapalli@intel.com,
	zbigniew.kempczynski@intel.com, Xin Wang <x.wang@intel.com>,
	Matthew Auld <matthew.auld@intel.com>
Subject: [PATCH v9 3/5] tests/xe_pat: add pat-sanity subtest for debugfs vs getters
Date: Wed, 31 Dec 2025 05:55:23 +0000	[thread overview]
Message-ID: <20251231055525.51524-4-x.wang@intel.com> (raw)
In-Reply-To: <20251231055525.51524-1-x.wang@intel.com>

Add a new pat-sanity subtest that reads the Xe PAT software
configuration from debugfs and validates it against the
existing PAT index helper getters.

CC: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
CC: Matt Roper <matthew.d.roper@intel.com>
CC: Matthew Auld <matthew.auld@intel.com>
Signed-off-by: Xin Wang <x.wang@intel.com>
---
 tests/intel/xe_pat.c | 99 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 99 insertions(+)

diff --git a/tests/intel/xe_pat.c b/tests/intel/xe_pat.c
index 2fd3635fd..f003f0046 100644
--- a/tests/intel/xe_pat.c
+++ b/tests/intel/xe_pat.c
@@ -18,6 +18,7 @@
 #include "intel_blt.h"
 #include "intel_mocs.h"
 #include "intel_pat.h"
+#include "linux_scaffold.h"
 
 #include "xe/xe_ioctl.h"
 #include "xe/xe_query.h"
@@ -76,6 +77,101 @@ static void userptr_coh_none(int fd)
 	munmap(data, size);
 	xe_vm_destroy(fd, vm);
 }
+#define REG_FIELD_GET(__mask, __val) \
+	((uint32_t)FIELD_GET(__mask, __val))
+
+#define XE2_NO_PROMOTE	REG_BIT(10)
+#define XE2_COMP_EN	REG_BIT(9)
+#define XE2_L3_CLOS	GENMASK(7, 6)
+#define XE2_L3_POLICY	GENMASK(5, 4)
+#define XE2_L4_POLICY	GENMASK(3, 2)
+#define XE2_COH_MODE	GENMASK(1, 0)
+
+#define L3_CLOS1		1
+#define L3_CLOS2		2
+#define L3_CLOS3		3
+
+#define L3_CACHE_POLICY_WB	0
+#define L3_CACHE_POLICY_XD	1
+#define L3_CACHE_POLICY_UC	3
+
+#define L4_CACHE_POLICY_WB	0
+#define L4_CACHE_POLICY_WT	1
+#define L4_CACHE_POLICY_UC	3
+
+#define COH_MODE_NONE	  	0
+#define COH_MODE_1WAY		2
+#define COH_MODE_2WAY		3
+
+static int xe_fetch_pat_sw_config_or_skip(int fd, struct intel_pat_cache *pat_sw_config)
+{
+	int32_t parsed = xe_get_pat_sw_config(fd, pat_sw_config);
+
+	igt_require_f(parsed > 0, "Couldn't get Xe PAT software configuration\n");
+
+	return parsed;
+}
+
+static void dump_xe2_pat_sw_entries(const struct intel_pat_cache *pat_sw_config,
+				    int32_t parsed)
+{
+	for (int i = 0; i < parsed; i++) {
+		uint32_t pat = pat_sw_config->entries[i].pat;
+
+		igt_info("PAT[%2d] = [ %u, %u, %u, %u, %u, %u]  (%#8x)%s\n", i,
+			  !!(pat & XE2_NO_PROMOTE),
+			  !!(pat & XE2_COMP_EN),
+			  REG_FIELD_GET(XE2_L3_CLOS, pat),
+			  REG_FIELD_GET(XE2_L3_POLICY, pat),
+			  REG_FIELD_GET(XE2_L4_POLICY, pat),
+			  REG_FIELD_GET(XE2_COH_MODE, pat),
+			  pat,
+			  pat_sw_config->entries[i].rsvd ? " *" : "");
+	}
+}
+
+/**
+ * SUBTEST: pat-sanity
+ * Test category: functionality test
+ * Description: Test debugfs PAT config vs getters
+ */
+static void pat_sanity(int fd)
+{
+	uint16_t dev_id = intel_get_drm_devid(fd);
+	struct intel_pat_cache pat_sw_config = {};
+	int32_t parsed;
+	bool has_uc_comp = false, has_wt = false;
+
+	parsed = xe_fetch_pat_sw_config_or_skip(fd, &pat_sw_config);
+
+	if (intel_graphics_ver(dev_id) >= IP_VER(20, 0)) {
+		dump_xe2_pat_sw_entries(&pat_sw_config, parsed);
+		for (int i = 0; i < parsed; i++) {
+			uint32_t pat = pat_sw_config.entries[i].pat;
+			if (pat_sw_config.entries[i].rsvd)
+				continue;
+			if (!!(pat & XE2_COMP_EN) &&
+			    REG_FIELD_GET(XE2_L3_POLICY, pat) == L3_CACHE_POLICY_UC &&
+			    REG_FIELD_GET(XE2_L4_POLICY, pat) == L4_CACHE_POLICY_UC) {
+				has_uc_comp = true;
+			}
+			if (REG_FIELD_GET(XE2_L3_POLICY, pat) == L3_CACHE_POLICY_XD &&
+			    REG_FIELD_GET(XE2_L4_POLICY, pat) == L4_CACHE_POLICY_WT) {
+				has_wt = true;
+			}
+		}
+		if (has_uc_comp)
+			igt_assert(pat_sw_config.uc_comp == intel_get_pat_idx_uc_comp(fd));
+	}
+	else {
+		has_wt = true;
+	}
+	igt_assert(pat_sw_config.max_index == intel_get_max_pat_index(fd));
+	igt_assert(pat_sw_config.uc == intel_get_pat_idx_uc(fd));
+	igt_assert(pat_sw_config.wb == intel_get_pat_idx_wb(fd));
+	if (has_wt)
+		igt_assert(pat_sw_config.wt == intel_get_pat_idx_wt(fd));
+}
 
 /**
  * SUBTEST: pat-index-all
@@ -1230,6 +1326,9 @@ int igt_main_args("V", NULL, help_str, opt_handler, NULL)
 		xe_device_get(fd);
 	}
 
+	igt_subtest("pat-sanity")
+		pat_sanity(fd);
+
 	igt_subtest("pat-index-all")
 		pat_index_all(fd);
 
-- 
2.43.0


  parent reply	other threads:[~2025-12-31  5:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-31  5:55 [PATCH v9 0/5] tests/intel/xe_pat: add helper funtion to read PAT table Xin Wang
2025-12-31  5:55 ` [PATCH v9 1/5] lib/intel_pat: add pat_sw_config debugfs parser Xin Wang
2025-12-31 16:56   ` Matt Roper
2025-12-31  5:55 ` [PATCH v9 2/5] include/linux_scaffold: add FIELD_GET() bitfield helper Xin Wang
2025-12-31 17:00   ` Matt Roper
2025-12-31  5:55 ` Xin Wang [this message]
2025-12-31 17:11   ` [PATCH v9 3/5] tests/xe_pat: add pat-sanity subtest for debugfs vs getters Matt Roper
2025-12-31  5:55 ` [PATCH v9 4/5] tests/xe_pat: use debugfs reserved flags Xin Wang
2025-12-31  5:55 ` [PATCH v9 5/5] intel-ci: add xe_pat pat-sanity Xin Wang
2025-12-31 17:13   ` Matt Roper
2025-12-31  6:47 ` ✓ Xe.CI.BAT: success for tests/intel/xe_pat: add helper funtion to read PAT table Patchwork
2025-12-31  7:07 ` ✓ i915.CI.BAT: " Patchwork
2025-12-31  7:49 ` ✗ Xe.CI.Full: failure " Patchwork
2025-12-31  9:15 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251231055525.51524-4-x.wang@intel.com \
    --to=x.wang@intel.com \
    --cc=alex.zuo@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@intel.com \
    --cc=matthew.auld@intel.com \
    --cc=matthew.d.roper@intel.com \
    --cc=ravi.kumar.vodapalli@intel.com \
    --cc=shuicheng.lin@intel.com \
    --cc=stuart.summers@intel.com \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox