public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	"Matthew Brost" <matthew.brost@intel.com>,
	"Daniele Ceraolo Spurio" <daniele.ceraolospurio@intel.com>,
	"Francois Dugast" <francois.dugast@intel.com>
Subject: [PATCH i-g-t] lib/intel_compute: Wait for compute walker before returning to ring
Date: Thu, 22 Jan 2026 11:45:29 +0100	[thread overview]
Message-ID: <20260122104528.980532-2-zbigniew.kempczynski@intel.com> (raw)

Most compute tests don't need to synchronize at the batch level as
kmd executes pipe-control at some point. Last xe driver proposal (link
below) causes turning off preemption before pipe-control preventing
entering to SIP and finish the WMTP test properly.

Change adds pipe-control at batch level causing sync wait on
compute-walker and preventing disabling the preemption prematurely.

Link: https://patchwork.freedesktop.org/series/160113/
Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Francois Dugast <francois.dugast@intel.com>
---
 lib/intel_compute.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/lib/intel_compute.c b/lib/intel_compute.c
index 00ef280e8f..8578b6e402 100644
--- a/lib/intel_compute.c
+++ b/lib/intel_compute.c
@@ -1694,6 +1694,13 @@ static void xe2lpg_compute_exec_compute(int fd,
 	addr_bo_buffer_batch[b++] = 0x00000000;
 	addr_bo_buffer_batch[b++] = 0x00000000;
 
+	addr_bo_buffer_batch[b++] = PIPE_CONTROL;
+	addr_bo_buffer_batch[b++] = 0x00100000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+
 	addr_bo_buffer_batch[b++] = MI_BATCH_BUFFER_END;
 }
 
@@ -2032,6 +2039,13 @@ static void xe3p_compute_exec_compute(int fd,
 	addr_bo_buffer_batch[b++] = 0x00000000; /* dw62 */
 	addr_bo_buffer_batch[b++] = 0x00000000; /* dw63 */
 
+	addr_bo_buffer_batch[b++] = PIPE_CONTROL;
+	addr_bo_buffer_batch[b++] = 0x00100000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+	addr_bo_buffer_batch[b++] = 0x00000000;
+
 	addr_bo_buffer_batch[b++] = MI_BATCH_BUFFER_END;
 }
 
-- 
2.43.0


             reply	other threads:[~2026-01-22 10:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22 10:45 Zbigniew Kempczyński [this message]
2026-01-22 14:55 ` ✓ i915.CI.BAT: success for lib/intel_compute: Wait for compute walker before returning to ring Patchwork
2026-01-23  2:47 ` ✗ i915.CI.Full: failure " Patchwork
2026-01-27  9:13 ` ✓ Xe.CI.BAT: success for lib/intel_compute: Wait for compute walker before returning to ring (rev2) Patchwork
2026-01-27  9:16 ` ✗ i915.CI.BAT: failure " Patchwork
2026-01-27 11:11 ` ✗ Xe.CI.Full: " Patchwork
2026-02-02 14:15 ` [PATCH i-g-t] lib/intel_compute: Wait for compute walker before returning to ring Francois Dugast
2026-02-03  7:57   ` Zbigniew Kempczyński
2026-02-26 18:20     ` Matthew Brost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260122104528.980532-2-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=daniele.ceraolospurio@intel.com \
    --cc=francois.dugast@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox