* [PATCH 0/1] tests/xe_eudebug_online: fix thread ID math in pagefault-one-of-many shader
@ 2026-01-28 11:36 Jan Maslak
2026-01-28 11:36 ` [PATCH 1/1] " Jan Maslak
0 siblings, 1 reply; 3+ messages in thread
From: Jan Maslak @ 2026-01-28 11:36 UTC (permalink / raw)
To: igt-dev; +Cc: andrzej.hajda, Jan Maslak
Jan Maslak (1):
tests/xe_eudebug_online: fix thread ID math in pagefault-one-of-many
shader
tests/intel/xe_eudebug_online.c | 5 +++--
tests/intel/xe_eudebug_online.c.gen.iga64_codes.c | 7 ++++---
2 files changed, 7 insertions(+), 5 deletions(-)
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 1/1] tests/xe_eudebug_online: fix thread ID math in pagefault-one-of-many shader
2026-01-28 11:36 [PATCH 0/1] tests/xe_eudebug_online: fix thread ID math in pagefault-one-of-many shader Jan Maslak
@ 2026-01-28 11:36 ` Jan Maslak
0 siblings, 0 replies; 3+ messages in thread
From: Jan Maslak @ 2026-01-28 11:36 UTC (permalink / raw)
To: igt-dev; +Cc: andrzej.hajda, Jan Maslak
Replace the incorrect use of
r1.4 (wrong inline field) with explicit dim.x passed as an argument,
then computing tgid.y * dim.x + tgid.x via mul + add.
Signed-off-by: Jan Maslak <jan.maslak@intel.com>
---
tests/intel/xe_eudebug_online.c | 5 +++--
tests/intel/xe_eudebug_online.c.gen.iga64_codes.c | 7 ++++---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c
index 084bdeb77..9f736af58 100644
--- a/tests/intel/xe_eudebug_online.c
+++ b/tests/intel/xe_eudebug_online.c
@@ -267,12 +267,13 @@ static struct gpgpu_shader *get_shader(struct online_debug_data *data)
mov (1) r30.4<1>:ud 0x3f:ud
mov (1) r30.7<1>:ud 0x3:ud // 4 bytes
// calculate thread id: r20.0 = dim.x * tgid.y + tgid.x
- mad (1) r20.0<1>:ud r0.1<0;0>:ud r0.6<0;0>:ud r1.4<0>:ud
+ mul (1) r20.0<1>:ud r0.6<0;1,0>:ud ARG(1):ud
+ add (1) r20.0<1>:ud r20.0<0;1,0>:ud r0.1<0;1,0>:ud
// page-fault only for arbitrary thread
cmp (1) (eq)f0.0 null<1>:ud r20.0<0;1,0>:ud ARG(0):ud
(f0.0) send.ugm (1) r31 r30 null 0x0 0x2128403 // load_block2d.ugm.d32t.a64.uc.uc
#endif
- )", data->pf_thread_number);
+ )", data->pf_thread_number, data->w_dim.x);
gpgpu_shader__label(shader, 0);
gpgpu_shader__write_dword(shader, SHADER_CANARY, 0);
diff --git a/tests/intel/xe_eudebug_online.c.gen.iga64_codes.c b/tests/intel/xe_eudebug_online.c.gen.iga64_codes.c
index 3bd5b0c5f..2fe6bb7d8 100644
--- a/tests/intel/xe_eudebug_online.c.gen.iga64_codes.c
+++ b/tests/intel/xe_eudebug_online.c.gen.iga64_codes.c
@@ -3,7 +3,7 @@
#include "gpgpu_shader.h"
-#define MD5_SUM_IGA64_ASMS f0897ea23eff7ea77569eca6ddd16161
+#define MD5_SUM_IGA64_ASMS 7ab1b0da138a90599e4086c2c40269c9
struct iga64_template const iga64_code_store_sr0_0[] = {
{ .gen_ver = 2000, .size = 40, .code = (const uint32_t []) {
@@ -24,13 +24,14 @@ struct iga64_template const iga64_code_store_sr0_0[] = {
};
struct iga64_template const iga64_code_pagefault_one_of_many[] = {
- { .gen_ver = 2000, .size = 44, .code = (const uint32_t []) {
+ { .gen_ver = 2000, .size = 48, .code = (const uint32_t []) {
0x000c0061, 0x1e054330, 0x00000000, 0x00000000,
0x00000061, 0x1e054330, 0x00000123, 0x45678000,
0x00000061, 0x1e254220, 0x00000000, 0x0000003f,
0x00000061, 0x1e454220, 0x00000000, 0x0000003f,
0x00000061, 0x1e754220, 0x00000000, 0x00000003,
- 0x0000005b, 0x14040220, 0x02020014, 0x01440064,
+ 0x00000041, 0x14058220, 0x02000064, 0xc0ded001,
+ 0x00001940, 0x14050220, 0x02001404, 0x00000014,
0x00001970, 0x00018220, 0x12001404, 0xc0ded000,
0x04032031, 0x1f0c0000, 0xf8061e0c, 0x00a00000,
0x80000001, 0x00010000, 0x20000000, 0x00000000,
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 1/1] tests/xe_eudebug_online: fix thread ID math in pagefault-one-of-many shader
2026-01-28 11:39 [PATCH 0/1] " Jan Maslak
@ 2026-01-28 11:39 ` Jan Maslak
0 siblings, 0 replies; 3+ messages in thread
From: Jan Maslak @ 2026-01-28 11:39 UTC (permalink / raw)
To: igt-dev; +Cc: andrzej.hajda, Jan Maslak
Replace the incorrect use of r1.4 (wrong inline field) with explicit dim.x
passed as an argument, then computing tgid.y * dim.x + tgid.x via mul + add.
Signed-off-by: Jan Maslak <jan.maslak@intel.com>
---
tests/intel/xe_eudebug_online.c | 5 +++--
tests/intel/xe_eudebug_online.c.gen.iga64_codes.c | 7 ++++---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/tests/intel/xe_eudebug_online.c b/tests/intel/xe_eudebug_online.c
index 084bdeb77..9f736af58 100644
--- a/tests/intel/xe_eudebug_online.c
+++ b/tests/intel/xe_eudebug_online.c
@@ -267,12 +267,13 @@ static struct gpgpu_shader *get_shader(struct online_debug_data *data)
mov (1) r30.4<1>:ud 0x3f:ud
mov (1) r30.7<1>:ud 0x3:ud // 4 bytes
// calculate thread id: r20.0 = dim.x * tgid.y + tgid.x
- mad (1) r20.0<1>:ud r0.1<0;0>:ud r0.6<0;0>:ud r1.4<0>:ud
+ mul (1) r20.0<1>:ud r0.6<0;1,0>:ud ARG(1):ud
+ add (1) r20.0<1>:ud r20.0<0;1,0>:ud r0.1<0;1,0>:ud
// page-fault only for arbitrary thread
cmp (1) (eq)f0.0 null<1>:ud r20.0<0;1,0>:ud ARG(0):ud
(f0.0) send.ugm (1) r31 r30 null 0x0 0x2128403 // load_block2d.ugm.d32t.a64.uc.uc
#endif
- )", data->pf_thread_number);
+ )", data->pf_thread_number, data->w_dim.x);
gpgpu_shader__label(shader, 0);
gpgpu_shader__write_dword(shader, SHADER_CANARY, 0);
diff --git a/tests/intel/xe_eudebug_online.c.gen.iga64_codes.c b/tests/intel/xe_eudebug_online.c.gen.iga64_codes.c
index 3bd5b0c5f..2fe6bb7d8 100644
--- a/tests/intel/xe_eudebug_online.c.gen.iga64_codes.c
+++ b/tests/intel/xe_eudebug_online.c.gen.iga64_codes.c
@@ -3,7 +3,7 @@
#include "gpgpu_shader.h"
-#define MD5_SUM_IGA64_ASMS f0897ea23eff7ea77569eca6ddd16161
+#define MD5_SUM_IGA64_ASMS 7ab1b0da138a90599e4086c2c40269c9
struct iga64_template const iga64_code_store_sr0_0[] = {
{ .gen_ver = 2000, .size = 40, .code = (const uint32_t []) {
@@ -24,13 +24,14 @@ struct iga64_template const iga64_code_store_sr0_0[] = {
};
struct iga64_template const iga64_code_pagefault_one_of_many[] = {
- { .gen_ver = 2000, .size = 44, .code = (const uint32_t []) {
+ { .gen_ver = 2000, .size = 48, .code = (const uint32_t []) {
0x000c0061, 0x1e054330, 0x00000000, 0x00000000,
0x00000061, 0x1e054330, 0x00000123, 0x45678000,
0x00000061, 0x1e254220, 0x00000000, 0x0000003f,
0x00000061, 0x1e454220, 0x00000000, 0x0000003f,
0x00000061, 0x1e754220, 0x00000000, 0x00000003,
- 0x0000005b, 0x14040220, 0x02020014, 0x01440064,
+ 0x00000041, 0x14058220, 0x02000064, 0xc0ded001,
+ 0x00001940, 0x14050220, 0x02001404, 0x00000014,
0x00001970, 0x00018220, 0x12001404, 0xc0ded000,
0x04032031, 0x1f0c0000, 0xf8061e0c, 0x00a00000,
0x80000001, 0x00010000, 0x20000000, 0x00000000,
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-28 11:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-28 11:36 [PATCH 0/1] tests/xe_eudebug_online: fix thread ID math in pagefault-one-of-many shader Jan Maslak
2026-01-28 11:36 ` [PATCH 1/1] " Jan Maslak
-- strict thread matches above, loose matches on Subject: below --
2026-01-28 11:39 [PATCH 0/1] " Jan Maslak
2026-01-28 11:39 ` [PATCH 1/1] " Jan Maslak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox