public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Mohammed Bilal <mohammed.bilal@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jeevan.b@intel.com, kunal1.joshi@intel.com,
	sameer.lattannavar@intel.com, karthik.b.s@intel.com,
	Mohammed Bilal <mohammed.bilal@intel.com>
Subject: [PATCH i-g-t v6 0/2] Fix chamelium port allocation during igt_fixture
Date: Thu, 29 Jan 2026 13:15:18 +0530	[thread overview]
Message-ID: <20260129074520.397133-1-mohammed.bilal@intel.com> (raw)

The current fixture implementation executes even for unrelated subtests,
causing false failures when expected inputs were not present.
Refactor the DP/HDMI/VGA hotplug tests to use a common
connector lookup pattern so that each test skips cleanly.

v3:
- Introduce a unified connector test macro (Sebastien)
- Remove unused variable (Sebastien)
- Drop per-connector fixture usage (Sebastien)
- Refactor DP/HDMI/VGA hotplug tests (Sebastien)

v4:
- Rename helper to igt_chamelium_get_port (Jeevan)
- Add documentation for helper and macro (Jeevan)
- Use lowercase name for test macro (Sebastien)

v5:
-Iterate and test all matching connected ports (Kunal)

v6:
- Fix macro structure to ensure safe expansion and proper scoping (Kunal)
- Make the macro independent of assumptions in the calling test (Kunal)
- Move connector_test macro to kms_chamelium_helper
  for correct layering (Kunal)
- Use suffixed local variables to avoid name collisions (Kunal)
- Add igt_info logging to show which port is being
  exercised by each subtest (Kunal)

Mohammed Bilal (2):
  tests/chamelium/kms_chamelium: Add connector_test() macro
  tests/chamelium/kms_chamelium_hpd: use helper function for connector
    lookup in DP/HDMI/VGA tests

 tests/chamelium/kms_chamelium_helper.h |  33 ++++
 tests/chamelium/kms_chamelium_hpd.c    | 239 ++++++++++---------------
 2 files changed, 131 insertions(+), 141 deletions(-)

-- 
2.48.1


             reply	other threads:[~2026-01-29  7:47 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29  7:45 Mohammed Bilal [this message]
2026-01-29  7:45 ` [PATCH i-g-t v6 1/2] tests/chamelium/kms_chamelium: Add connector_test() macro Mohammed Bilal
2026-01-29  7:45 ` [PATCH i-g-t v6 2/2] tests/chamelium/kms_chamelium_hpd: use helper function for connector lookup in DP/HDMI/VGA tests Mohammed Bilal
2026-01-30  4:05   ` [i-g-t,v6,2/2] " Joshi, Kunal1
2026-01-29  8:46 ` ✓ Xe.CI.BAT: success for Fix chamelium port allocation during igt_fixture Patchwork
2026-01-29  9:27 ` ✓ i915.CI.BAT: " Patchwork
2026-01-29 10:56 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260129074520.397133-1-mohammed.bilal@intel.com \
    --to=mohammed.bilal@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    --cc=karthik.b.s@intel.com \
    --cc=kunal1.joshi@intel.com \
    --cc=sameer.lattannavar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox