public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH i-g-t 1/4] tests/kms_color_pipeline: use atomic commit helper consistently
@ 2026-02-02  6:04 Chaitanya Kumar Borah
  2026-02-02  6:04 ` [PATCH i-g-t 2/4] tests/kms_color_pipeline: Run tests on all supported planes Chaitanya Kumar Borah
                   ` (6 more replies)
  0 siblings, 7 replies; 12+ messages in thread
From: Chaitanya Kumar Borah @ 2026-02-02  6:04 UTC (permalink / raw)
  To: igt-dev; +Cc: swati2.sharma, pranay.samala, chaitanya.kumar.borah

The color pipeline is an atomic-only feature, so kms_color_pipeline
should not rely on the legacy-compat commit path.

Replace igt_display_commit2(COMMIT_ATOMIC) with
igt_display_commit_atomic() throughout the test to make the atomic
requirement explicit and avoid any ambiguity around commit paths.

No functional change intended.

Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
---
 tests/kms_color_pipeline.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/kms_color_pipeline.c b/tests/kms_color_pipeline.c
index bf8c4734b..7c4b89139 100644
--- a/tests/kms_color_pipeline.c
+++ b/tests/kms_color_pipeline.c
@@ -43,7 +43,7 @@ static void test_cleanup(data_t *data)
 	}
 
 	igt_output_set_crtc(data->output, NULL);
-	igt_display_commit2(&data->display, COMMIT_ATOMIC);
+	igt_display_commit_atomic(&data->display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
 }
 
 static void test_setup(data_t *data, enum pipe p)
@@ -65,7 +65,7 @@ static void test_setup(data_t *data, enum pipe p)
 	data->pipe_crc = igt_crtc_crc_new(data->primary->crtc,
 					  IGT_PIPE_CRC_SOURCE_AUTO);
 
-	igt_display_commit2(&data->display, COMMIT_ATOMIC);
+	igt_display_commit_atomic(&data->display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
 }
 
 static bool ctm_colorop_only(kms_colorop_t *colorops[])
@@ -112,14 +112,14 @@ static bool test_plane_colorops(data_t *data,
 	disable_ctm(plane->crtc);
 	disable_degamma(plane->crtc);
 	disable_gamma(plane->crtc);
-	igt_display_commit2(display, COMMIT_ATOMIC);
+	igt_display_commit_atomic(&data->display, 0, NULL);
 
 	/* Reference (software-equivalent) CRC */
 	set_color_pipeline_bypass(plane);
 	paint_rectangles(data, mode, exp_colors, &fb);
 
 	igt_plane_set_fb(plane, &fb);
-	igt_display_commit2(display, COMMIT_ATOMIC);
+	igt_display_commit_atomic(&data->display, 0, NULL);
 	igt_wait_for_vblank(plane->crtc);
 	igt_pipe_crc_collect_crc(data->pipe_crc, &crc_ref);
 
@@ -135,7 +135,7 @@ static bool test_plane_colorops(data_t *data,
 		paint_gradient_rectangles(data, mode, fb_colors, &fb);
 
 	igt_plane_set_fb(plane, &fb);
-	igt_display_commit2(display, COMMIT_ATOMIC);
+	igt_display_commit_atomic(&data->display, 0, NULL);
 	igt_wait_for_vblank(plane->crtc);
 	igt_pipe_crc_collect_crc(data->pipe_crc, &crc_pipe);
 
@@ -145,7 +145,7 @@ static bool test_plane_colorops(data_t *data,
 	set_color_pipeline_bypass(plane);
 	reset_colorops(colorops);
 	igt_plane_set_fb(plane, NULL);
-	igt_display_commit2(display, COMMIT_ATOMIC);
+	igt_display_commit_atomic(&data->display, 0, NULL);
 
 	igt_remove_fb(data->drm_fd, &fb);
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2026-02-17  9:17 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-02  6:04 [PATCH i-g-t 1/4] tests/kms_color_pipeline: use atomic commit helper consistently Chaitanya Kumar Borah
2026-02-02  6:04 ` [PATCH i-g-t 2/4] tests/kms_color_pipeline: Run tests on all supported planes Chaitanya Kumar Borah
2026-02-12 20:55   ` Sharma, Swati2
2026-02-02  6:04 ` [PATCH i-g-t 3/4] tests/kms_color_pipeline: Disable pipe color properties in test setup Chaitanya Kumar Borah
2026-02-12 20:58   ` Sharma, Swati2
2026-02-02  6:04 ` [PATCH i-g-t 4/4] tests/kms_color_pipeline: collect reference CRC once per pipe Chaitanya Kumar Borah
2026-02-16 20:48   ` Sharma, Swati2
2026-02-17  9:16     ` Borah, Chaitanya Kumar
2026-02-02 21:36 ` ✓ Xe.CI.BAT: success for series starting with [i-g-t,1/4] tests/kms_color_pipeline: use atomic commit helper consistently Patchwork
2026-02-02 21:56 ` ✓ i915.CI.BAT: " Patchwork
2026-02-03  4:32 ` ✗ i915.CI.Full: failure " Patchwork
2026-02-12 20:37 ` [PATCH i-g-t 1/4] " Sharma, Swati2

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox