Re: [PATCH i-g-t 2/2] tests/kms_plane: Skip unsupported modifiers

Naladala, Ramanaidu
2026-02-05T01:16:01Z

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

Hi Pranay,

On 2/4/2026 2:09 PM, Pranay Samala wrote:
> Skip modifier subtests that are not supported.
>
> Signed-off-by: Pranay Samala<pranay.samala@intel.com>
> ---
> tests/kms_plane.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index a7b1bf25d..69d06d627 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -1495,6 +1495,10 @@ run_tests_for_pipe_plane(data_t *data)
> for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
> igt_describe("verify the pixel formats for given plane and pipe");
> igt_subtest_with_dynamic_f("pixel-format-%s-modifier", modifiers[i].str) {
> + igt_require_f(igt_display_has_format_mod(&data->display,
> + DRM_FORMAT_XRGB8888,
> + modifiers[i].modifier),
> + "Modifier not supported\n");
> data->mod = modifiers[i].modifier;
> run_test(data, test_pixel_formats);
> }
> @@ -1504,6 +1508,10 @@ run_tests_for_pipe_plane(data_t *data)
> igt_describe("verify the pixel formats for given plane and pipe with source clamping");
> igt_subtest_with_dynamic_f("pixel-format-%s-modifier-source-clamping",
> modifiers[i].str) {
> + igt_require_f(igt_display_has_format_mod(&data->display,
> + DRM_FORMAT_XRGB8888,
> + modifiers[i].modifier),
> + "Modifier not supported\n");
> data->mod = modifiers[i].modifier;
> data->crop = 4;
> run_test(data, test_pixel_formats);
I suggest moving this check into |run_test()| to avoid duplicate code
across subtests.

Thanks,
Ramanaidu N.

[-- Attachment #2: Type: text/html, Size: 2600 bytes --]