RE: [PATCH i-g-t 1/2] tests/kms_plane: Skip cursor plane for source clamping

B, Jeevan
2026-02-09T05:19:28Z

> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Pranay
> Samala
> Sent: Wednesday, February 4, 2026 2:09 PM
> To: igt-dev@lists.freedesktop.org
> Cc: B S, Karthik <karthik.b.s@intel.com>; Naladala, Ramanaidu
> <ramanaidu.naladala@intel.com>; Lattannavar, Sameer
> <sameer.lattannavar@intel.com>; Samala, Pranay <pranay.samala@intel.com>
> Subject: [PATCH i-g-t 1/2] tests/kms_plane: Skip cursor plane for source clamping
>
> Avoid running source clamping tests on cursor plane, which do not support
> clamping.
>
> Signed-off-by: Pranay Samala <pranay.samala@intel.com>
> ---
> tests/kms_plane.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c index 2be10f032..a7b1bf25d
> 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -1090,12 +1090,6 @@ static void test_format_plane(data_t *data, enum
> pipe pipe,
> bool result = true;
> bool found = false;
>
> - /*
> - * No clamping test for cursor plane
> - */
> - if (data->crop != 0 && plane->type == DRM_PLANE_TYPE_CURSOR)
> - igt_skip("Clamping is invalid for the cursor plane.\n");
> -
> for (int i = 0; i < plane->format_mod_count; i++) {
> if (data->mod == plane->modifiers[i]) {
> found = true;
> @@ -1288,6 +1282,9 @@ test_pixel_formats(data_t *data, enum pipe pipe)
> for_each_plane_on_pipe(&data->display, pipe, plane) {
> if (skip_plane(data, plane))
> continue;

Add a short comment explaining intent:
/* Cursor planes do not support cropping, Skip generating subtest*/

> + if (data->crop != 0 && plane->type ==
> DRM_PLANE_TYPE_CURSOR)
> + continue;
> +
> igt_dynamic_f("pipe-%s-plane-%u", kmstest_pipe_name(pipe),
> plane->index)
> test_format_plane(data, pipe, output, plane,
> &primary_fb);
> }
> --
> 2.34.1