public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Sowmiya S <sowmiya.s@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: swati2.sharma@intel.com, suraj.kandpal@intel.com,
	Sowmiya S <sowmiya.s@intel.com>
Subject: [PATCH i-g-t v8 2/9] lib/igt_fb: Validate supported formats for crc calculation
Date: Wed,  4 Feb 2026 22:48:11 +0530	[thread overview]
Message-ID: <20260204171819.292327-3-sowmiya.s@intel.com> (raw)
In-Reply-To: <20260204171819.292327-1-sowmiya.s@intel.com>

Add logic to verify that provided formats
are supported before proceeding with test
execution for crc calculation

v2: Reframe commit message (Kamil)
    Separate lib changes in single commit (Kamil)
v4: Remove BGR2101010 format verification from
    fnv1a function (Suraj)

Signed-off-by: Sowmiya S <sowmiya.s@intel.com>
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 lib/igt_fb.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index d59fe133b..3a1553d48 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -5035,7 +5035,8 @@ int igt_fb_get_fnv1a_crc(struct igt_fb *fb, igt_crc_t *crc)
 	if (fb->num_planes != 1)
 		return -EINVAL;
 
-	if (fb->drm_format != DRM_FORMAT_XRGB8888 && fb->drm_format != DRM_FORMAT_XRGB2101010)
+	if (fb->drm_format != DRM_FORMAT_XRGB8888 && fb->drm_format != DRM_FORMAT_XRGB2101010 &&
+	    fb->drm_format != DRM_FORMAT_XBGR8888)
 		return -EINVAL;
 
 	ptr = igt_fb_map_buffer(fb->fd, fb);
@@ -5062,7 +5063,8 @@ int igt_fb_get_fnv1a_crc(struct igt_fb *fb, igt_crc_t *crc)
 		for (x = 0; x < fb->width; x++) {
 			uint32_t pixel = le32_to_cpu(line[x]);
 
-			if (fb->drm_format == DRM_FORMAT_XRGB8888)
+			if (fb->drm_format == DRM_FORMAT_XRGB8888 ||
+			    fb->drm_format == DRM_FORMAT_XBGR8888)
 				pixel &= 0x00ffffff;
 			else if (fb->drm_format == DRM_FORMAT_XRGB2101010)
 				pixel &= 0x3fffffff;
-- 
2.43.0


  parent reply	other threads:[~2026-02-04 16:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 17:18 [PATCH i-g-t v8 0/9] Add writeback changes for intel-supported formats Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 1/9] tests/kms_writeback: Add support for intel-specific formats Sowmiya S
2026-02-04 17:18 ` Sowmiya S [this message]
2026-02-04 17:18 ` [PATCH i-g-t v8 3/9] tests/kms_writeback: Update checks for zero FB ID and empty writeback commit Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 4/9] lib/igt_fb: Add helper to get bpc from DRM fourcc Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 5/9] tests/kms_writeback: Refactor format handling in commit_and_dump_fb Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 6/9] tests/kms_writeback: Remove unused invalid_fb parameter Sowmiya S
2026-02-05  2:55   ` Kandpal, Suraj
2026-02-04 17:18 ` [PATCH i-g-t v8 7/9] tests/kms_writeback: Refactor writeback-fb-id subtest Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 8/9] tests/kms_writeback: Refactor writeback-check-output subtest Sowmiya S
2026-02-12 16:04   ` Bilal, Mohammed
2026-02-04 17:18 ` [PATCH i-g-t v8 9/9] tests/kms_writeback: Use helper to fetch default FB format Sowmiya S
2026-02-04 19:07 ` ✓ Xe.CI.BAT: success for Add writeback changes for intel-supported formats (rev8) Patchwork
2026-02-04 19:13 ` ✓ i915.CI.BAT: " Patchwork
2026-02-05  6:13 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-05  9:27 ` ✓ i915.CI.Full: success " Patchwork
2026-02-09  8:14 ` [PATCH i-g-t v8 0/9] Add writeback changes for intel-supported formats Karthik B S
2026-02-09  8:34   ` Kandpal, Suraj
2026-02-13  7:08     ` Karthik B S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204171819.292327-3-sowmiya.s@intel.com \
    --to=sowmiya.s@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=suraj.kandpal@intel.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox