public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Sowmiya S <sowmiya.s@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: swati2.sharma@intel.com, suraj.kandpal@intel.com,
	Sowmiya S <sowmiya.s@intel.com>
Subject: [PATCH i-g-t v8 3/9] tests/kms_writeback: Update checks for zero FB ID and empty writeback commit
Date: Wed,  4 Feb 2026 22:48:12 +0530	[thread overview]
Message-ID: <20260204171819.292327-4-sowmiya.s@intel.com> (raw)
In-Reply-To: <20260204171819.292327-1-sowmiya.s@intel.com>

Intel prohibits committing a framebuffer with fb_id 0
or performing an empty writeback commit. Update assertions
and validation checks accordingly to reflect this restriction.

v4: Restore drm_fd added in struct and access it from
    igt_display_t struct (Suraj)
v5: Revise commit message and subject with detailed
    explanation. (Suraj)
v6: Revise commit message (Suraj)

Signed-off-by: Sowmiya S <sowmiya.s@intel.com>
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
---
 tests/kms_writeback.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
index 691774777..defe43686 100644
--- a/tests/kms_writeback.c
+++ b/tests/kms_writeback.c
@@ -291,7 +291,7 @@ static void writeback_fb_id(igt_output_t *output, igt_fb_t *valid_fb, igt_fb_t *
 
 	/* Zero WRITEBACK_FB_ID */
 	ret = do_writeback_test(output, 0, NULL, false);
-	igt_assert_eq(ret, 0);
+	igt_assert_eq(ret, is_intel_device(output->display->drm_fd) ? -EINVAL : 0);
 
 	/* Valid output buffer */
 	ret = do_writeback_test(output, valid_fb->fb_id, NULL, false);
@@ -406,7 +406,8 @@ static void writeback_check_output(igt_output_t *output, igt_plane_t *plane,
 
 	/* Two commits, the second with no writeback */
 	out_fbs[0] = output_fb;
-	writeback_sequence(output, plane, input_fb, out_fbs, 2, fourcc_color);
+	if (!is_intel_device(output->display->drm_fd))
+		writeback_sequence(output, plane, input_fb, out_fbs, 2, fourcc_color);
 
 	/* Two commits, both with writeback */
 	out_fbs[1] = output_fb;
-- 
2.43.0


  parent reply	other threads:[~2026-02-04 16:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 17:18 [PATCH i-g-t v8 0/9] Add writeback changes for intel-supported formats Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 1/9] tests/kms_writeback: Add support for intel-specific formats Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 2/9] lib/igt_fb: Validate supported formats for crc calculation Sowmiya S
2026-02-04 17:18 ` Sowmiya S [this message]
2026-02-04 17:18 ` [PATCH i-g-t v8 4/9] lib/igt_fb: Add helper to get bpc from DRM fourcc Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 5/9] tests/kms_writeback: Refactor format handling in commit_and_dump_fb Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 6/9] tests/kms_writeback: Remove unused invalid_fb parameter Sowmiya S
2026-02-05  2:55   ` Kandpal, Suraj
2026-02-04 17:18 ` [PATCH i-g-t v8 7/9] tests/kms_writeback: Refactor writeback-fb-id subtest Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 8/9] tests/kms_writeback: Refactor writeback-check-output subtest Sowmiya S
2026-02-12 16:04   ` Bilal, Mohammed
2026-02-04 17:18 ` [PATCH i-g-t v8 9/9] tests/kms_writeback: Use helper to fetch default FB format Sowmiya S
2026-02-04 19:07 ` ✓ Xe.CI.BAT: success for Add writeback changes for intel-supported formats (rev8) Patchwork
2026-02-04 19:13 ` ✓ i915.CI.BAT: " Patchwork
2026-02-05  6:13 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-05  9:27 ` ✓ i915.CI.Full: success " Patchwork
2026-02-09  8:14 ` [PATCH i-g-t v8 0/9] Add writeback changes for intel-supported formats Karthik B S
2026-02-09  8:34   ` Kandpal, Suraj
2026-02-13  7:08     ` Karthik B S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204171819.292327-4-sowmiya.s@intel.com \
    --to=sowmiya.s@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=suraj.kandpal@intel.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox