public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Sowmiya S <sowmiya.s@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: swati2.sharma@intel.com, suraj.kandpal@intel.com,
	Sowmiya S <sowmiya.s@intel.com>
Subject: [PATCH i-g-t v8 6/9] tests/kms_writeback: Remove unused invalid_fb parameter
Date: Wed,  4 Feb 2026 22:48:15 +0530	[thread overview]
Message-ID: <20260204171819.292327-7-sowmiya.s@intel.com> (raw)
In-Reply-To: <20260204171819.292327-1-sowmiya.s@intel.com>

Remove the invalid_fb/output_fb parameter since it is not used
anywhere in the test.

v7: Remove invalid_fb in a separate patch as per review (Suraj)
v8: Move this patch before refactoring writeback-fb-id test (Suraj)

Signed-off-by: Sowmiya S <sowmiya.s@intel.com>
---
 tests/kms_writeback.c | 26 +++-----------------------
 1 file changed, 3 insertions(+), 23 deletions(-)

diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
index 63917bf4f..0c423d58c 100644
--- a/tests/kms_writeback.c
+++ b/tests/kms_writeback.c
@@ -300,7 +300,7 @@ static void test_invalid_parameters(igt_output_t *output, igt_fb_t *valid_fb, ig
 	}
 }
 
-static void writeback_fb_id(igt_output_t *output, igt_fb_t *valid_fb, igt_fb_t *invalid_fb)
+static void writeback_fb_id(igt_output_t *output, igt_fb_t *valid_fb)
 {
 
 	int ret;
@@ -701,36 +701,16 @@ int igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)
 
 	igt_describe("Validate WRITEBACK_FB_ID with valid and invalid options");
 	igt_subtest("writeback-fb-id") {
-		igt_fb_t output_fb;
-
 		igt_skip_on(data.dump_check || data.list_modes);
 		igt_skip_on_f(!(data.supported_colors & XRGB8888),"DRM_FORMAT_XRGB8888 is unsupported\n");
-		fb_id = igt_create_fb(display.drm_fd, mode.hdisplay, mode.vdisplay,
-				      DRM_FORMAT_XRGB8888,
-				      DRM_FORMAT_MOD_LINEAR,
-				      &output_fb);
-		igt_require(fb_id > 0);
-
-		writeback_fb_id(output, &input_fb, &output_fb);
-
-		igt_remove_fb(display.drm_fd, &output_fb);
+		writeback_fb_id(output, &input_fb);
 	}
 
 	igt_describe("Validate XRGB2101010 WRITEBACK_FB_ID with valid and invalid options");
 	igt_subtest("writeback-fb-id-XRGB2101010") {
-		igt_fb_t output_fb;
-
 		igt_skip_on(data.dump_check || data.list_modes);
 		igt_skip_on_f(!(data.supported_colors & XRGB2101010), "DRM_FORMAT_XRGB2101010 is unsupported\n");
-		fb_id = igt_create_fb(display.drm_fd, mode.hdisplay, mode.vdisplay,
-				      DRM_FORMAT_XRGB2101010,
-				      DRM_FORMAT_MOD_LINEAR,
-				      &output_fb);
-		igt_require(fb_id > 0);
-
-		writeback_fb_id(output, &input_fb_10bit, &output_fb);
-
-		igt_remove_fb(display.drm_fd, &output_fb);
+		writeback_fb_id(output, &input_fb_10bit);
 	}
 
 	igt_describe("Check writeback output with CRC validation");
-- 
2.43.0


  parent reply	other threads:[~2026-02-04 16:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04 17:18 [PATCH i-g-t v8 0/9] Add writeback changes for intel-supported formats Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 1/9] tests/kms_writeback: Add support for intel-specific formats Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 2/9] lib/igt_fb: Validate supported formats for crc calculation Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 3/9] tests/kms_writeback: Update checks for zero FB ID and empty writeback commit Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 4/9] lib/igt_fb: Add helper to get bpc from DRM fourcc Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 5/9] tests/kms_writeback: Refactor format handling in commit_and_dump_fb Sowmiya S
2026-02-04 17:18 ` Sowmiya S [this message]
2026-02-05  2:55   ` [PATCH i-g-t v8 6/9] tests/kms_writeback: Remove unused invalid_fb parameter Kandpal, Suraj
2026-02-04 17:18 ` [PATCH i-g-t v8 7/9] tests/kms_writeback: Refactor writeback-fb-id subtest Sowmiya S
2026-02-04 17:18 ` [PATCH i-g-t v8 8/9] tests/kms_writeback: Refactor writeback-check-output subtest Sowmiya S
2026-02-12 16:04   ` Bilal, Mohammed
2026-02-04 17:18 ` [PATCH i-g-t v8 9/9] tests/kms_writeback: Use helper to fetch default FB format Sowmiya S
2026-02-04 19:07 ` ✓ Xe.CI.BAT: success for Add writeback changes for intel-supported formats (rev8) Patchwork
2026-02-04 19:13 ` ✓ i915.CI.BAT: " Patchwork
2026-02-05  6:13 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-05  9:27 ` ✓ i915.CI.Full: success " Patchwork
2026-02-09  8:14 ` [PATCH i-g-t v8 0/9] Add writeback changes for intel-supported formats Karthik B S
2026-02-09  8:34   ` Kandpal, Suraj
2026-02-13  7:08     ` Karthik B S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204171819.292327-7-sowmiya.s@intel.com \
    --to=sowmiya.s@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=suraj.kandpal@intel.com \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox