From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08259E91286 for ; Thu, 5 Feb 2026 07:04:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9025A10E7CF; Thu, 5 Feb 2026 07:04:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="NkqbpFpo"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id 24C2110E7CF for ; Thu, 5 Feb 2026 07:04:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770275086; x=1801811086; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=ZVJY6RbaQorVWpiI1PmTopMpjUCq8ED4zWfAASMIW1g=; b=NkqbpFpopex9vG25rFpuGa5HMWrEhRY2R/deN2Yumsr3EZhiARbVCORN NU7OUjW97SoAsc957yagsURlh1Bk3xyx+9tTk7ylEO5I6BvN76JceY3dT exdTi4qiA8evVCNcP4fSY6zJG/wDjoanDRQLzhqaLdEYzPYm5LdSXLVit AIrB8DS5OsYzE2SrBkPVms0XRm7mXlpxpR36ZDxrj6PbELd3H9wqvTaYh Gn39jyF3jPgK0IyGt+cL7v58q9M74/0FC+efc4+WDoT9yfb9otvUONAMZ oH+udwUYewC8/ZtI+AAgT5r4Q6bVfnaybJUmMgEED4bEGm2w6+nOlxp3h A==; X-CSE-ConnectionGUID: O/+pnZvWTQqGaQb6jl0xTg== X-CSE-MsgGUID: RxaT3V/PThCMFD8BzXRSuw== X-IronPort-AV: E=McAfee;i="6800,10657,11691"; a="70486954" X-IronPort-AV: E=Sophos;i="6.21,274,1763452800"; d="scan'208";a="70486954" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2026 23:04:46 -0800 X-CSE-ConnectionGUID: Gynm+uvrTzWNx0HLyOyfDw== X-CSE-MsgGUID: LFYEdfa8RTOqqwf8wywcpw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,274,1763452800"; d="scan'208";a="210495575" Received: from kniemiec-mobl1.ger.corp.intel.com (HELO jhogande-mobl3.intel.com) ([10.245.246.51]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2026 23:04:44 -0800 From: =?UTF-8?q?Jouni=20H=C3=B6gander?= To: igt-dev@lists.freedesktop.org Cc: =?UTF-8?q?Jouni=20H=C3=B6gander?= , Kunal Joshi Subject: [PATCH i-g-t v3 1/3] tests/intel/kms_psr2_sf: Drop Early Transport flag from data_t Date: Thu, 5 Feb 2026 09:04:23 +0200 Message-ID: <20260205070425.300934-2-jouni.hogander@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260205070425.300934-1-jouni.hogander@intel.com> References: <20260205070425.300934-1-jouni.hogander@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" Implement helper to detect need for Early Transport check and use that to figure out if Early Transport check is needed. Drop et_flag from data_t. Signed-off-by: Jouni Högander Reviewed-by: Kunal Joshi --- tests/intel/kms_psr2_sf.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/tests/intel/kms_psr2_sf.c b/tests/intel/kms_psr2_sf.c index e23999544..53565ada1 100644 --- a/tests/intel/kms_psr2_sf.c +++ b/tests/intel/kms_psr2_sf.c @@ -224,7 +224,6 @@ typedef struct { igt_plane_t *test_plane; bool big_fb_test; bool fbc_flag; - bool et_flag; cairo_t *cr; uint32_t screen_changes; int cur_x, cur_y; @@ -237,17 +236,30 @@ typedef struct { } coexist_feature; } data_t; +static bool is_et_check_needed(data_t *data) +{ + switch (data->psr_mode) { + case PR_MODE_SEL_FETCH: + case PR_MODE_SEL_FETCH_ET: + return true; + case PSR_MODE_2: + case PSR_MODE_2_SEL_FETCH: + case PSR_MODE_2_ET: + return psr_sink_support(data->drm_fd, data->debugfs_fd, + PSR_MODE_2_ET, data->output); + default: + igt_assert(false); + } +} + static bool set_sel_fetch_mode_for_output(data_t *data) { bool supported = false; - data->et_flag = false; - if (psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE_SEL_FETCH_ET, data->output)) { supported = true; data->psr_mode = PR_MODE_SEL_FETCH; - data->et_flag = true; } else if (psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE_SEL_FETCH, data->output)) { supported = true; @@ -256,7 +268,6 @@ static bool set_sel_fetch_mode_for_output(data_t *data) PSR_MODE_2_ET, data->output)) { supported = true; data->psr_mode = PSR_MODE_2; - data->et_flag = true; } else if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_2, data->output)) { supported = true; @@ -977,9 +988,7 @@ static void run(data_t *data) data->pipe), "FBC still disabled\n"); - /* TODO: Enable this check if other connectors support Early Transport */ - if (data->et_flag && data->output != NULL && - data->output->config.connector->connector_type == DRM_MODE_CONNECTOR_eDP) + if (is_et_check_needed(data)) igt_assert_f(early_transport_check(data->debugfs_fd), "Early Transport Disabled\n"); -- 2.43.0