From: Pranay Samala <pranay.samala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, sameer.lattannavar@intel.com,
pranay.samala@intel.com
Subject: [PATCH i-g-t] tests/intel/kms_sharpness_filter: Restructure modifier validation into per-modifier subtests
Date: Tue, 17 Feb 2026 15:00:48 +0530 [thread overview]
Message-ID: <20260217093048.1597495-1-pranay.samala@intel.com> (raw)
Previously, all modifiers were exercised within a single
subtest, making failures/skips hard to isolate and debug.
This new flow generates explicit subtest names (filter-modifier-%s)
for each modifier, improving clarity and CI reporting.
Each subtest now validates only the selected modifier, and
unsupported format/modifier combinations are cleanly skipped.
Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
tests/intel/kms_sharpness_filter.c | 34 +++++++++++++++++++++---------
1 file changed, 24 insertions(+), 10 deletions(-)
diff --git a/tests/intel/kms_sharpness_filter.c b/tests/intel/kms_sharpness_filter.c
index eddfad6b9..0140363bc 100644
--- a/tests/intel/kms_sharpness_filter.c
+++ b/tests/intel/kms_sharpness_filter.c
@@ -21,9 +21,6 @@
* SUBTEST: filter-strength
* Description: Verify that varying strength (0-255), affects the degree of sharpeness applied.
*
- * SUBTEST: filter-modifiers
- * Description: Verify content adaptive sharpness filter with varying modifiers.
- *
* SUBTEST: filter-rotations
* Description: Verify content adaptive sharpness filter with varying rotations.
*
@@ -70,6 +67,17 @@
* sharpness filter.
*/
+/**
+ * SUBTEST: filter-modifier-%s
+ * Description: Verify content adaptive sharpness filter with varying modifiers.
+ *
+ * arg[1]:
+ *
+ * @linear: linear
+ * @x-tiled: x-tiled
+ * @4-tiled: 4-tiled
+ */
+
IGT_TEST_DESCRIPTION("Test to validate content adaptive sharpness filter");
/*
@@ -596,16 +604,22 @@ int igt_main_args("l", NULL, help_str, opt_handler, &data)
}
}
- igt_describe("Verify content adaptive sharpness filter with "
- "varying modifiers.");
- igt_subtest_with_dynamic("filter-modifiers") {
+ for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
data.rotation = IGT_ROTATION_0;
data.format = DRM_FORMAT_XRGB8888;
data.filter_strength = MID_FILTER_STRENGTH;
-
- for (int i = 0; i < ARRAY_SIZE(modifiers); i++) {
- data.modifier = modifiers[i].modifier;
- data.modifier_name = modifiers[i].name;
+ data.modifier = modifiers[i].modifier;
+ data.modifier_name = modifiers[i].name;
+
+ igt_describe("Verify content adaptive sharpness filter with "
+ "varying modifiers.");
+ igt_subtest_with_dynamic_f("filter-modifier-%s", data.modifier_name) {
+ igt_skip_on_f((!igt_display_has_format_mod(&data.display,
+ DRM_FORMAT_XBGR8888,
+ data.modifier)),
+ "Skipping: Modifier " IGT_MODIFIER_FMT
+ " is not supported on this platform\n",
+ IGT_MODIFIER_ARGS(data.modifier));
run_sharpness_filter_test(&data, TEST_FILTER_MODIFIERS);
}
--
2.34.1
next reply other threads:[~2026-02-17 9:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 9:30 Pranay Samala [this message]
2026-02-17 20:30 ` ✓ Xe.CI.BAT: success for tests/intel/kms_sharpness_filter: Restructure modifier validation into per-modifier subtests Patchwork
2026-02-17 21:01 ` ✓ i915.CI.BAT: " Patchwork
2026-02-17 23:38 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-18 3:11 ` ✗ i915.CI.Full: " Patchwork
2026-02-26 3:01 ` [PATCH i-g-t] " Naladala, Ramanaidu
2026-02-26 3:48 ` Samala, Pranay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260217093048.1597495-1-pranay.samala@intel.com \
--to=pranay.samala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=sameer.lattannavar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox