Re: [PATCH i-g-t] panthor: Enable compilation on big-endian arch

[Boris Brezillon <boris.brezillon@collabora.com>]

On Wed, 18 Feb 2026 16:34:44 +0100
Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:

> Compilation of Panthor was broken on big-endian due to a guard in
> pathor lib against such arch. Fix this and create and use a macro
> for skipping all panthor tests on such machines.
> 
> Also while at it, init fd so it could be safely used at last
> fixture.
> 
> Cc: Daniel Almeida <daniel.almeida@collabora.com>
> Cc: Boris Brezillon <boris.brezillon@collabora.com>
> Closes: https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/issues/200
> Signed-off-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
>  lib/igt_panthor.c             | 17 +++++++++++++++++
>  lib/igt_panthor.h             |  6 ++----
>  tests/panthor/panthor_gem.c   |  3 ++-
>  tests/panthor/panthor_group.c |  3 ++-
>  tests/panthor/panthor_query.c |  3 ++-
>  tests/panthor/panthor_vm.c    |  3 ++-
>  6 files changed, 27 insertions(+), 8 deletions(-)
> 
> diff --git a/lib/igt_panthor.c b/lib/igt_panthor.c
> index 49b427d4f..cf065352d 100644
> --- a/lib/igt_panthor.c
> +++ b/lib/igt_panthor.c
> @@ -6,6 +6,23 @@
>  #include "ioctl_wrappers.h"
>  #include "panthor_drm.h"
>  
> +/**
> + * igt_panthor_skip_on_big_endian:
> + *
> + * Skip Panthor test on bing-endian machines.

			   ^ big-endian

> + */
> +void igt_panthor_skip_on_big_endian(void)
> +{
> +#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
> + #define IGT_PANTHOR_ON_BIG_ENDIAN 1
> +#else
> + #define IGT_PANTHOR_ON_BIG_ENDIAN 0
> +#endif
> +
> +	igt_skip_on_f(IGT_PANTHOR_ON_BIG_ENDIAN, "Panthor is unsupported on big-endian arch\n");
> +#undef IGT_PANTHOR_ON_BIG_ENDIAN

Can't we just go with

	igt_skip_on_f(__BYTE_ORDER__ == __ORDER_BIG_ENDIAN__,
		      "Panthor is unsupported on big-endian arch\n");

and drop the IGT_PANTHOR_ON_BIG_ENDIAN definition?

> +}

The rest looks good to me.

Regards,

Boris