public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Swati Sharma <swati2.sharma@intel.com>
Subject: [PATCH i-g-t] tests/intel/kms_cdclk: Skip CDCLK bump validation on connectors with fixed modes
Date: Fri, 20 Feb 2026 17:15:02 +0530	[thread overview]
Message-ID: <20260220114502.469833-1-swati2.sharma@intel.com> (raw)

eDP panels and some other connectors may expose a fixed or very limited
set of modes, often differing only in refresh rate. In such cases, the
computed CDCLK requirement for both low and high refresh modes can end
up identical.

Since no CDCLK recomputation or bump is expected in this scenario,
validating CDCLK bump behavior on such connectors can lead to false
test failures.

Skip CDCLK bump validation on connectors that expose fixed modes
and restrict testing to outputs where mode variation meaningfully
exercises CDCLK recomputation.

Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/intel/kms_cdclk.c | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/tests/intel/kms_cdclk.c b/tests/intel/kms_cdclk.c
index eb8b79c44..84394723a 100644
--- a/tests/intel/kms_cdclk.c
+++ b/tests/intel/kms_cdclk.c
@@ -72,6 +72,15 @@ static bool hardware_supported(data_t *data)
 	return false;
 }
 
+static bool has_scaling_mode_prop(data_t *data, igt_output_t *output)
+{
+	return kmstest_get_property(data->drm_fd,
+				    output->id,
+				    DRM_MODE_OBJECT_CONNECTOR,
+				    "scaling mode",
+				    NULL, NULL, NULL);
+}
+
 static __u64 get_mode_data_rate(drmModeModeInfo *mode)
 {
 	__u64 data_rate = (__u64)mode->hdisplay * (__u64)mode->vdisplay * (__u64)mode->vrefresh;
@@ -329,6 +338,26 @@ static void run_cdclk_test(data_t *data, uint32_t flags)
 	igt_crtc_t *crtc;
 
 	for_each_crtc_with_valid_output(display, crtc, output) {
+                /*
+		 * Some connectors (eg. embedded panels) expose a fixed or
+	         * very limited set of modes, often only differing in refresh
+	         * rate. In such cases, the required CDCLK for both low and
+	         * high refresh modes may end up identical.
+	         *
+	         * Since no CDCLK recomputation or bump is expected for such
+	         * connectors, validating CDCLK bump behavior would lead to
+	         * false negatives.
+	         *
+	         * Skip CDCLK bump validation on connectors exposing fixed
+	         * modes and restrict testing to outputs where mode variation
+		 * can meaningfully exercise CDCLK changes.
+	         */
+		if (!has_scaling_mode_prop(data, output)) {
+			igt_info("Skipping: CDCLK bump validation on %s: "
+				 "connector exposes fixed/limited modes\n", output->name);
+			continue;
+		}
+
 		igt_output_set_crtc(output,
 				    crtc);
 		if (!intel_pipe_output_combo_valid(display)) {
-- 
2.25.1


             reply	other threads:[~2026-02-20 11:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-20 11:45 Swati Sharma [this message]
2026-02-20 12:31 ` ✓ Xe.CI.BAT: success for tests/intel/kms_cdclk: Skip CDCLK bump validation on connectors with fixed modes Patchwork
2026-02-20 12:39 ` ✓ i915.CI.BAT: " Patchwork
2026-02-20 15:20 ` ✗ i915.CI.Full: failure " Patchwork
2026-02-20 23:56 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260220114502.469833-1-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox