From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F578C54FD2 for ; Fri, 20 Feb 2026 14:02:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4B22310E7E8; Fri, 20 Feb 2026 14:02:13 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="BItdmeNT"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67D4C10E7F5 for ; Fri, 20 Feb 2026 14:02:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771596132; x=1803132132; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=OpygdYumqwcld8rInahiolV6OJZECIlEnqCB2sVW3jU=; b=BItdmeNTJEZQA6xNWPm6zeFDnzZo/33w30E7LD82l6n1Bl1A2ItjQz7E G/xW8KYTQMx9PlwS+h3thjFH0qsxFJcszKZYidGTp+RXX5GSv6VpyM2Lw uWAd2I+O0N2jzEehMrXLwfFjZcEMTsY57PzjNx5yfjgA64McoEQjrJYpO sexlOUwot24lu0GA/TKLlo0xZjG4UE64PcV6Xx7VO9cUev2UwyHTB4irf 3t41ADcLoYpB/cfviM+Wm8LF8CUDhQBGcoeuW/T1a+16HXriVLIvo2B5P 1bcubYHfjZhwTXfI+aDk4Su1utZAA4dLY2pyLYRWqzepPmGCkmct6wetu Q==; X-CSE-ConnectionGUID: Z2i618AYQPK8c9SiTQikCA== X-CSE-MsgGUID: VcRee84gTPiYcQ37USZnSQ== X-IronPort-AV: E=McAfee;i="6800,10657,11707"; a="83007005" X-IronPort-AV: E=Sophos;i="6.21,302,1763452800"; d="scan'208";a="83007005" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2026 06:02:12 -0800 X-CSE-ConnectionGUID: ejgq5ClXSrq3ViVaVP6zKw== X-CSE-MsgGUID: ngcdK4X4SUeq/iW7agq5mQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,302,1763452800"; d="scan'208";a="214973647" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.244.247]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Feb 2026 06:02:11 -0800 From: Ville Syrjala To: igt-dev@lists.freedesktop.org Cc: George Zhang , Tom Chung Subject: [PATCH i-g-t 03/21] tests/amdgpu/amd_abm: Don't use uninitialized 'pipe' Date: Fri, 20 Feb 2026 16:01:35 +0200 Message-ID: <20260220140154.4138-4-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260220140154.4138-1-ville.syrjala@linux.intel.com> References: <20260220140154.4138-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" From: Ville Syrjälä The for_each_valid_output_on_pipe() loops in amd_abm use an uninitialized 'pipe' variable. Not entirely sure what the intention was with the change to for_each_valid_output_on_pipe(), but eg. set_abm_level() gets called from those loops and it operates on data->pipe_id instead of whatever stack garbage pipe the loop happens to use. So let's assume the intention was to use the same fixed pipe for everything and just pass data->pipe_id to for_each_valid_output_on_pipe(). #include "scripts/iterators.cocci" @@ iterator name for_each_valid_output_on_pipe; expression DISPLAY, OUTPUT; identifier PIPE; type T; @@ - T PIPE; <+... when != PIPE = ... for_each_valid_output_on_pipe(DISPLAY, - PIPE, + data->pipe_id, OUTPUT) {...} ...+> Cc: George Zhang Cc: Tom Chung Fixes: 1235576931b5 ("tests/amdgpu/amd_abm: Fixed tests to only run on one output per pipe") Signed-off-by: Ville Syrjälä --- tests/amdgpu/amd_abm.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c index 110dd89e3ac2..159f6c7c69e9 100644 --- a/tests/amdgpu/amd_abm.c +++ b/tests/amdgpu/amd_abm.c @@ -170,10 +170,9 @@ static void test_fini(data_t *data) { igt_display_t *display = &data->display; igt_output_t *output; - enum pipe pipe; /* Disable ABM before exit test */ - for_each_valid_output_on_pipe(&data->display, pipe, output) { + for_each_valid_output_on_pipe(&data->display, data->pipe_id, output) { if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP) continue; set_abm_level(data, output, 0); @@ -328,9 +327,8 @@ static void backlight_dpms_cycle(data_t *data) int max_brightness; int pwm_1, pwm_2; igt_output_t *output; - enum pipe pipe; - for_each_valid_output_on_pipe(&data->display, pipe, output) { + for_each_valid_output_on_pipe(&data->display, data->pipe_id, output) { if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP) continue; @@ -359,10 +357,9 @@ static void backlight_monotonic_basic(data_t *data) int prev_pwm, pwm; int brightness_step; int brightness; - enum pipe pipe; igt_output_t *output; - for_each_valid_output_on_pipe(&data->display, pipe, output) { + for_each_valid_output_on_pipe(&data->display, data->pipe_id, output) { if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP) continue; ret = backlight_read_max_brightness(&max_brightness); @@ -393,10 +390,9 @@ static void backlight_monotonic_abm(data_t *data) int prev_pwm, pwm; int brightness_step; int brightness; - enum pipe pipe; igt_output_t *output; - for_each_valid_output_on_pipe(&data->display, pipe, output) { + for_each_valid_output_on_pipe(&data->display, data->pipe_id, output) { if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP) continue; ret = backlight_read_max_brightness(&max_brightness); @@ -426,10 +422,9 @@ static void abm_enabled(data_t *data) int ret, i; int max_brightness; int pwm, prev_pwm, pwm_without_abm; - enum pipe pipe; igt_output_t *output; - for_each_valid_output_on_pipe(&data->display, pipe, output) { + for_each_valid_output_on_pipe(&data->display, data->pipe_id, output) { if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP) continue; @@ -460,10 +455,9 @@ static void abm_gradual(data_t *data) int convergence_delay = 10; int prev_pwm, pwm, curr; int max_brightness; - enum pipe pipe; igt_output_t *output; - for_each_valid_output_on_pipe(&data->display, pipe, output) { + for_each_valid_output_on_pipe(&data->display, data->pipe_id, output) { if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP) continue; -- 2.52.0