From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: igt-dev@lists.freedesktop.org
Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Subject: [PATCH i-g-t 5/8] lib/intel_batchbuffer: move engine class selection to helper
Date: Fri, 20 Feb 2026 18:17:15 +0200 [thread overview]
Message-ID: <20260220161718.652862-6-juhapekka.heikkila@gmail.com> (raw)
In-Reply-To: <20260220161718.652862-1-juhapekka.heikkila@gmail.com>
move engine class selection to helper to avoid duplicate code
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
lib/intel_batchbuffer.c | 42 +++++++++++++++++++++--------------------
1 file changed, 22 insertions(+), 20 deletions(-)
diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
index d8e5816ee..365976be5 100644
--- a/lib/intel_batchbuffer.c
+++ b/lib/intel_batchbuffer.c
@@ -2466,6 +2466,26 @@ static void update_offsets(struct intel_bb *ibb,
}
}
+static unsigned short get_engine_class(int fd, uint64_t flags)
+{
+ switch (flags & I915_EXEC_RING_MASK) {
+ case I915_EXEC_DEFAULT:
+ case I915_EXEC_BLT:
+ return DRM_XE_ENGINE_CLASS_COPY;
+ case I915_EXEC_BSD:
+ return DRM_XE_ENGINE_CLASS_VIDEO_DECODE;
+ case I915_EXEC_RENDER:
+ if (xe_has_engine_class(fd, DRM_XE_ENGINE_CLASS_RENDER))
+ return DRM_XE_ENGINE_CLASS_RENDER;
+ else
+ return DRM_XE_ENGINE_CLASS_COMPUTE;
+ case I915_EXEC_VEBOX:
+ return DRM_XE_ENGINE_CLASS_VIDEO_ENHANCE;
+ default:
+ igt_assert_f(false, "Unknown engine: %x", (uint32_t)flags);
+ }
+}
+
#define LINELEN 76
/*
@@ -2508,26 +2528,8 @@ int __xe_bb_exec(struct intel_bb *ibb, uint64_t flags, bool sync)
inst.engine_instance =
(flags & I915_EXEC_BSD_MASK) >> I915_EXEC_BSD_SHIFT;
- switch (flags & I915_EXEC_RING_MASK) {
- case I915_EXEC_DEFAULT:
- case I915_EXEC_BLT:
- inst.engine_class = DRM_XE_ENGINE_CLASS_COPY;
- break;
- case I915_EXEC_BSD:
- inst.engine_class = DRM_XE_ENGINE_CLASS_VIDEO_DECODE;
- break;
- case I915_EXEC_RENDER:
- if (xe_has_engine_class(ibb->fd, DRM_XE_ENGINE_CLASS_RENDER))
- inst.engine_class = DRM_XE_ENGINE_CLASS_RENDER;
- else
- inst.engine_class = DRM_XE_ENGINE_CLASS_COMPUTE;
- break;
- case I915_EXEC_VEBOX:
- inst.engine_class = DRM_XE_ENGINE_CLASS_VIDEO_ENHANCE;
- break;
- default:
- igt_assert_f(false, "Unknown engine: %x", (uint32_t) flags);
- }
+ inst.engine_class = get_engine_class(ibb->fd, flags);
+
igt_debug("Run on %s\n", xe_engine_class_string(inst.engine_class));
if (ibb->engine_id)
--
2.43.0
next prev parent reply other threads:[~2026-02-20 16:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 16:17 [PATCH i-g-t 0/8] Enable Vebox engine copy on Intel Xe driver Juha-Pekka Heikkila
2026-02-20 16:17 ` [PATCH i-g-t 1/8] lib: take out duplicate assert Juha-Pekka Heikkila
2026-02-20 16:17 ` [PATCH i-g-t 2/8] lib/intel_batchbuffer: make __intel_bb_create gt aware Juha-Pekka Heikkila
2026-02-20 16:17 ` [PATCH i-g-t 3/8] lib/xe: add xe_exec_queue_create_class_gt Juha-Pekka Heikkila
2026-02-20 16:17 ` [PATCH i-g-t 4/8] lib/intel_batchbuffer: add intel_bb_create_with_gt function Juha-Pekka Heikkila
2026-02-20 16:17 ` Juha-Pekka Heikkila [this message]
2026-02-20 16:17 ` [PATCH i-g-t 6/8] lib/intel_batchbuffer/xe: add bb exec path to use specific engine and gt Juha-Pekka Heikkila
2026-02-20 16:17 ` [PATCH i-g-t 7/8] lib: Enable Vebox framebuffer copying on Intel Xe2 Juha-Pekka Heikkila
2026-02-20 16:17 ` [PATCH i-g-t 8/8] lib/igt_fb: on Intel force Vebox copy on yuv formats Juha-Pekka Heikkila
2026-02-20 22:34 ` ✗ Xe.CI.BAT: failure for Enable Vebox engine copy on Intel Xe driver (rev5) Patchwork
2026-02-20 22:40 ` ✓ i915.CI.BAT: success " Patchwork
2026-02-21 2:00 ` ✗ Xe.CI.BAT: failure for Enable Vebox engine copy on Intel Xe driver (rev6) Patchwork
2026-02-21 2:11 ` ✓ i915.CI.BAT: success " Patchwork
2026-02-21 13:06 ` ✗ i915.CI.Full: failure for Enable Vebox engine copy on Intel Xe driver (rev5) Patchwork
2026-02-21 14:44 ` ✗ i915.CI.Full: failure for Enable Vebox engine copy on Intel Xe driver (rev6) Patchwork
2026-02-23 11:16 ` ✗ Xe.CI.FULL: failure for Enable Vebox engine copy on Intel Xe driver (rev5) Patchwork
2026-02-23 12:38 ` ✗ Xe.CI.FULL: failure for Enable Vebox engine copy on Intel Xe driver (rev6) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2026-03-13 13:51 [PATCH i-g-t 0/8] Enable Vebox engine copy on Intel Xe driver Juha-Pekka Heikkila
2026-03-13 13:52 ` [PATCH i-g-t 5/8] lib/intel_batchbuffer: move engine class selection to helper Juha-Pekka Heikkila
2026-03-18 15:05 [PATCH i-g-t 0/8] Enable Vebox engine copy on Intel Xe driver Juha-Pekka Heikkila
2026-03-18 15:05 ` [PATCH i-g-t 5/8] lib/intel_batchbuffer: move engine class selection to helper Juha-Pekka Heikkila
2026-03-20 13:46 [PATCH i-g-t 0/8] Enable Vebox engine copy on Intel Xe driver Juha-Pekka Heikkila
2026-03-20 13:46 ` [PATCH i-g-t 5/8] lib/intel_batchbuffer: move engine class selection to helper Juha-Pekka Heikkila
2026-03-23 16:29 [PATCH i-g-t 0/8] Enable Vebox engine copy on Intel Xe driver Juha-Pekka Heikkila
2026-03-23 16:29 ` [PATCH i-g-t 5/8] lib/intel_batchbuffer: move engine class selection to helper Juha-Pekka Heikkila
2026-04-19 15:58 ` Naladala, Ramanaidu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220161718.652862-6-juhapekka.heikkila@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox