Re: [PATCH i-g-t v2 03/23] tests/intel/kms_flip_scaled_crc: Remove unused 'enum pipe pipe'

Jani Nikula
2026-02-23T11:34:57Z

On Sat, 21 Feb 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> kms_flip_scaled_crc has a data.pipe member that it never uses
> for anythinh. Nuke it.

*anything

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

>
> #include "scripts/iterators.cocci"
>
> @find_pipe@
> typedef igt_crtc_t;
> typedef igt_display_t;
> identifier PIPE;
> type T;
> @@
> T {
> ...
> enum pipe PIPE;
> ...
> };
>
> @use_pipe depends on find_pipe@
> identifier find_pipe.PIPE;
> find_pipe.T S;
> find_pipe.T *P;
> @@
> (
> S.PIPE
> |
> P->PIPE
> )
>
> @remove_pipe depends on find_pipe && !use_pipe@
> identifier find_pipe.PIPE;
> type find_pipe.T;
> @@
> T {
> ...
> - enum pipe PIPE;
> ...
> };
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/intel/kms_flip_scaled_crc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/intel/kms_flip_scaled_crc.c b/tests/intel/kms_flip_scaled_crc.c
> index 9a0b99e46ddd..83674d5c267f 100644
> --- a/tests/intel/kms_flip_scaled_crc.c
> +++ b/tests/intel/kms_flip_scaled_crc.c
> @@ -143,7 +143,6 @@ typedef struct {
> int drm_fd;
> igt_display_t display;
> igt_output_t *output;
> - enum pipe pipe;
> uint32_t gen;
> struct igt_fb small_fb;
> struct igt_fb big_fb;

--
Jani Nikula, Intel