Re: [PATCH i-g-t v2 06/23] tests/kms: Use 'enum pipe' over int'

Jani Nikula
2026-02-23T11:44:23Z

On Sat, 21 Feb 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Convert a few 'int pipe's tp 'enum pipe pipe's. This will help
> subsequent cocci based pipe->crtc conversions.

*to

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/intel/kms_flip_tiling.c | 2 +-
> tests/nouveau_crc.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/intel/kms_flip_tiling.c b/tests/intel/kms_flip_tiling.c
> index 453394343857..54446f2478ae 100644
> --- a/tests/intel/kms_flip_tiling.c
> +++ b/tests/intel/kms_flip_tiling.c
> @@ -67,7 +67,7 @@ static void pipe_crc_free(data_t *data)
> data->pipe_crc = NULL;
> }
>
> -static void pipe_crc_new(data_t *data, int pipe)
> +static void pipe_crc_new(data_t *data, enum pipe pipe)
> {
> igt_display_t *display = &data->display;
> if (data->pipe_crc)
> diff --git a/tests/nouveau_crc.c b/tests/nouveau_crc.c
> index 9013b7e53df8..b2f9f3bdd08d 100644
> --- a/tests/nouveau_crc.c
> +++ b/tests/nouveau_crc.c
> @@ -31,7 +31,7 @@ IGT_TEST_DESCRIPTION(
> "such as context flipping.");
>
> typedef struct {
> - int pipe;
> + enum pipe pipe;
> int drm_fd;
> int nv_crc_dir;
> igt_display_t display;

--
Jani Nikula, Intel