Re: [PATCH i-g-t v2 15/23] tests/kms_plane_multiple: Use igt_crtc_t instead of enum pipe

Ville Syrjälä
2026-02-25T07:44:57Z

On Tue, Feb 24, 2026 at 03:48:13PM +0200, Jani Nikula wrote:
> On Sat, 21 Feb 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Convert kms_plane_multiple from 'enum pipe' to 'igt_crtc_t'.
> >
> > The use of multiple crtcs in some places causes some extra
> > complications here.
> >
> > #include "scripts/iterators.cocci"
>
> ...
>
> > @@ -554,8 +567,9 @@ static void run_2_display_test(data_t *data, uint64_t modifier, const char *name
> > igt_crtc_name(crtc2),
> > output2->name)
> > test_plane_position_2_display(data,
> > - crtc->pipe,
> > - crtc2->pipe,
> > + crtc
> > + ,
>
> I wonder what happened here with the newlines. Can be fixed while
> applying.

Cocci just going mad as usual. It's really inconsistent with newlines.
After who knows how many spatch reruns I got fed up cleaning up after
it.

>
> Reviewed-by: Jani Nikula <jani.nikula@intel.com>
>
>
> > + crtc2,
> > output1, output2,
> > modifier);
> >
> > @@ -584,7 +598,9 @@ static void run_test(data_t *data, uint64_t modifier, const char *name)
> > continue;
> >
> > igt_dynamic_f("pipe-%s-%s", igt_crtc_name(crtc), output->name)
> > - test_plane_position(data, crtc->pipe, output,
> > + test_plane_position(data,
> > + crtc,
> > + output,
> > modifier);
> > }
> > }
>
> --
> Jani Nikula, Intel

--
Ville Syrjälä
Intel