From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47EFFEC1120 for ; Mon, 23 Feb 2026 19:01:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B913F10E421; Mon, 23 Feb 2026 19:01:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="k+iXNGX3"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) by gabe.freedesktop.org (Postfix) with ESMTPS id 31A6210E41E for ; Mon, 23 Feb 2026 19:01:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771873275; x=1803409275; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=/nr7g7k8Rtyhq4vfykU+vSEQ2tW/251cNv039ou8448=; b=k+iXNGX3LETuI6xzgqWya1z95a3yTozvkiBlfaZsrklF+KEy8saZy/32 5fEYG4idleOiw7XBMwgwiMxtImWJ19YRqP8ARXIjA3m537vlyd9VVcnaY j7XBwdt5LgF0izt1dE1jy64IGD/6EtC/UxYE5jK7z38v76MZPMdLizEWs izuoRAjo+yS42uu5ccMB2oVytXMZ+z0YUvWJnCVIqdOIgKRJ9NenK0TYV WV5f6HvLZzBcrNyixFDFqOgNO00MuvqBA3dn5Jx6ie2tV8g+rwx/LP4nz F7S/5a3Rc9O+Pl2tmgDjIcDDj9YyECu9hEXgp1JtU09QUqwWEEHV62ysJ g==; X-CSE-ConnectionGUID: vYMpr9szRWSmRL44B+ZdbA== X-CSE-MsgGUID: 2UpRkUo5Q++yCgzKTn7hmg== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="72755025" X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="72755025" Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 10:59:22 -0800 X-CSE-ConnectionGUID: mrZmwSioQY+WnaDm7GlP1g== X-CSE-MsgGUID: a7mOsQsiS5+ckrOuVOKUmg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,307,1763452800"; d="scan'208";a="215674812" Received: from llaguna-dev.igk.intel.com (HELO localhost) ([10.91.214.40]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2026 10:59:20 -0800 From: Lukasz Laguna To: igt-dev@lists.freedesktop.org Cc: zbigniew.kempczynski@intel.com, lukasz.laguna@intel.com Subject: [PATCH i-g-t] lib/igt_device_scan: Fix attributes fetching Date: Mon, 23 Feb 2026 19:59:06 +0100 Message-Id: <20260223185906.16168-2-lukasz.laguna@intel.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20260223185906.16168-1-lukasz.laguna@intel.com> References: <20260223185906.16168-1-lukasz.laguna@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" Don't skip NULL attribute values too early, as some symlinks are not resolved by udev and are handled later in igt_device_add_attr(). Signed-off-by: Lukasz Laguna --- lib/igt_device_scan.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c index fc01fc375b..7c7995224b 100644 --- a/lib/igt_device_scan.c +++ b/lib/igt_device_scan.c @@ -593,8 +593,6 @@ static void get_attrs_limited(struct udev_device *dev, struct igt_device *idev) for (int i = 0; i < ARRAY_SIZE(attrs); i++) { value = udev_device_get_sysattr_value(dev, attrs[i]); - if (!value) - continue; igt_device_add_attr(idev, attrs[i], value); DBG("attr: %s, val: %s\n", attrs[i], value); } -- 2.40.0