From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 08/17] lib/kms: Prefer "crtc" over "pipe" in function names
Date: Fri, 27 Feb 2026 10:06:44 +0200 [thread overview]
Message-ID: <20260227080653.30389-9-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260227080653.30389-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Rename a bunch of functions that operate on igt_crtc_t from
the old "pipe" terminology to the new "crtc" terminology.
#include "scripts/iterators.cocci"
@func@
typedef igt_crtc_t;
identifier OLD_FUNC =~ "pipe";
identifier CRTC;
type T;
@@
T OLD_FUNC(..., igt_crtc_t *CRTC, ...);
@script:python rename@
OLD_FUNC << func.OLD_FUNC;
NEW_FUNC;
@@
coccinelle.NEW_FUNC = OLD_FUNC.replace("pipe", "crtc")
@@
identifier func.OLD_FUNC;
identifier rename.NEW_FUNC;
@@
- OLD_FUNC
+ NEW_FUNC
(...) { ... }
@@
identifier func.OLD_FUNC;
identifier rename.NEW_FUNC;
type T;
@@
T
- OLD_FUNC
+ NEW_FUNC
(...);
@@
identifier func.OLD_FUNC;
identifier rename.NEW_FUNC;
@@
- OLD_FUNC
+ NEW_FUNC
(...)
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
lib/igt_kms.c | 4 ++--
lib/igt_kms.h | 2 +-
tests/intel/kms_dsc.c | 2 +-
tests/kms_dither.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 85dcff02efbc..60f16efa9562 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -6598,7 +6598,7 @@ unsigned int igt_get_output_max_bpc(igt_output_t *output)
*
* Returns: The current bpc from the crtc debugfs.
*/
-unsigned int igt_get_pipe_current_bpc(igt_crtc_t *crtc)
+unsigned int igt_get_crtc_current_bpc(igt_crtc_t *crtc)
{
igt_display_t *display = crtc->display;
int drmfd = display->drm_fd;
@@ -6633,7 +6633,7 @@ static unsigned int get_current_bpc(igt_crtc_t *crtc, igt_output_t *output,
unsigned int bpc)
{
unsigned int maximum = igt_get_output_max_bpc(output);
- unsigned int current = igt_get_pipe_current_bpc(crtc);
+ unsigned int current = igt_get_crtc_current_bpc(crtc);
igt_require_f(maximum >= bpc,
"Monitor doesn't support %u bpc, max is %u\n", bpc,
diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 24fe6db70128..b38f62f354fc 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -1234,7 +1234,7 @@ bool igt_fit_modes_in_bw(igt_display_t *display);
bool igt_has_lobf_debugfs(int drmfd, igt_output_t *output);
bool igt_get_i915_edp_lobf_status(int drmfd, char *connector_name);
unsigned int igt_get_output_max_bpc(igt_output_t *output);
-unsigned int igt_get_pipe_current_bpc(igt_crtc_t *crtc);
+unsigned int igt_get_crtc_current_bpc(igt_crtc_t *crtc);
void igt_assert_output_bpc_equal(igt_crtc_t *crtc, igt_output_t *output,
unsigned int bpc);
bool igt_check_output_bpc_equal(igt_crtc_t *crtc, igt_output_t *output,
diff --git a/tests/intel/kms_dsc.c b/tests/intel/kms_dsc.c
index 74bc4af53ceb..69f335da34ec 100644
--- a/tests/intel/kms_dsc.c
+++ b/tests/intel/kms_dsc.c
@@ -226,7 +226,7 @@ static void update_display(data_t *data, uint32_t test_type)
restore_force_dsc_fractional_bpp_en();
if (test_type & TEST_DSC_BPC) {
- current_bpc = igt_get_pipe_current_bpc(data->crtc);
+ current_bpc = igt_get_crtc_current_bpc(data->crtc);
igt_skip_on_f(data->input_bpc != current_bpc,
"Input bpc = %d is not equal to current bpc = %d\n",
data->input_bpc, current_bpc);
diff --git a/tests/kms_dither.c b/tests/kms_dither.c
index ca3b76b62459..ca367db613d4 100644
--- a/tests/kms_dither.c
+++ b/tests/kms_dither.c
@@ -103,7 +103,7 @@ static dither_status_t get_dither_state(data_t *data, igt_crtc_t *crtc)
igt_assert_eq(sscanf(start_loc, ", dither=%s", tmp), 1);
status.dither = !strcmp(tmp, "yes,");
- status.bpc = igt_get_pipe_current_bpc(crtc);
+ status.bpc = igt_get_crtc_current_bpc(crtc);
return status;
}
--
2.52.0
next prev parent reply other threads:[~2026-02-27 8:07 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 8:06 [PATCH i-g-t 00/17] lib/kms: Finish the igt_crtc_t API refactoring Ville Syrjala
2026-02-27 8:06 ` [PATCH i-g-t 01/17] lib/kms: Replace igt_pipe_has_valid_output() with igt_crtc_has_valid_output() Ville Syrjala
2026-02-27 10:42 ` Jani Nikula
2026-02-27 8:06 ` [PATCH i-g-t 02/17] lib/kms: Replace igt_display_require_output_on_pipe() with igt_display_require_output_on_crtc() Ville Syrjala
2026-02-27 10:50 ` Jani Nikula
2026-02-27 8:06 ` [PATCH i-g-t 03/17] lib/kms: Replace igt_get_single_output_for_pipe() with igt_get_single_output_for_crtc() Ville Syrjala
2026-02-27 10:22 ` Jani Nikula
2026-02-27 8:06 ` [PATCH i-g-t 04/17] lib/kms: Make the igt_*_bpc_*() interfaces more abstract Ville Syrjala
2026-02-27 8:06 ` [PATCH i-g-t 05/17] tests/kms: Use igt_crtc_name() Ville Syrjala
2026-02-27 8:06 ` [PATCH i-g-t 06/17] tests/kms: Clean up crtc->pipe comparions Ville Syrjala
2026-02-27 10:51 ` Jani Nikula
2026-02-27 8:06 ` [PATCH i-g-t 07/17] tests/vmwgfx/vmw_prime: Replace igt_pipe_crc_new() with igt_crtc_crc_new() Ville Syrjala
2026-02-27 8:06 ` Ville Syrjala [this message]
2026-02-27 8:06 ` [PATCH i-g-t 09/17] tests/kms_color*: Prefer "crtc" over "pipe" in function names Ville Syrjala
2026-02-27 8:06 ` [PATCH i-g-t 10/17] tests/kms: " Ville Syrjala
2026-02-27 8:06 ` [PATCH i-g-t 11/17] tests/kms_tiled_display: Remove mention of PIPE_NONE Ville Syrjala
2026-02-27 8:06 ` [PATCH i-g-t 12/17] tests/kms: Remove hand rolled get_vblank() stuff Ville Syrjala
2026-02-27 8:06 ` [PATCH i-g-t 13/17] lib/kms: Fix kmstest_get_vblank() docs Ville Syrjala
2026-02-27 8:06 ` [PATCH i-g-t 14/17] tests/kms: Pass crtc_index to kmstest_get_vbl_flag() Ville Syrjala
2026-02-27 8:06 ` [PATCH i-g-t 15/17] tests/kms: Pass crtc_index to kmstest_get_vblank() Ville Syrjala
2026-02-27 8:06 ` [PATCH i-g-t 16/17] lib/kms: Introduce igt_crtc_get_vbl_flag() Ville Syrjala
2026-02-27 8:06 ` [PATCH i-g-t 17/17] lib/kms: Introduce igt_crtc_get_vblank() Ville Syrjala
2026-02-27 10:55 ` [PATCH i-g-t 00/17] lib/kms: Finish the igt_crtc_t API refactoring Jani Nikula
2026-02-27 14:14 ` ✗ i915.CI.BAT: failure for " Patchwork
2026-02-27 14:24 ` ✓ Xe.CI.BAT: success " Patchwork
2026-02-27 23:28 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-04 5:58 ` ✓ Xe.CI.BAT: success for lib/kms: Finish the igt_crtc_t API refactoring (rev2) Patchwork
2026-03-04 6:19 ` ✓ i915.CI.BAT: " Patchwork
2026-03-05 5:01 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-05 8:15 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260227080653.30389-9-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox