Re: [PATCH v2] tests/intel/kms_fbcon_fbt: Drop igt_device_set_master call

Kamil Konieczny
2026-03-02T09:18:17Z

Hi Jonathan,
On 2026-02-27 at 19:07:20 +0000, Jonathan Cavitt wrote:
> In kms_fbcon_fbt, igt_set_device_master is already called on the target
> fd by drm_open_driver_master, so doing so again in the subtest function
> is unnecessary.
>
> v2: Do not modify kms_pm_rpm (Kamil)
>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> ---
> tests/intel/kms_fbcon_fbt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tests/intel/kms_fbcon_fbt.c b/tests/intel/kms_fbcon_fbt.c
> index 36de84f985..e44be15f60 100644
> --- a/tests/intel/kms_fbcon_fbt.c
> +++ b/tests/intel/kms_fbcon_fbt.c
> @@ -371,7 +371,6 @@ static void restore_fbcon(struct drm_info *drm)
>
> static void subtest(struct drm_info *drm, struct feature *feature, bool suspend)
> {
> - igt_device_set_master(drm->fd);

LGTM
Reviewed-by: Kamil Konieczny <kamil.konieczny@linux.intel.com>

Regards,
Kamil

> kmstest_set_vt_graphics_mode();
>
> igt_require(feature->supported_on_chipset(drm->fd, drm->debugfs_fd));
> --
> 2.43.0
>