From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36274EC047D for ; Tue, 3 Mar 2026 09:39:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A88C610E750; Tue, 3 Mar 2026 09:39:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="QydY9RST"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id CE92A10E753 for ; Tue, 3 Mar 2026 09:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1772530755; x=1804066755; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=7Jcr3KS6vKv980XA+Qde4HVaHirZNFF+79WTDrKm0tM=; b=QydY9RSTXvj4HSzzh2O0zSnkJiX7UYE9tHFY+WJEyKBsOqHncRcWK0V0 7+fm5N1TNtJuJgFpFERQ9hIpAgIqpE3scy7py58mWXHnjWRkWQCUwnsAL tOuLhl9QrkvxBnmaFb+TBr1/dw2WzRszajvD//jyEdNrzCs0QyU4yAhf/ XqbJXnynvKyQjlBV8yXvCmjTgSkJHdOl32a29rHj0r4iuonOTIQZNTkmw fRbo1wwsmYcw/2kVknt23UfHck9VY/9myYM/SvpY4399ty0M0f2NtQ/u1 qJNcwar9NPhelGlBzrtIKGApWAhz4gMEIsoVgNbbz2VQ0JgK/r1urSdJ3 g==; X-CSE-ConnectionGUID: ZQicTN+wSEaZJTVvStCe+w== X-CSE-MsgGUID: s4TJ2FIhS6KMHjDYZJsRLg== X-IronPort-AV: E=McAfee;i="6800,10657,11717"; a="76160012" X-IronPort-AV: E=Sophos;i="6.21,321,1763452800"; d="scan'208";a="76160012" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2026 01:39:15 -0800 X-CSE-ConnectionGUID: MWLlMhJtRumzJqauzvF/CQ== X-CSE-MsgGUID: 5npliEMdQISekpGZsvkesg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,321,1763452800"; d="scan'208";a="222097839" Received: from jeevan-x299-aorus-gaming-3-pro.iind.intel.com ([10.227.90.91]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Mar 2026 01:39:13 -0800 From: Jeevan B To: igt-dev@lists.freedesktop.org Cc: dibin.moolakadan.subrahmanian@intel.com, mohammed.thasleem@intel.com, Jeevan B Subject: [PATCH i-g-t 1/4] tests/intel/kms_pm_dc: Replace require with proper assertion Date: Tue, 3 Mar 2026 15:09:25 +0530 Message-ID: <20260303093928.569925-2-jeevan.b@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260303093928.569925-1-jeevan.b@intel.com> References: <20260303093928.569925-1-jeevan.b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" The DC3CO video playback simulation test was incorrectly using require at the end to check if DC3CO state was entered. This causes the test to be marked as SKIP instead of FAIL when DC3CO doesn't work properly, hiding real issues. So changing the call from require to assert. Fixes: b89efa8048e58 ("tests/i915/i915_pm_dc: Check dc3co count to skip the test") Signed-off-by: Jeevan B --- tests/intel/kms_pm_dc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c index 39e94f36b..507b6168d 100644 --- a/tests/intel/kms_pm_dc.c +++ b/tests/intel/kms_pm_dc.c @@ -312,8 +312,7 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data) usleep(delay); } - igt_require_f(igt_dc_state_wait_entry(data->debugfs_fd, IGT_INTEL_CHECK_DC3CO, - dc3co_prev_cnt), "dc3co-vpb-simulation not enabled\n"); + check_dc_counter(data, IGT_INTEL_CHECK_DC3CO, dc3co_prev_cnt); } static void setup_dc3co(data_t *data) -- 2.43.0