Re: [PATCH i-g-t v2 2/2] tests/intel/kms_sharpness_filter: Detect and bypass joiner modes

Reddy Guddati, Santhosh
2026-03-09T08:52:09Z

On 04-03-2026 13:47, Pranay Samala wrote:
> When the output configured to a joiner mode (Big Joiner or Ultra Joiner),
> switch to a non-joiner mode before running the sharpness filter test,
> since CASF is not supported on joiner configurations.
> This ensures the sharpness filter test runs on a single pipe configuration
> and avoid false failures.
>
> v2:
> - Add FIXME (Santhosh)
> - Rebase
>
> Signed-off-by: Pranay Samala <pranay.samala@intel.com>
> ---
> tests/intel/kms_sharpness_filter.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/tests/intel/kms_sharpness_filter.c b/tests/intel/kms_sharpness_filter.c
> index ba325b377..f71038a9a 100644
> --- a/tests/intel/kms_sharpness_filter.c
> +++ b/tests/intel/kms_sharpness_filter.c
> @@ -440,6 +440,22 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
> data->crtc = crtc;
> data->mode = igt_output_get_mode(data->output);
>
> + /*
> + * FIXME: Joiner + CASF currently unsupported.
> + * Remove this check once support is implemented.
> + * Until then, run on non-joiner mode in joiner conf.
> + */
> + >> nit: Please Remove the line, /%s/conf/configuration.
LGTM
Reviewed-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
> + if (is_joiner_mode(data->drm_fd, data->output)) {
> + data->mode = igt_get_non_joiner_mode(data->drm_fd, data->output);
> + igt_info("Executing on mode %dx%d@%d\n",
> + data->mode->hdisplay,
> + data->mode->vdisplay,
> + data->mode->vrefresh);
> + } else {
> + data->mode = igt_output_get_mode(data->output);
> + }
> +
> if (!has_sharpness_filter(data->crtc)) {
> igt_info("%s: Doesn't support IGT_CRTC_SHARPNESS_STRENGTH.\n",
> igt_crtc_name(data->crtc));