From: Ville Syrjala <ville.syrjala@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [PATCH i-g-t 5/5] lib/kms: Make igt_first_crtc_with_single_output() skip if no CRTC/output can be found
Date: Thu, 5 Mar 2026 15:40:38 +0200 [thread overview]
Message-ID: <20260305134038.6995-6-ville.syrjala@linux.intel.com> (raw)
In-Reply-To: <20260305134038.6995-1-ville.syrjala@linux.intel.com>
From: Ville Syrjälä <ville.syrjala@linux.intel.com>
Have igt_first_crtc_with_single_output() skip if a suitable CRTC/output
combination can't be found. All callers currently skip based on the
return value.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
lib/igt_kms.c | 2 ++
tests/intel/gem_exec_reloc.c | 1 -
tests/kms_plane.c | 1 -
tests/kms_plane_scaling.c | 1 -
4 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index a9673a9a6565..c302021be9b1 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -8019,6 +8019,8 @@ igt_crtc_t *igt_first_crtc_with_single_output(igt_display_t *display, igt_output
return crtc;
}
+ igt_skip("No valid CRTC/output combinations\n");
+
*ret_output = NULL;
return NULL;
diff --git a/tests/intel/gem_exec_reloc.c b/tests/intel/gem_exec_reloc.c
index ed4e77ec93d3..e480337a0bd8 100644
--- a/tests/intel/gem_exec_reloc.c
+++ b/tests/intel/gem_exec_reloc.c
@@ -1517,7 +1517,6 @@ static void scanout(int i915,
igt_display_reset(dpy);
crtc = igt_first_crtc_with_single_output(dpy, &output);
- igt_require(crtc);
igt_output_set_crtc(output, crtc);
diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 6a78c9ff0941..98705a897205 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -1364,7 +1364,6 @@ static void test_planar_settings(data_t *data)
}
crtc = igt_first_crtc_with_single_output(display, &output);
- igt_require(crtc);
igt_output_set_crtc(output, crtc);
primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index ab619fb2b532..8d34619b328f 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -1181,7 +1181,6 @@ static void invalid_parameter_tests(data_t *d)
igt_fixture() {
crtc = igt_first_crtc_with_single_output(display, &output);
- igt_require(crtc);
igt_output_set_crtc(output, crtc);
plane = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
--
2.52.0
next prev parent reply other threads:[~2026-03-05 13:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 13:40 [PATCH i-g-t 0/5] kms: A bit more cleanup around igt_kms Ville Syrjala
2026-03-05 13:40 ` [PATCH i-g-t 1/5] tests/nouveau_crc: Extract {setup,cleanup}_test() Ville Syrjala
2026-03-06 11:00 ` Jani Nikula
2026-03-06 20:57 ` Lyude Paul
2026-03-05 13:40 ` [PATCH i-g-t 2/5] tests/nouveau_crc: Convert to dynamic subtests Ville Syrjala
2026-03-06 11:13 ` Jani Nikula
2026-03-06 11:38 ` Ville Syrjälä
2026-03-05 13:40 ` [PATCH i-g-t 3/5] tests/nouveau_crc: Use igt_first_crtc() instead of igt_crtc_for_pipe() Ville Syrjala
2026-03-06 11:14 ` Jani Nikula
2026-03-06 20:57 ` Lyude Paul
2026-03-05 13:40 ` [PATCH i-g-t 4/5] lib/kms: Make igt_first_crtc() skip if no CRTCs are around Ville Syrjala
2026-03-06 11:17 ` Jani Nikula
2026-03-05 13:40 ` Ville Syrjala [this message]
2026-03-06 11:19 ` [PATCH i-g-t 5/5] lib/kms: Make igt_first_crtc_with_single_output() skip if no CRTC/output can be found Jani Nikula
2026-03-05 23:16 ` ✗ Xe.CI.BAT: failure for kms: A bit more cleanup around igt_kms Patchwork
2026-03-05 23:20 ` ✓ i915.CI.BAT: success " Patchwork
2026-03-06 16:32 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-07 3:53 ` ✓ i915.CI.Full: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260305134038.6995-6-ville.syrjala@linux.intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox