From: Jani Nikula <jani.nikula@intel.com>
To: Jani Nikula <jani.nikula@intel.com>, igt-dev@lists.freedesktop.org
Cc: ville.syrjala@linux.intel.com
Subject: [PATCH i-g-t v2] tests/kms_vblank: use CRTC indexes instead of pipes for CRTC tracking
Date: Mon, 9 Mar 2026 18:48:25 +0200 [thread overview]
Message-ID: <20260309164825.720712-1-jani.nikula@intel.com> (raw)
In-Reply-To: <e5066cc6d24aad560a51f9de37e5d26a46e4dd47.1773066012.git.jani.nikula@intel.com>
The test tracks "active" CRTCs in a dedicated array. This does not
depend on pipes in any way. Switch to using CRTC indexes instead.
v2: Switch active_crtcs[] type from enum pipe to int
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
tests/kms_vblank.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
index e79b2535c599..7fb7de0a70c1 100644
--- a/tests/kms_vblank.c
+++ b/tests/kms_vblank.c
@@ -110,8 +110,8 @@ typedef struct {
} data_t;
static bool all_pipes;
-static enum pipe active_pipes[IGT_MAX_PIPES];
-static uint32_t last_pipe;
+static int active_crtcs[IGT_MAX_PIPES];
+static uint32_t last_crtc_index;
static double elapsed(const struct timespec *start,
const struct timespec *end,
@@ -522,8 +522,8 @@ static void run_subtests(data_t *data)
if (!crtc_output_combo_valid(&data->display, crtc, data->output))
continue;
- if (!all_pipes && crtc->pipe != active_pipes[0] &&
- crtc->pipe != active_pipes[last_pipe]) {
+ if (!all_pipes && crtc->crtc_index != active_crtcs[0] &&
+ crtc->crtc_index != active_crtcs[last_crtc_index]) {
igt_info("Skipping pipe %s\n",
igt_crtc_name(crtc));
continue;
@@ -554,8 +554,8 @@ static void run_subtests(data_t *data)
if (!crtc_output_combo_valid(&data->display, crtc, data->output))
continue;
- if (!all_pipes && crtc->pipe != active_pipes[0] &&
- crtc->pipe != active_pipes[last_pipe]) {
+ if (!all_pipes && crtc->crtc_index != active_crtcs[0] &&
+ crtc->crtc_index != active_crtcs[last_crtc_index]) {
igt_info("Skipping pipe %s\n",
igt_crtc_name(crtc));
continue;
@@ -650,9 +650,9 @@ int igt_main_args("e", NULL, help_str, opt_handler, NULL)
/* Get active pipes. */
for_each_crtc(&data.display, crtc) {
data.crtc = crtc;
- active_pipes[last_pipe++] = crtc->pipe;
+ active_crtcs[last_crtc_index++] = crtc->crtc_index;
}
- last_pipe--;
+ last_crtc_index--;
}
igt_describe("Negative test for vblank request.");
@@ -679,8 +679,8 @@ int igt_main_args("e", NULL, help_str, opt_handler, NULL)
if (!crtc_output_combo_valid(&data.display, crtc, data.output))
continue;
- if (!all_pipes && crtc->pipe != active_pipes[0] &&
- crtc->pipe != active_pipes[last_pipe]) {
+ if (!all_pipes && crtc->crtc_index != active_crtcs[0] &&
+ crtc->crtc_index != active_crtcs[last_crtc_index]) {
igt_info("Skipping pipe %s\n",
igt_crtc_name(crtc));
continue;
--
2.47.3
next prev parent reply other threads:[~2026-03-09 16:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 14:21 [PATCH i-g-t 00/10] tests: avoid using crtc->pipe where possible Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 01/10] tests/kms_writeback: use igt_crtc_name() Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 02/10] tests/kms_colorop: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 03/10] tests/kms_color_pipeline: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 04/10] tests/kms_cursor_crc: use CRTC indexes instead of pipes for CRTC tracking Jani Nikula
2026-03-10 10:05 ` Ville Syrjälä
2026-03-10 10:52 ` Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 05/10] tests/kms_cursor_edge_walk: " Jani Nikula
2026-03-09 14:25 ` Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 06/10] tests/kms_pipe_crc_basic: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 07/10] tests/kms_plane_alpha_blend: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 08/10] tests/kms_vblank: " Jani Nikula
2026-03-09 14:25 ` Jani Nikula
2026-03-09 16:48 ` Jani Nikula [this message]
2026-03-09 14:21 ` [PATCH i-g-t 09/10] tests/kms_cursor_legacy: " Jani Nikula
2026-03-09 14:21 ` [PATCH i-g-t 10/10] tests/kms_debugfs: use CRTC indexes instead of pipes for fb tracking Jani Nikula
2026-03-10 10:08 ` Ville Syrjälä
2026-03-09 23:58 ` ✓ i915.CI.BAT: success for tests: avoid using crtc->pipe where possible (rev2) Patchwork
2026-03-10 0:04 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-10 5:31 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-10 9:03 ` ✗ i915.CI.Full: " Patchwork
2026-03-10 10:20 ` [PATCH i-g-t 00/10] tests: avoid using crtc->pipe where possible Ville Syrjälä
2026-03-10 11:24 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260309164825.720712-1-jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox