Re: [PATCH i-g-t 00/10] tests: avoid using crtc->pipe where possible

Ville Syrjälä
2026-03-10T10:20:24Z

On Mon, Mar 09, 2026 at 04:21:34PM +0200, Jani Nikula wrote:
> Tests should generally avoid using crtc->pipe if possible. It's an Intel
> implementation detail, and crtc->crtc_index is the generic thing to
> use. Do some conversions to crtc_index use.
>
>
> Jani Nikula (10):
> tests/kms_writeback: use igt_crtc_name()
> tests/kms_colorop: use igt_crtc_name()
> tests/kms_color_pipeline: use igt_crtc_name()
> tests/kms_cursor_crc: use CRTC indexes instead of pipes for CRTC
> tracking
> tests/kms_cursor_edge_walk: use CRTC indexes instead of pipes for CRTC
> tracking
> tests/kms_pipe_crc_basic: use CRTC indexes instead of pipes for CRTC
> tracking
> tests/kms_plane_alpha_blend: use CRTC indexes instead of pipes for
> CRTC tracking
> tests/kms_vblank: use CRTC indexes instead of pipes for CRTC tracking
> tests/kms_cursor_legacy: use CRTC indexes instead of pipes for CRTC
> tracking
> tests/kms_debugfs: use CRTC indexes instead of pipes for fb tracking

I'd just nuke the array from kms_debugfs.

But no big deal either way. Series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>
> tests/kms_color_pipeline.c | 2 +-
> tests/kms_colorop.c | 4 ++--
> tests/kms_cursor_crc.c | 16 ++++++++--------
> tests/kms_cursor_edge_walk.c | 14 +++++++-------
> tests/kms_cursor_legacy.c | 2 +-
> tests/kms_debugfs.c | 4 ++--
> tests/kms_pipe_crc_basic.c | 14 +++++++-------
> tests/kms_plane_alpha_blend.c | 14 +++++++-------
> tests/kms_vblank.c | 20 ++++++++++----------
> tests/kms_writeback.c | 4 ++--
> 10 files changed, 47 insertions(+), 47 deletions(-)
>
> --
> 2.47.3

--
Ville Syrjälä
Intel