Re: [PATCH i-g-t 00/10] tests: avoid using crtc->pipe where possible

Jani Nikula
2026-03-10T11:25:05Z

On Tue, 10 Mar 2026, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Mon, Mar 09, 2026 at 04:21:34PM +0200, Jani Nikula wrote:
>> Tests should generally avoid using crtc->pipe if possible. It's an Intel
>> implementation detail, and crtc->crtc_index is the generic thing to
>> use. Do some conversions to crtc_index use.
>>
>>
>> Jani Nikula (10):
>> tests/kms_writeback: use igt_crtc_name()
>> tests/kms_colorop: use igt_crtc_name()
>> tests/kms_color_pipeline: use igt_crtc_name()
>> tests/kms_cursor_crc: use CRTC indexes instead of pipes for CRTC
>> tracking
>> tests/kms_cursor_edge_walk: use CRTC indexes instead of pipes for CRTC
>> tracking
>> tests/kms_pipe_crc_basic: use CRTC indexes instead of pipes for CRTC
>> tracking
>> tests/kms_plane_alpha_blend: use CRTC indexes instead of pipes for
>> CRTC tracking
>> tests/kms_vblank: use CRTC indexes instead of pipes for CRTC tracking
>> tests/kms_cursor_legacy: use CRTC indexes instead of pipes for CRTC
>> tracking
>> tests/kms_debugfs: use CRTC indexes instead of pipes for fb tracking
>
> I'd just nuke the array from kms_debugfs.
>
> But no big deal either way. Series is

I opted to leave that refactor for another patch.

> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks, pushed the lot.

BR,
Jani.

--
Jani Nikula, Intel