public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Michał Grzelak" <michal.grzelak@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH i-g-t 2/2] tests/device_reset: unload audio on xe as well
Date: Sun, 15 Mar 2026 01:38:26 +0100	[thread overview]
Message-ID: <20260315003826.3785048-2-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260315003826.3785048-1-michal.grzelak@intel.com>

There has been observed errors caused by audio not being unloaded before
xe is unbound:

<3> [339.178598] xe 0000:00:02.0: [drm] *ERROR* audio power refcount 1 after unbind

This is due audio is being unloaded only when i915 has been loaded.
Change this behavior to unload audio with any Intel driver.

Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
 tests/device_reset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/device_reset.c b/tests/device_reset.c
index b931dff7a0..b281f4eceb 100644
--- a/tests/device_reset.c
+++ b/tests/device_reset.c
@@ -426,7 +426,7 @@ static void set_device_filter(const char* dev_path)
 
 static void unbind_reset_rebind(struct device_fds *dev, enum reset type)
 {
-	if (is_i915_device(dev->fds.dev)) {
+	if (is_intel_device(dev->fds.dev)) {
 		igt_audio_driver_unload(&dev->snd_driver);
 	}
 
-- 
2.45.2


  reply	other threads:[~2026-03-15  0:38 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-15  0:38 [PATCH i-g-t 1/2] tests/device_reset: unload audio before descriptor closure Michał Grzelak
2026-03-15  0:38 ` Michał Grzelak [this message]
2026-03-23 14:02   ` [PATCH i-g-t 2/2] tests/device_reset: unload audio on xe as well Saarinen, Jani
2026-03-23 14:06     ` Vehmanen, Kai
2026-03-24 15:10       ` Michał Grzelak
2026-03-15  1:32 ` ✓ Xe.CI.BAT: success for series starting with [i-g-t,1/2] tests/device_reset: unload audio before descriptor closure Patchwork
2026-03-15  1:35 ` ✓ i915.CI.BAT: " Patchwork
2026-03-15  6:10 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-15 10:27 ` ✗ i915.CI.Full: " Patchwork
2026-03-23 14:02 ` [PATCH i-g-t 1/2] " Saarinen, Jani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260315003826.3785048-2-michal.grzelak@intel.com \
    --to=michal.grzelak@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox