public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Mohammed Bilal <mohammed.bilal@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: kunal1.joshi@intel.com, Mohammed Bilal <mohammed.bilal@intel.com>
Subject: [PATCH i-g-t v2] lib/igt_kms: Fix invalid mode timing in igt_kms_get_full_edid()
Date: Mon, 16 Mar 2026 13:50:53 +0530	[thread overview]
Message-ID: <20260316082053.3333398-1-mohammed.bilal@intel.com> (raw)

The mode timing values for 2288x1287 were invalid,
causing an incorrect refresh rate to be calculated.

Fixed by using proper timing values with correct blanking periods.

v2:
-Update value based on cvt

Signed-off-by: Mohammed Bilal <mohammed.bilal@intel.com>
---
 lib/igt_kms.c | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 0b05ddd72..da7297669 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -162,16 +162,17 @@ const struct edid *igt_kms_get_full_edid(void)
 	static struct edid edid;
 	drmModeModeInfo mode = {};
 
-	mode.clock = 148500;
+	/* 2288x1287 @ 60Hz with proper timing values */
+	mode.clock = 194250;
 	mode.hdisplay = 2288;
-	mode.hsync_start = 2008;
-	mode.hsync_end = 2052;
-	mode.htotal = 2200;
+	mode.hsync_start = 2336;
+	mode.hsync_end = 2368;
+	mode.htotal = 2448;
 	mode.vdisplay = 1287;
-	mode.vsync_start = 1084;
-	mode.vsync_end = 1089;
-	mode.vtotal = 1125;
-	mode.vrefresh = 144;
+	mode.vsync_start = 1290;
+	mode.vsync_end = 1295;
+	mode.vtotal = 1324;
+	mode.vrefresh = 60;
 	edid_init_with_mode(&edid, &mode);
 
 	std_timing_set(&edid.standard_timings[0], 256, 60, STD_TIMING_16_10);
-- 
2.48.1


             reply	other threads:[~2026-03-16  8:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16  8:20 Mohammed Bilal [this message]
2026-03-16  8:37 ` [PATCH i-g-t v2] lib/igt_kms: Fix invalid mode timing in igt_kms_get_full_edid() Joshi, Kunal1
2026-03-17  1:44 ` ✓ Xe.CI.BAT: success for lib/igt_kms: Fix invalid mode timing in igt_kms_get_full_edid() (rev2) Patchwork
2026-03-17 10:23 ` ✓ i915.CI.BAT: " Patchwork
2026-03-18  3:48 ` ✗ i915.CI.Full: failure " Patchwork
2026-03-18  5:05 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260316082053.3333398-1-mohammed.bilal@intel.com \
    --to=mohammed.bilal@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kunal1.joshi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox