public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: jouni.hogander@intel.com, Jeevan B <jeevan.b@intel.com>
Subject: [PATCH i-g-t] tests/intel/kms_dirtyfb: Pass output to PSR helpers
Date: Wed, 18 Mar 2026 08:42:05 +0530	[thread overview]
Message-ID: <20260318031205.70655-1-jeevan.b@intel.com> (raw)

Replace NULL with data->output in PSR function calls and update the
log to include the output name when PSR is not supported.

This change ensures correct behavior in dual eDP setups where PSR
support may differ between displays. Passing the specific output
instead of NULL allows PSR checks to be performed per connector,
ensuring each display is evaluated independently and accurately.

v2: Replace NULL with data->output in all PSR helpers.
v3: Update commit message.

Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
 tests/intel/kms_dirtyfb.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
index b85e09346..b5de63350 100644
--- a/tests/intel/kms_dirtyfb.c
+++ b/tests/intel/kms_dirtyfb.c
@@ -120,8 +120,8 @@ static bool check_support(data_t *data)
 			return false;
 		}
 		if (!psr_sink_support(data->drm_fd, data->debugfs_fd,
-				      PSR_MODE_1, NULL)) {
-			igt_info("Output doesn't support PSR\n");
+				      PSR_MODE_1, data->output)) {
+			igt_info("Output %s doesn't support PSR\n", igt_output_name(data->output));
 			return false;
 		}
 		return true;
@@ -150,7 +150,7 @@ static void enable_feature(data_t *data)
 		intel_fbc_enable(&data->display);
 		break;
 	case FEATURE_PSR:
-		psr_enable(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL);
+		psr_enable(data->drm_fd, data->debugfs_fd, PSR_MODE_1, data->output);
 		break;
 	case FEATURE_DRRS:
 		intel_drrs_enable(data->crtc);
@@ -173,7 +173,7 @@ static void check_feature_enabled(data_t *data)
 		break;
 	case FEATURE_PSR:
 		igt_require(!psr_disabled_check(data->debugfs_fd));
-		igt_assert_f(psr_wait_entry(data->debugfs_fd, PSR_MODE_1, NULL),
+		igt_assert_f(psr_wait_entry(data->debugfs_fd, PSR_MODE_1, data->output),
 			     "PSR still disabled\n");
 		break;
 	case FEATURE_DRRS:
@@ -217,8 +217,8 @@ static void disable_features(data_t *data)
 {
 	intel_fbc_disable(&data->display);
 
-	if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL))
-		psr_disable(data->drm_fd, data->debugfs_fd, NULL);
+	if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, data->output))
+		psr_disable(data->drm_fd, data->debugfs_fd, data->output);
 
 	intel_drrs_disable(data->crtc);
 }
-- 
2.43.0


             reply	other threads:[~2026-03-18  3:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18  3:12 Jeevan B [this message]
2026-03-18  5:17 ` [PATCH i-g-t] tests/intel/kms_dirtyfb: Pass output to PSR helpers Samala, Pranay
2026-03-18  6:16   ` B, Jeevan
2026-03-18  5:18 ` ✓ Xe.CI.BAT: success for tests/intel/kms_dirtyfb: Pass output to PSR helpers (rev2) Patchwork
2026-03-18  5:58 ` ✓ i915.CI.BAT: " Patchwork
2026-03-18 14:09 ` [PATCH i-g-t] tests/intel/kms_dirtyfb: Pass output to PSR helpers Hogander, Jouni
2026-03-19 11:08 ` ✗ i915.CI.Full: failure for tests/intel/kms_dirtyfb: Pass output to PSR helpers (rev2) Patchwork
2026-03-19 18:30 ` ✓ Xe.CI.FULL: success " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-03-17  8:36 [PATCH i-g-t] tests/intel/kms_dirtyfb: Pass output to PSR helpers Jeevan B
2026-03-17 11:29 ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260318031205.70655-1-jeevan.b@intel.com \
    --to=jeevan.b@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox