public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: [PATCH i-g-t 2/2] lib/kms: fix igt_crtc_connector_valid() validity check
Date: Fri, 20 Mar 2026 13:31:43 +0200	[thread overview]
Message-ID: <20260320113143.2882422-2-jani.nikula@intel.com> (raw)
In-Reply-To: <20260320113143.2882422-1-jani.nikula@intel.com>

output->config.valid_crtc_index_mask is a bit mask of CRTC indexes, not
pipes. Check the validity using crtc->crtc_index instead of crtc->pipe.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 lib/igt_kms.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/igt_kms.h b/lib/igt_kms.h
index 71ed4604e7e0..318ff8ba9732 100644
--- a/lib/igt_kms.h
+++ b/lib/igt_kms.h
@@ -687,7 +687,7 @@ static inline bool igt_output_is_connected(igt_output_t *output)
 static inline bool igt_crtc_connector_valid(igt_crtc_t *crtc, igt_output_t *output)
 {
 	return igt_output_is_connected(output) &&
-		output->config.valid_crtc_index_mask & (1 << crtc->pipe);
+		output->config.valid_crtc_index_mask & (1 << crtc->crtc_index);
 }
 
 #define for_each_if(condition) if (!(condition)) {} else
-- 
2.47.3


  reply	other threads:[~2026-03-20 11:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-20 11:31 [PATCH i-g-t 1/2] tests/intel/kms_pipe_stress: use CRTC index not pipe for vblank ioctl Jani Nikula
2026-03-20 11:31 ` Jani Nikula [this message]
2026-03-20 11:57   ` [PATCH i-g-t 2/2] lib/kms: fix igt_crtc_connector_valid() validity check Ville Syrjälä
2026-03-20 11:57 ` [PATCH i-g-t 1/2] tests/intel/kms_pipe_stress: use CRTC index not pipe for vblank ioctl Ville Syrjälä
2026-03-20 15:26 ` ✓ Xe.CI.BAT: success for series starting with [i-g-t,1/2] " Patchwork
2026-03-20 15:44 ` ✓ i915.CI.BAT: " Patchwork
2026-03-21  7:26 ` ✗ i915.CI.Full: failure " Patchwork
2026-03-21 15:35 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260320113143.2882422-2-jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox