From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0FC71EC01A6 for ; Mon, 23 Mar 2026 09:13:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9CB9D10E3D6; Mon, 23 Mar 2026 09:13:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="GWdvqc/N"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8809110E49E for ; Mon, 23 Mar 2026 09:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774257215; x=1805793215; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HtCVpeRF52I4uM9wWNlOWtluxWQIg3B3sEuSo2NXo9k=; b=GWdvqc/N84140bi5iaTe/lV/Z+onVo8z4ijzVtAa/EpTpXNBZvr8XH4S if9c2eDMVZKHIHDXfyBDUjcu6r9Vg9hUM0vZ8ZmvMraSrMkfDPfG175wL /UY3MbtorinH8MlLzQE+kom3MFtUmDyKbRFuYtCHQT0eMRakJK+siKWDR h9a5+JQ+lTk/4AstsfkFiyAEmEwlbK9TNN/NdWZ3wg6HnMn9OLgtKwkZL bJDQ+rOeq7E0PWptdCOhS+pMoIZjr1eHs5uSYFmsNMu/MEAD9kyll+XqC BmvioCR9ni2yf8UUcSFHnwbfp0zVRnMNEgUCtiyRd+D6OdUQlVMONTnfv g==; X-CSE-ConnectionGUID: md4yLhS5Q6KNprnfI+iTVw== X-CSE-MsgGUID: bfOy0NRZQuSJLEwOI2Lp7Q== X-IronPort-AV: E=McAfee;i="6800,10657,11737"; a="75371573" X-IronPort-AV: E=Sophos;i="6.23,137,1770624000"; d="scan'208";a="75371573" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2026 02:13:35 -0700 X-CSE-ConnectionGUID: fn43fouLQnC8p4ErQadU0w== X-CSE-MsgGUID: pPbvS8NoTdutMCKQLcpxKQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,137,1770624000"; d="scan'208";a="219164519" Received: from jeevan-x299-aorus-gaming-3-pro.iind.intel.com ([10.227.90.91]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Mar 2026 02:13:34 -0700 From: Jeevan B To: igt-dev@lists.freedesktop.org Cc: jouni.hogander@intel.com, Jeevan B Subject: [PATCH i-g-t 1/4] tests/intel/kms_fbc_dirty_rect: Avoid unnecessary PSR disable Date: Mon, 23 Mar 2026 14:42:02 +0530 Message-ID: <20260323091205.100585-2-jeevan.b@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260323091205.100585-1-jeevan.b@intel.com> References: <20260323091205.100585-1-jeevan.b@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" Pass output to psr_sink_support so PSR is disabled only when the sink supports it. Using NULL performs a global check, which is unnecessary and can be incorrect on multi-eDP systems. Signed-off-by: Jeevan B --- tests/intel/kms_fbc_dirty_rect.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/intel/kms_fbc_dirty_rect.c b/tests/intel/kms_fbc_dirty_rect.c index efbd46985..e7634dbab 100644 --- a/tests/intel/kms_fbc_dirty_rect.c +++ b/tests/intel/kms_fbc_dirty_rect.c @@ -414,9 +414,9 @@ static bool prepare_test(data_t *data) igt_require_f(intel_fbc_supported(data->crtc), "FBC not supported by the chipset on pipe\n"); - if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL) || - psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_2, NULL) || - psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL)) { + if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, data->output) || + psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_2, data->output) || + psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, data->output)) { igt_info("PSR is supported by the sink. Disabling PSR to test Dirty FBC functionality.\n"); psr_disable(data->drm_fd, data->debugfs_fd, data->output); } -- 2.43.0