From: Pranay Samala <pranay.samala@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: karthik.b.s@intel.com, sameer.lattannavar@intel.com,
pranay.samala@intel.com
Subject: [PATCH i-g-t v2] tests/intel/kms_sharpness_filter: Fix stale mode pointer in joiner bypass
Date: Wed, 25 Mar 2026 16:53:20 +0530 [thread overview]
Message-ID: <20260325112320.2879230-1-pranay.samala@intel.com> (raw)
Set the output on CRTC before getting mode and override it on output,
so the selected mode is used consistently during validation.
Also handle the joiner bypass case where no non-joiner mode is available.
This avoids failures when CASF is run on joiner-capable outputs and
keeps execution on a valid non-joiner configuration.
v2:
- Get mode after setting output on CRTC (Karthik)
Fixes: 10dccc7fc82f ("tests/intel/kms_sharpness_filter: Detect and bypass joiner modes")
Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/7045
Signed-off-by: Pranay Samala <pranay.samala@intel.com>
---
tests/intel/kms_sharpness_filter.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/tests/intel/kms_sharpness_filter.c b/tests/intel/kms_sharpness_filter.c
index 96fb139ae..c9fc191fd 100644
--- a/tests/intel/kms_sharpness_filter.c
+++ b/tests/intel/kms_sharpness_filter.c
@@ -438,7 +438,8 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
data->output = output;
data->crtc = crtc;
- data->mode = igt_output_get_mode(data->output);
+
+ igt_output_set_crtc(data->output, data->crtc);
/*
* FIXME: Joiner + CASF currently unsupported.
@@ -447,7 +448,13 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
*/
if (is_joiner_mode(data->drm_fd, data->output)) {
data->mode = igt_get_non_joiner_mode(data->drm_fd, data->output);
- igt_info("Executing on mode %dx%d@%d\n",
+ if (!data->mode) {
+ igt_info("No non-joiner mode found on output %s\n",
+ igt_output_name(data->output));
+ continue;
+ }
+
+ igt_info("Executing on non-joiner mode %dx%d@%d\n",
data->mode->hdisplay,
data->mode->vdisplay,
data->mode->vrefresh);
@@ -455,15 +462,14 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
data->mode = igt_output_get_mode(data->output);
}
+ igt_output_override_mode(data->output, data->mode);
+
if (!has_sharpness_filter(data->crtc)) {
igt_info("%s: Doesn't support IGT_CRTC_SHARPNESS_STRENGTH.\n",
igt_crtc_name(data->crtc));
continue;
}
- igt_output_set_crtc(data->output,
- data->crtc);
-
if (!intel_pipe_output_combo_valid(display)) {
igt_output_set_crtc(data->output, NULL);
continue;
--
2.34.1
next reply other threads:[~2026-03-25 11:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 11:23 Pranay Samala [this message]
2026-03-25 16:32 ` ✓ Xe.CI.BAT: success for tests/intel/kms_sharpness_filter: Fix stale mode pointer in joiner bypass (rev2) Patchwork
2026-03-25 16:51 ` ✓ i915.CI.BAT: " Patchwork
2026-03-26 0:36 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-26 2:35 ` ✗ i915.CI.Full: " Patchwork
2026-03-26 3:58 ` [PATCH i-g-t v2] tests/intel/kms_sharpness_filter: Fix stale mode pointer in joiner bypass Karthik B S
2026-03-26 7:55 ` ✓ i915.CI.Full: success for tests/intel/kms_sharpness_filter: Fix stale mode pointer in joiner bypass (rev2) Patchwork
2026-03-26 8:09 ` Patchwork
2026-03-26 8:26 ` Patchwork
2026-03-26 10:32 ` Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325112320.2879230-1-pranay.samala@intel.com \
--to=pranay.samala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=sameer.lattannavar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox