From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: pranay.samala@intel.com, Jeevan B <jeevan.b@intel.com>
Subject: [PATCH i-g-t v2 1/4] tests/intel/kms_fbc_dirty_rect: Use per-output PSR check before disabling
Date: Wed, 25 Mar 2026 22:21:37 +0530 [thread overview]
Message-ID: <20260325165140.115520-2-jeevan.b@intel.com> (raw)
In-Reply-To: <20260325165140.115520-1-jeevan.b@intel.com>
Pass output to psr_sink_support so PSR/PR is disabled only when
the sink supports it. Using NULL performs a global check and can
be incorrect on multi-eDP systems.
v2: Update title, include PR and output name in log, check
psr_disable return value.
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/intel/kms_fbc_dirty_rect.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/tests/intel/kms_fbc_dirty_rect.c b/tests/intel/kms_fbc_dirty_rect.c
index efbd46985..c58ab3465 100644
--- a/tests/intel/kms_fbc_dirty_rect.c
+++ b/tests/intel/kms_fbc_dirty_rect.c
@@ -414,11 +414,15 @@ static bool prepare_test(data_t *data)
igt_require_f(intel_fbc_supported(data->crtc),
"FBC not supported by the chipset on pipe\n");
- if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, NULL) ||
- psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_2, NULL) ||
- psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, NULL)) {
- igt_info("PSR is supported by the sink. Disabling PSR to test Dirty FBC functionality.\n");
- psr_disable(data->drm_fd, data->debugfs_fd, data->output);
+ if (psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_1, data->output) ||
+ psr_sink_support(data->drm_fd, data->debugfs_fd, PSR_MODE_2, data->output) ||
+ psr_sink_support(data->drm_fd, data->debugfs_fd, PR_MODE, data->output)) {
+ igt_info("PSR/PR supported on %s, disabling for dirty FBC test\n",
+ igt_output_name(data->output));
+
+ igt_require_f(psr_disable(data->drm_fd, data->debugfs_fd, data->output),
+ "Failed to disable PSR/PR on %s\n",
+ igt_output_name(data->output));
}
if (data->feature & FEATURE_FBC)
--
2.43.0
next prev parent reply other threads:[~2026-03-25 16:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 16:51 [PATCH i-g-t v2 0/4] Fix PSR handling for multi-eDP systems Jeevan B
2026-03-25 16:51 ` Jeevan B [this message]
2026-03-26 8:40 ` [PATCH i-g-t v2 1/4] tests/intel/kms_fbc_dirty_rect: Use per-output PSR check before disabling Samala, Pranay
2026-03-25 16:51 ` [PATCH i-g-t v2 2/4] tests/kms_vrr: Avoid unnecessary PSR disable Jeevan B
2026-04-01 12:30 ` Naladala, Ramanaidu
2026-03-25 16:51 ` [PATCH i-g-t v2 3/4] tests/intel/kms_psr_stress_test: Select PSR-capable output Jeevan B
2026-03-26 8:44 ` Samala, Pranay
2026-03-25 16:51 ` [PATCH i-g-t v2 4/4] tests/intel/kms_pm_dc: Scope PSR handling to output Jeevan B
2026-03-26 3:45 ` ✓ i915.CI.BAT: success for Fix PSR handling for multi-eDP systems (rev3) Patchwork
2026-03-26 3:48 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-26 16:10 ` ✓ Xe.CI.FULL: " Patchwork
2026-03-26 18:49 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260325165140.115520-2-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=pranay.samala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox