public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Cc: kamil.konieczny@linux.intel.com, adam.miszczak@linux.intel.com,
	jakub1.kolakowski@intel.com, lukasz.laguna@intel.com,
	Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Subject: [PATCH v2 i-g-t 3/4] tests/intel/xe_sriov_vfio: Add open-basic subtest
Date: Fri, 27 Mar 2026 15:06:26 +0100	[thread overview]
Message-ID: <20260327140627.64574-4-marcin.bernatowicz@linux.intel.com> (raw)
In-Reply-To: <20260327140627.64574-1-marcin.bernatowicz@linux.intel.com>

The subtest binds a VF to xe-vfio-pci, opens its VFIO group, and
verifies basic VFIO access with a minimal group status query. This
provides a simple smoke test for VFIO device setup.

Signed-off-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
Cc: Adam Miszczak <adam.miszczak@linux.intel.com>
Cc: Jakub Kolakowski <jakub1.kolakowski@intel.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Lukasz Laguna <lukasz.laguna@intel.com>
---
v2:
- Introduce vf_num variable for clarity (Lukasz)
- Remove unnecessary unbind (Lukasz)
---
 tests/intel/xe_sriov_vfio.c | 136 ++++++++++++++++++++++++++++++++++++
 1 file changed, 136 insertions(+)

diff --git a/tests/intel/xe_sriov_vfio.c b/tests/intel/xe_sriov_vfio.c
index fa9026741..6a86b3780 100644
--- a/tests/intel/xe_sriov_vfio.c
+++ b/tests/intel/xe_sriov_vfio.c
@@ -2,6 +2,9 @@
 /*
  * Copyright(c) 2026 Intel Corporation. All rights reserved.
  */
+#include <linux/vfio.h>
+#include <limits.h>
+#include <sys/ioctl.h>
 
 #include "drmtest.h"
 #include "igt_core.h"
@@ -22,6 +25,9 @@
  *
  * SUBTEST: bind-unbind-vfs
  * Description: Enable VFs and bind/unbind each one to xe-vfio-pci via driver_override.
+ *
+ * SUBTEST: open-basic
+ * Description: Bind VF to xe-vfio-pci and perform minimal VFIO group open and status ioctl.
  */
 
 IGT_TEST_DESCRIPTION("Xe SR-IOV VFIO tests (xe-vfio-pci)");
@@ -109,6 +115,109 @@ static void bind_unbind_vfs(unsigned int num_vfs)
 	igt_sriov_disable_vfs(pf_fd);
 }
 
+static bool vf_iommu_group_id_alloc(const char *pci_slot, char **out_group_id)
+{
+	char path[PATH_MAX];
+	char link[PATH_MAX];
+	ssize_t len;
+	const char *base;
+
+	igt_assert(out_group_id);
+	*out_group_id = NULL;
+
+	snprintf(path, sizeof(path), "/sys/bus/pci/devices/%s/iommu_group", pci_slot);
+	len = readlink(path, link, sizeof(link) - 1);
+	if (len < 0)
+		return false;
+
+	link[len] = '\0';
+	base = strrchr(link, '/');
+	if (!base || !base[1])
+		return false;
+
+	*out_group_id = strdup(base + 1);
+	igt_assert(*out_group_id);
+
+	return true;
+}
+
+struct vfio_dev_fds {
+	int container_fd;
+	int group_fd;
+	int device_fd;
+	char *group_id;
+};
+
+static void vfio_open_group(const char *pci_slot, struct vfio_dev_fds *out,
+			    struct vfio_group_status *out_group_status)
+{
+	char group_path[PATH_MAX];
+	int ret;
+
+	igt_assert(out);
+	*out = (struct vfio_dev_fds){
+		.container_fd = -1,
+		.group_fd = -1,
+		.device_fd = -1,
+		.group_id = NULL,
+	};
+
+	if (out_group_status)
+		*out_group_status = (struct vfio_group_status){
+					.argsz = sizeof(*out_group_status)
+				    };
+
+	if (!vf_iommu_group_id_alloc(pci_slot, &out->group_id))
+		igt_skip("No IOMMU group (IOMMU disabled or not exposed)\n");
+
+	out->container_fd = open("/dev/vfio/vfio", O_RDWR | O_CLOEXEC);
+	if (out->container_fd < 0)
+		igt_skip("/dev/vfio/vfio not available\n");
+
+	snprintf(group_path, sizeof(group_path), "/dev/vfio/%s", out->group_id);
+	out->group_fd = open(group_path, O_RDWR | O_CLOEXEC);
+	igt_require_f(out->group_fd >= 0, "Failed to open %s (%d)\n", group_path, -errno);
+
+	if (out_group_status) {
+		ret = ioctl(out->group_fd, VFIO_GROUP_GET_STATUS, out_group_status);
+		igt_require_f(ret == 0, "VFIO_GROUP_GET_STATUS failed (%d)\n", -errno);
+	}
+}
+
+static void vfio_close_device(struct vfio_dev_fds *fds)
+{
+	if (!fds)
+		return;
+
+	if (fds->device_fd >= 0)
+		close(fds->device_fd);
+
+	if (fds->group_fd >= 0 && fds->container_fd >= 0)
+		ioctl(fds->group_fd, VFIO_GROUP_UNSET_CONTAINER, &fds->container_fd);
+
+	if (fds->group_fd >= 0)
+		close(fds->group_fd);
+	if (fds->container_fd >= 0)
+		close(fds->container_fd);
+
+	free(fds->group_id);
+
+	fds->container_fd = -1;
+	fds->group_fd = -1;
+	fds->device_fd = -1;
+	fds->group_id = NULL;
+}
+
+static void vfio_open_basic(const char *pci_slot)
+{
+	struct vfio_dev_fds fds;
+	struct vfio_group_status group_status;
+
+	vfio_open_group(pci_slot, &fds, &group_status);
+	igt_info("VFIO group %s status flags=0x%x\n", fds.group_id, group_status.flags);
+	vfio_close_device(&fds);
+}
+
 static void open_pf(void)
 {
 	int fd;
@@ -207,6 +316,33 @@ int igt_main()
 		}
 	}
 
+	igt_describe("Bind VF to xe-vfio-pci and do minimal VFIO open and GET_STATUS.");
+	igt_subtest("open-basic") {
+		unsigned int vf_num = 1;
+		char *slot = NULL;
+
+		igt_skip_on_f(igt_kmod_load(XE_VFIO_PCI_MOD, NULL),
+			      "Failed to load %s\n", XE_VFIO_PCI_MOD);
+
+		open_pf();
+
+		igt_sriov_disable_driver_autoprobe(pf_fd);
+		igt_sriov_enable_vfs(pf_fd, vf_num);
+
+		igt_require_f(!igt_pci_system_reinit(), "Failed to refresh PCI state\n");
+		igt_sriov_enable_driver_autoprobe(pf_fd);
+
+		slot = vf_pci_slot_alloc(vf_num);
+
+		vf_bind_override(vf_num, XE_VFIO_PCI_DRV);
+
+		vfio_open_basic(slot);
+
+		vf_unbind_override(vf_num);
+		free(slot);
+		igt_sriov_disable_vfs(pf_fd);
+	}
+
 	igt_fixture() {
 		cleanup_pf();
 		restore_xe_vfio_module();
-- 
2.43.0


  parent reply	other threads:[~2026-03-27 14:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27 14:06 [PATCH v2 i-g-t 0/4] tests/intel/xe_sriov_vfio: Add basic VFIO coverage Marcin Bernatowicz
2026-03-27 14:06 ` [PATCH v2 i-g-t 1/4] tests/intel/xe_sriov_vfio: Add VFIO module load/unload subtest Marcin Bernatowicz
2026-03-30  8:18   ` Laguna, Lukasz
2026-03-27 14:06 ` [PATCH v2 i-g-t 2/4] tests/intel/xe_sriov_vfio: Add dynamic bind-unbind-vfs subtest Marcin Bernatowicz
2026-03-30  8:18   ` Laguna, Lukasz
2026-03-27 14:06 ` Marcin Bernatowicz [this message]
2026-03-30  8:19   ` [PATCH v2 i-g-t 3/4] tests/intel/xe_sriov_vfio: Add open-basic subtest Laguna, Lukasz
2026-03-27 14:06 ` [PATCH v2 i-g-t 4/4] tests/intel/xe_sriov_vfio: Add region-info subtest Marcin Bernatowicz
2026-03-30  8:19   ` Laguna, Lukasz
2026-03-27 22:25 ` ✓ Xe.CI.BAT: success for tests/intel/xe_sriov_vfio: Add basic VFIO coverage (rev2) Patchwork
2026-03-27 22:57 ` ✓ i915.CI.BAT: " Patchwork
2026-03-28 15:53 ` ✓ Xe.CI.FULL: " Patchwork
2026-03-29  3:48 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260327140627.64574-4-marcin.bernatowicz@linux.intel.com \
    --to=marcin.bernatowicz@linux.intel.com \
    --cc=adam.miszczak@linux.intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jakub1.kolakowski@intel.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=lukasz.laguna@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox