From: "Michał Grzelak" <michal.grzelak@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Mohammed Thasleem" <mohammed.thasleem@intel.com>,
"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH i-g-t v9 4/6] tests/kms_flip: limit number of outputs wrt suspend
Date: Mon, 30 Mar 2026 09:55:06 +0200 [thread overview]
Message-ID: <20260330075508.1003899-5-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260330075508.1003899-1-michal.grzelak@intel.com>
When running suspend subtests on single output, we can still hit the
timeout by testing too much outputs. Default to testing 3 outputs. Add
command-line parameter to run on all outputs.
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
tests/kms_flip.c | 24 +++++++++++++++++++++---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 9ea5eb0352..3b3d2d40aa 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -264,12 +264,14 @@
#define RUN_PAIR 2
#define PAIR_LIMIT 3
+#define CONN_LIMIT 3
#ifndef DRM_CAP_TIMESTAMP_MONOTONIC
#define DRM_CAP_TIMESTAMP_MONOTONIC 6
#endif
static bool all_crtcs = false;
+static bool all_conns = false;
static bool all_pairs = false;
drmModeRes *resources;
@@ -1826,6 +1828,7 @@ static void run_test(int duration, int flags)
{
struct test_output o;
int i, n, modes = 0;
+ int conn_count = 0;
/* No tiling support in XE. */
if (is_xe_device(drm_fd) && flags & TEST_FENCE_STRESS)
@@ -1891,6 +1894,10 @@ static void run_test(int duration, int flags)
if ((flags & TEST_SUSPEND) && !all_crtcs && n != 0)
continue;
+ /* Limit number of displays run */
+ if ((flags & TEST_SUSPEND) && !all_conns && conn_count >= CONN_LIMIT)
+ continue;
+
memset(&o, 0, sizeof(o));
o.count = 1;
o._connector[0] = resources->connectors[i];
@@ -1899,8 +1906,15 @@ static void run_test(int duration, int flags)
o.depth = 24;
crtc_idx = n;
- run_test_on_crtc_set(&o, &crtc_idx, RUN_TEST,
- resources->count_crtcs, duration);
+
+ connector_find_preferred_mode(o._connector[0], n, &o);
+ if (o.mode_valid) {
+ run_test_on_crtc_set(&o, &crtc_idx, RUN_TEST,
+ resources->count_crtcs, duration);
+ conn_count++;
+ } else {
+ free_test_output(&o);
+ }
}
}
@@ -2061,6 +2075,9 @@ static void test_nonblocking_read(int in)
static int opt_handler(int opt, int opt_index, void *data)
{
switch (opt) {
+ case 'c':
+ all_conns = true;
+ break;
case 'e':
all_crtcs = true;
break;
@@ -2075,10 +2092,11 @@ static int opt_handler(int opt, int opt_index, void *data)
}
const char *help_str =
+ " -c \tRun on all connectors. (By default suspend subtests will run on 3 connectors)\n"
" -e \tRun on all CRTCs. (By default subtests will run on two CRTCs)\n"
" -p \tRun on all output pairs. (By default 2x-* suspend subtests will run on 3 pairs)\n";
-int igt_main_args("ep", NULL, help_str, opt_handler, NULL)
+int igt_main_args("cep", NULL, help_str, opt_handler, NULL)
{
struct {
int duration;
--
2.45.2
next prev parent reply other threads:[~2026-03-30 7:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-30 7:55 [PATCH i-g-t v9 0/6] kms_flip: limit number of subtests run Michał Grzelak
2026-03-30 7:55 ` [PATCH i-g-t v9 1/6] tests/kms_flip: test suspend on one pair of pipes Michał Grzelak
2026-03-30 7:55 ` [PATCH i-g-t v9 2/6] tests/kms_flip: run suspend tests on one pipe per output Michał Grzelak
2026-03-30 7:55 ` [PATCH i-g-t v9 3/6] tests/kms_flip: limit output pairs when testing suspend Michał Grzelak
2026-03-30 7:55 ` Michał Grzelak [this message]
2026-03-31 7:37 ` [PATCH i-g-t v9 4/6] tests/kms_flip: limit number of outputs wrt suspend Thasleem, Mohammed
2026-03-30 7:55 ` [PATCH i-g-t v9 5/6] tests/kms_flip: staticize & remove unused global vars Michał Grzelak
2026-03-30 7:55 ` [PATCH i-g-t v9 6/6] tests/kms_flip: test suspend at most twice on SNB && BMG Michał Grzelak
2026-04-02 8:50 ` Thasleem, Mohammed
2026-03-31 0:16 ` ✓ Xe.CI.BAT: success for kms_flip: limit number of subtests run (rev12) Patchwork
2026-03-31 0:24 ` ✓ i915.CI.BAT: " Patchwork
2026-03-31 4:07 ` ✓ Xe.CI.FULL: " Patchwork
2026-03-31 6:48 ` ✗ i915.CI.Full: failure " Patchwork
2026-04-02 21:21 ` Michał Grzelak
2026-04-02 11:30 ` ✓ Xe.CI.BAT: success for kms_flip: limit number of subtests run (rev13) Patchwork
2026-04-02 11:35 ` ✓ i915.CI.BAT: " Patchwork
2026-04-02 19:18 ` ✓ Xe.CI.FULL: " Patchwork
2026-04-03 8:20 ` ✗ i915.CI.Full: failure " Patchwork
2026-04-03 9:17 ` Michał Grzelak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260330075508.1003899-5-michal.grzelak@intel.com \
--to=michal.grzelak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mohammed.thasleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox