public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Michał Grzelak" <michal.grzelak@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Mohammed Thasleem" <mohammed.thasleem@intel.com>,
	"Michał Grzelak" <michal.grzelak@intel.com>
Subject: [PATCH i-g-t v9 6/6] tests/kms_flip: test suspend at most twice on SNB && BMG
Date: Mon, 30 Mar 2026 09:55:08 +0200	[thread overview]
Message-ID: <20260330075508.1003899-7-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260330075508.1003899-1-michal.grzelak@intel.com>

gettime_us() on SNB and BMG from CI does not return proper time after
starting suspend tests. This results in too many suspends issued before
we hit the duration_ms. Break the loop on second execution.

This WA explicitly conflicts with commit c75dcbdac51d ("tests/kms_flip:
various improvements"). This WA is therefore only used by SNB and BMG.

Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
 tests/kms_flip.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 1a0517bcef..81fa8dd5c0 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1325,7 +1325,13 @@ static bool event_loop(struct test_output *o, unsigned duration_ms,
 		       unsigned *elapsed)
 {
 	unsigned long start, end;
+	uint32_t devid;
 	int count = 0;
+	bool wa;
+
+	devid = intel_get_drm_devid(drm_fd);
+
+	wa = IS_SANDYBRIDGE(devid) || IS_BATTLEMAGE(devid);
 
 	start = gettime_us();
 
@@ -1346,6 +1352,9 @@ static bool event_loop(struct test_output *o, unsigned duration_ms,
 		if (count && (gettime_us() - start) / 1000 >= duration_ms)
 			break;
 
+		if (count && wa && o->flags & TEST_SUSPEND)
+			break;
+
 		count++;
 	}
 
-- 
2.45.2


  parent reply	other threads:[~2026-03-30  7:56 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30  7:55 [PATCH i-g-t v9 0/6] kms_flip: limit number of subtests run Michał Grzelak
2026-03-30  7:55 ` [PATCH i-g-t v9 1/6] tests/kms_flip: test suspend on one pair of pipes Michał Grzelak
2026-03-30  7:55 ` [PATCH i-g-t v9 2/6] tests/kms_flip: run suspend tests on one pipe per output Michał Grzelak
2026-03-30  7:55 ` [PATCH i-g-t v9 3/6] tests/kms_flip: limit output pairs when testing suspend Michał Grzelak
2026-03-30  7:55 ` [PATCH i-g-t v9 4/6] tests/kms_flip: limit number of outputs wrt suspend Michał Grzelak
2026-03-31  7:37   ` Thasleem, Mohammed
2026-03-30  7:55 ` [PATCH i-g-t v9 5/6] tests/kms_flip: staticize & remove unused global vars Michał Grzelak
2026-03-30  7:55 ` Michał Grzelak [this message]
2026-04-02  8:50   ` [PATCH i-g-t v9 6/6] tests/kms_flip: test suspend at most twice on SNB && BMG Thasleem, Mohammed
2026-03-31  0:16 ` ✓ Xe.CI.BAT: success for kms_flip: limit number of subtests run (rev12) Patchwork
2026-03-31  0:24 ` ✓ i915.CI.BAT: " Patchwork
2026-03-31  4:07 ` ✓ Xe.CI.FULL: " Patchwork
2026-03-31  6:48 ` ✗ i915.CI.Full: failure " Patchwork
2026-04-02 21:21   ` Michał Grzelak
2026-04-02 11:30 ` ✓ Xe.CI.BAT: success for kms_flip: limit number of subtests run (rev13) Patchwork
2026-04-02 11:35 ` ✓ i915.CI.BAT: " Patchwork
2026-04-02 19:18 ` ✓ Xe.CI.FULL: " Patchwork
2026-04-03  8:20 ` ✗ i915.CI.Full: failure " Patchwork
2026-04-03  9:17   ` Michał Grzelak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260330075508.1003899-7-michal.grzelak@intel.com \
    --to=michal.grzelak@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mohammed.thasleem@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox