public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
	"Priyanka Dandamudi" <priyanka.dandamudi@intel.com>
Subject: [PATCH i-g-t 2/3] tests/xe_compute: Don't use FAULT_MODE flag when not needed
Date: Wed,  1 Apr 2026 11:10:20 +0200	[thread overview]
Message-ID: <20260401091017.2772519-7-zbigniew.kempczynski@intel.com> (raw)
In-Reply-To: <20260401091017.2772519-5-zbigniew.kempczynski@intel.com>

For buffers which are normal BO using FAULT_MODE is not needed.
Remove this flag when buffers passed to compute library aren't
system allocated (SVM).

Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Cc: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
---
 tests/intel/xe_compute.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/intel/xe_compute.c b/tests/intel/xe_compute.c
index 762e66fcd3..ef2d891667 100644
--- a/tests/intel/xe_compute.c
+++ b/tests/intel/xe_compute.c
@@ -563,6 +563,7 @@ test_compute_square_userenv(int fd, uint32_t flags)
 {
 	struct user_execenv env = {};
 	uint32_t input_bo, output_bo, vm, size = SZ_4K;
+	uint32_t vm_flags = DRM_XE_VM_CREATE_FLAG_LR_MODE;
 	int va_bits = xe_va_bits(fd);
 	float *input, *output;
 	int i;
@@ -570,8 +571,9 @@ test_compute_square_userenv(int fd, uint32_t flags)
 	size = ALIGN(size, xe_get_default_alignment(fd));
 	env.array_size = size / sizeof(float);
 
-	vm = env.vm = xe_vm_create(fd, DRM_XE_VM_CREATE_FLAG_LR_MODE |
-				   DRM_XE_VM_CREATE_FLAG_FAULT_MODE, 0);
+	if ((flags & INPUT_IN_SVM) || (flags & OUTPUT_IN_SVM))
+		vm_flags |= DRM_XE_VM_CREATE_FLAG_FAULT_MODE;
+	vm = env.vm = xe_vm_create(fd, vm_flags, 0);
 
 	if ((flags & INPUT_IN_SVM) || (flags & OUTPUT_IN_SVM)) {
 		struct drm_xe_sync sync = {
-- 
2.43.0


  parent reply	other threads:[~2026-04-01  9:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01  9:10 [PATCH i-g-t 0/3] Exercise large buffer in compute-square Zbigniew Kempczyński
2026-04-01  9:10 ` [PATCH i-g-t 1/3] lib/intel_compute: Print handle in list of bindings Zbigniew Kempczyński
2026-04-02  4:54   ` Dandamudi, Priyanka
2026-04-01  9:10 ` Zbigniew Kempczyński [this message]
2026-04-02  4:55   ` [PATCH i-g-t 2/3] tests/xe_compute: Don't use FAULT_MODE flag when not needed Dandamudi, Priyanka
2026-04-01  9:10 ` [PATCH i-g-t 3/3] tests/xe_compute: Exercise larger buffers passed from the user Zbigniew Kempczyński
2026-04-02  4:55   ` Dandamudi, Priyanka
2026-04-01 16:00 ` ✓ Xe.CI.BAT: success for Exercise large buffer in compute-square Patchwork
2026-04-01 16:19 ` ✗ i915.CI.BAT: failure " Patchwork
2026-04-02 13:43   ` Zbigniew Kempczyński
2026-04-01 20:36 ` ✗ Xe.CI.FULL: " Patchwork
2026-04-02 13:45   ` Zbigniew Kempczyński
2026-04-01 22:30 ` ✓ Xe.CI.BAT: success for Exercise large buffer in compute-square (rev2) Patchwork
2026-04-01 22:46 ` ✗ i915.CI.BAT: failure " Patchwork
2026-04-02  5:51 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260401091017.2772519-7-zbigniew.kempczynski@intel.com \
    --to=zbigniew.kempczynski@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=priyanka.dandamudi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox