[PATCH i-g-t v3] tests/kms_properties: Add skip on headless machines

[PATCH i-g-t v3] tests/kms_properties: Add skip on headless machines

[sumit kishore]

From: Sumit Kishore <sumit.kishore@intel.com>

Print debug messages for sub-tests which are expected to
skip on headless display systems.

v2: Use existing library function, instead of
    defining new (karthik)
v3: Add headless display check in,
    colorop_properties function (Pranay)

Signed-off-by: Sumit Kishore <sumit.kishore@intel.com>
---
 tests/kms_properties.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/tests/kms_properties.c b/tests/kms_properties.c
index f735839da..5164277b3 100644
--- a/tests/kms_properties.c
+++ b/tests/kms_properties.c
@@ -341,6 +341,8 @@ static void colorop_properties(igt_display_t *display, bool atomic)
 	igt_output_t *output;
 	igt_crtc_t *crtc;
 
+	igt_display_require_output(display);
+
 	/* colorops are only available with atomic */
 	igt_skip_on(!display->is_atomic);
 
@@ -377,6 +379,8 @@ static void plane_properties(igt_display_t *display, bool atomic)
 	igt_output_t *output;
 	igt_crtc_t *crtc;
 
+	igt_display_require_output(display);
+
 	for_each_crtc_with_single_output(display, crtc, output) {
 		igt_display_reset(display);
 
@@ -400,6 +404,8 @@ static void crtc_properties(igt_display_t *display, bool atomic)
 	igt_crtc_t *crtc;
 	igt_output_t *output;
 
+	igt_display_require_output(display);
+
 	for_each_crtc_with_single_output(display, crtc, output) {
 		igt_display_reset(display);
 
-- 
2.43.0

✓ Xe.CI.BAT: success for tests/kms_properties: Add skip on headless machines (rev3)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 2320 bytes --]

== Series Details ==

Series: tests/kms_properties: Add skip on headless machines (rev3)
URL   : https://patchwork.freedesktop.org/series/162630/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_8840_BAT -> XEIGTPW_14906_BAT
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (14 -> 14)
------------------------------

  No changes in participating hosts

Known issues
------------

  Here are the changes found in XEIGTPW_14906_BAT that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1:
    - bat-adlp-7:         [PASS][1] -> [DMESG-WARN][2] ([Intel XE#7483])
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8840/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank@c-edp1.html

  * igt@xe_waitfence@engine:
    - bat-dg2-oem2:       [PASS][3] -> [FAIL][4] ([Intel XE#6519])
   [3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8840/bat-dg2-oem2/igt@xe_waitfence@engine.html
   [4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/bat-dg2-oem2/igt@xe_waitfence@engine.html

  
#### Possible fixes ####

  * igt@kms_flip@basic-flip-vs-wf_vblank@d-edp1:
    - bat-adlp-7:         [DMESG-WARN][5] ([Intel XE#7483]) -> [PASS][6]
   [5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8840/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank@d-edp1.html
   [6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/bat-adlp-7/igt@kms_flip@basic-flip-vs-wf_vblank@d-edp1.html

  
  [Intel XE#6519]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6519
  [Intel XE#7483]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7483


Build changes
-------------

  * IGT: IGT_8840 -> IGTPW_14906
  * Linux: xe-4833-5d36e6d54e963f0c1137aaf2249d2baa781f08c2 -> xe-4834-35dad892ec87d448384f492ba061d0da7e3710a5

  IGTPW_14906: 14906
  IGT_8840: 8840
  xe-4833-5d36e6d54e963f0c1137aaf2249d2baa781f08c2: 5d36e6d54e963f0c1137aaf2249d2baa781f08c2
  xe-4834-35dad892ec87d448384f492ba061d0da7e3710a5: 35dad892ec87d448384f492ba061d0da7e3710a5

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/index.html

[-- Attachment #2: Type: text/html, Size: 3028 bytes --]

✗ i915.CI.BAT: failure for tests/kms_properties: Add skip on headless machines (rev3)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 4337 bytes --]

== Series Details ==

Series: tests/kms_properties: Add skip on headless machines (rev3)
URL   : https://patchwork.freedesktop.org/series/162630/
State : failure

== Summary ==

CI Bug Log - changes from IGT_8840 -> IGTPW_14906
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with IGTPW_14906 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_14906, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14906/index.html

Participating hosts (42 -> 40)
------------------------------

  Missing    (2): bat-dg2-13 fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_14906:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@gem_migrate:
    - bat-arlh-2:         [PASS][1] -> [INCOMPLETE][2] +1 other test incomplete
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8840/bat-arlh-2/igt@i915_selftest@live@gem_migrate.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14906/bat-arlh-2/igt@i915_selftest@live@gem_migrate.html

  
Known issues
------------

  Here are the changes found in IGTPW_14906 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live:
    - bat-mtlp-8:         [PASS][3] -> [DMESG-FAIL][4] ([i915#12061]) +1 other test dmesg-fail
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8840/bat-mtlp-8/igt@i915_selftest@live.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14906/bat-mtlp-8/igt@i915_selftest@live.html

  * igt@i915_selftest@live@workarounds:
    - bat-arls-5:         [PASS][5] -> [DMESG-FAIL][6] ([i915#12061]) +1 other test dmesg-fail
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8840/bat-arls-5/igt@i915_selftest@live@workarounds.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14906/bat-arls-5/igt@i915_selftest@live@workarounds.html

  * igt@kms_pipe_crc_basic@read-crc-frame-sequence:
    - bat-arls-6:         [PASS][7] -> [SKIP][8] ([i915#11190]) +2 other tests skip
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8840/bat-arls-6/igt@kms_pipe_crc_basic@read-crc-frame-sequence.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14906/bat-arls-6/igt@kms_pipe_crc_basic@read-crc-frame-sequence.html

  * igt@prime_vgem@basic-fence-flip:
    - fi-pnv-d510:        [PASS][9] -> [ABORT][10] ([i915#15773])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8840/fi-pnv-d510/igt@prime_vgem@basic-fence-flip.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14906/fi-pnv-d510/igt@prime_vgem@basic-fence-flip.html

  
#### Possible fixes ####

  * igt@i915_selftest@live:
    - bat-dg2-8:          [DMESG-FAIL][11] ([i915#12061]) -> [PASS][12] +1 other test pass
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8840/bat-dg2-8/igt@i915_selftest@live.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14906/bat-dg2-8/igt@i915_selftest@live.html

  * igt@i915_selftest@live@workarounds:
    - bat-arlh-3:         [DMESG-FAIL][13] ([i915#12061]) -> [PASS][14] +1 other test pass
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8840/bat-arlh-3/igt@i915_selftest@live@workarounds.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14906/bat-arlh-3/igt@i915_selftest@live@workarounds.html

  
  [i915#11190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11190
  [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
  [i915#15773]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15773


Build changes
-------------

  * CI: CI-20190529 -> None
  * IGT: IGT_8840 -> IGTPW_14906
  * Linux: CI_DRM_18262 -> CI_DRM_18263

  CI-20190529: 20190529
  CI_DRM_18262: 5d36e6d54e963f0c1137aaf2249d2baa781f08c2 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_18263: 35dad892ec87d448384f492ba061d0da7e3710a5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_14906: 14906
  IGT_8840: 8840

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_14906/index.html

[-- Attachment #2: Type: text/html, Size: 5357 bytes --]

✓ Xe.CI.FULL: success for tests/kms_properties: Add skip on headless machines (rev3)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 9693 bytes --]

== Series Details ==

Series: tests/kms_properties: Add skip on headless machines (rev3)
URL   : https://patchwork.freedesktop.org/series/162630/
State : success

== Summary ==

CI Bug Log - changes from XEIGT_8840_FULL -> XEIGTPW_14906_FULL
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  

Participating hosts (2 -> 2)
------------------------------

  No changes in participating hosts

Known issues
------------

  Here are the changes found in XEIGTPW_14906_FULL that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
    - shard-lnl:          NOTRUN -> [SKIP][1] ([Intel XE#1407])
   [1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-6/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip.html

  * igt@kms_ccs@crc-primary-basic-yf-tiled-ccs:
    - shard-lnl:          NOTRUN -> [SKIP][2] ([Intel XE#2887])
   [2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-4/igt@kms_ccs@crc-primary-basic-yf-tiled-ccs.html

  * igt@kms_chamelium_hpd@dp-hpd-after-hibernate:
    - shard-lnl:          NOTRUN -> [SKIP][3] ([Intel XE#373])
   [3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-8/igt@kms_chamelium_hpd@dp-hpd-after-hibernate.html

  * igt@kms_content_protection@atomic:
    - shard-lnl:          NOTRUN -> [SKIP][4] ([Intel XE#7642])
   [4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-4/igt@kms_content_protection@atomic.html

  * igt@kms_cursor_legacy@cursorb-vs-flipa-atomic:
    - shard-lnl:          NOTRUN -> [SKIP][5] ([Intel XE#309] / [Intel XE#7343])
   [5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-2/igt@kms_cursor_legacy@cursorb-vs-flipa-atomic.html

  * igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling:
    - shard-lnl:          NOTRUN -> [SKIP][6] ([Intel XE#1397] / [Intel XE#1745] / [Intel XE#7385])
   [6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling.html

  * igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-default-mode:
    - shard-lnl:          NOTRUN -> [SKIP][7] ([Intel XE#1397] / [Intel XE#7385])
   [7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-7/igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-downscaling@pipe-a-default-mode.html

  * igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling:
    - shard-lnl:          NOTRUN -> [SKIP][8] ([Intel XE#7178] / [Intel XE#7351])
   [8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-2/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling.html

  * igt@kms_frontbuffer_tracking@drrs-1p-rte:
    - shard-lnl:          NOTRUN -> [SKIP][9] ([Intel XE#6312] / [Intel XE#651])
   [9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-4/igt@kms_frontbuffer_tracking@drrs-1p-rte.html

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-render:
    - shard-lnl:          NOTRUN -> [SKIP][10] ([Intel XE#656])
   [10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-6/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-render.html

  * igt@kms_plane@pixel-format-y-tiled-gen12-mc-ccs-modifier-source-clamping:
    - shard-lnl:          NOTRUN -> [SKIP][11] ([Intel XE#7283])
   [11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-1/igt@kms_plane@pixel-format-y-tiled-gen12-mc-ccs-modifier-source-clamping.html

  * igt@kms_plane_lowres@tiling-x@pipe-b-edp-1:
    - shard-lnl:          NOTRUN -> [SKIP][12] ([Intel XE#599] / [Intel XE#7382]) +3 other tests skip
   [12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-5/igt@kms_plane_lowres@tiling-x@pipe-b-edp-1.html

  * igt@xe_eudebug@vm-bind-clear-faultable:
    - shard-lnl:          NOTRUN -> [SKIP][13] ([Intel XE#7636]) +1 other test skip
   [13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-2/igt@xe_eudebug@vm-bind-clear-faultable.html

  * igt@xe_evict@evict-small-external-multi-queue-cm:
    - shard-lnl:          NOTRUN -> [SKIP][14] ([Intel XE#6540] / [Intel XE#688])
   [14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-8/igt@xe_evict@evict-small-external-multi-queue-cm.html

  * igt@xe_exec_basic@multigpu-once-basic-defer-mmap:
    - shard-lnl:          NOTRUN -> [SKIP][15] ([Intel XE#1392])
   [15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-5/igt@xe_exec_basic@multigpu-once-basic-defer-mmap.html

  * igt@xe_exec_fault_mode@twice-multi-queue-rebind-imm:
    - shard-lnl:          NOTRUN -> [SKIP][16] ([Intel XE#7136]) +2 other tests skip
   [16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-2/igt@xe_exec_fault_mode@twice-multi-queue-rebind-imm.html

  * igt@xe_exec_multi_queue@many-execs-preempt-mode-fault-basic-smem:
    - shard-lnl:          NOTRUN -> [SKIP][17] ([Intel XE#6874]) +2 other tests skip
   [17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-6/igt@xe_exec_multi_queue@many-execs-preempt-mode-fault-basic-smem.html

  * igt@xe_exec_threads@threads-multi-queue-fd-userptr-rebind:
    - shard-lnl:          NOTRUN -> [SKIP][18] ([Intel XE#7138])
   [18]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-5/igt@xe_exec_threads@threads-multi-queue-fd-userptr-rebind.html

  * igt@xe_multigpu_svm@mgpu-latency-basic:
    - shard-lnl:          NOTRUN -> [SKIP][19] ([Intel XE#6964])
   [19]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-8/igt@xe_multigpu_svm@mgpu-latency-basic.html

  * igt@xe_pm@d3cold-basic:
    - shard-lnl:          NOTRUN -> [SKIP][20] ([Intel XE#2284] / [Intel XE#366] / [Intel XE#7370])
   [20]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-2/igt@xe_pm@d3cold-basic.html

  * igt@xe_query@multigpu-query-topology:
    - shard-lnl:          NOTRUN -> [SKIP][21] ([Intel XE#944]) +1 other test skip
   [21]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-5/igt@xe_query@multigpu-query-topology.html

  
#### Possible fixes ####

  * igt@kms_pm_dc@dc5-dpms:
    - shard-lnl:          [FAIL][22] ([Intel XE#7340] / [Intel XE#7504]) -> [PASS][23]
   [22]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8840/shard-lnl-7/igt@kms_pm_dc@dc5-dpms.html
   [23]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-6/igt@kms_pm_dc@dc5-dpms.html

  * igt@kms_pm_dc@dc5-psr:
    - shard-lnl:          [FAIL][24] ([Intel XE#7340]) -> [PASS][25]
   [24]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8840/shard-lnl-2/igt@kms_pm_dc@dc5-psr.html
   [25]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/shard-lnl-4/igt@kms_pm_dc@dc5-psr.html

  
  [Intel XE#1392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1392
  [Intel XE#1397]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1397
  [Intel XE#1407]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1407
  [Intel XE#1745]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1745
  [Intel XE#2284]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2284
  [Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
  [Intel XE#309]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/309
  [Intel XE#366]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/366
  [Intel XE#373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/373
  [Intel XE#599]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/599
  [Intel XE#6312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6312
  [Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
  [Intel XE#6540]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6540
  [Intel XE#656]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/656
  [Intel XE#6874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6874
  [Intel XE#688]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/688
  [Intel XE#6964]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6964
  [Intel XE#7136]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7136
  [Intel XE#7138]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7138
  [Intel XE#7178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7178
  [Intel XE#7283]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7283
  [Intel XE#7340]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7340
  [Intel XE#7343]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7343
  [Intel XE#7351]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7351
  [Intel XE#7370]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7370
  [Intel XE#7382]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7382
  [Intel XE#7385]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7385
  [Intel XE#7504]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7504
  [Intel XE#7636]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7636
  [Intel XE#7642]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7642
  [Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944


Build changes
-------------

  * IGT: IGT_8840 -> IGTPW_14906
  * Linux: xe-4833-5d36e6d54e963f0c1137aaf2249d2baa781f08c2 -> xe-4834-35dad892ec87d448384f492ba061d0da7e3710a5

  IGTPW_14906: 14906
  IGT_8840: 8840
  xe-4833-5d36e6d54e963f0c1137aaf2249d2baa781f08c2: 5d36e6d54e963f0c1137aaf2249d2baa781f08c2
  xe-4834-35dad892ec87d448384f492ba061d0da7e3710a5: 35dad892ec87d448384f492ba061d0da7e3710a5

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_14906/index.html

[-- Attachment #2: Type: text/html, Size: 10940 bytes --]

RE: [PATCH i-g-t v3] tests/kms_properties: Add skip on headless machines

[Samala, Pranay]

Hi Sumit,

> -----Original Message-----
> From: Kishore, Sumit <sumit.kishore@intel.com>
> Sent: Wednesday, April 1, 2026 5:13 PM
> To: igt-dev@lists.freedesktop.org
> Cc: Samala, Pranay <pranay.samala@intel.com>; Kishore, Sumit
> <sumit.kishore@intel.com>
> Subject: [PATCH i-g-t v3] tests/kms_properties: Add skip on headless
> machines
> 
> From: Sumit Kishore <sumit.kishore@intel.com>
> 
> Print debug messages for sub-tests which are expected to skip on headless
> display systems.

I feel you missed to address this but pasting the comment here again.

Commit message says print debug message but changes just skip, but doesn't 
print any debug message.
Please update the commit message as per the code changes.

Apart from this, changes LGTM.
Reviewed-by: Pranay Samala <pranay.samala@intel.com>

> 
> v2: Use existing library function, instead of
>     defining new (karthik)
> v3: Add headless display check in,
>     colorop_properties function (Pranay)
> 
> Signed-off-by: Sumit Kishore <sumit.kishore@intel.com>
> ---
>  tests/kms_properties.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/kms_properties.c b/tests/kms_properties.c index
> f735839da..5164277b3 100644
> --- a/tests/kms_properties.c
> +++ b/tests/kms_properties.c
> @@ -341,6 +341,8 @@ static void colorop_properties(igt_display_t *display,
> bool atomic)
>  	igt_output_t *output;
>  	igt_crtc_t *crtc;
> 
> +	igt_display_require_output(display);
> +
>  	/* colorops are only available with atomic */
>  	igt_skip_on(!display->is_atomic);
> 
> @@ -377,6 +379,8 @@ static void plane_properties(igt_display_t *display,
> bool atomic)
>  	igt_output_t *output;
>  	igt_crtc_t *crtc;
> 
> +	igt_display_require_output(display);
> +
>  	for_each_crtc_with_single_output(display, crtc, output) {
>  		igt_display_reset(display);
> 
> @@ -400,6 +404,8 @@ static void crtc_properties(igt_display_t *display, bool
> atomic)
>  	igt_crtc_t *crtc;
>  	igt_output_t *output;
> 
> +	igt_display_require_output(display);
> +
>  	for_each_crtc_with_single_output(display, crtc, output) {
>  		igt_display_reset(display);
> 
> --
> 2.43.0