RE: [PATCH i-g-t 6/7] tests/intel/kms_joiner: Require boundary mode for basic-max-non-joiner

Kandpal, Suraj
2026-04-02T05:27:36Z

> Subject: [PATCH i-g-t 6/7] tests/intel/kms_joiner: Require boundary mode for
> basic-max-non-joiner
>
> Skip when the returned mode's hdisplay is below the platform's single-pipe
> limit.

Add the why? Towards the problem this patch is solving. Makes life a little easier for the reviewer.
What happens if we don't skip ? How was it working previously ?

Other wise I don't see any issue with patch as such

Regards,
Suraj Kandpal

>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> tests/intel/kms_joiner.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/intel/kms_joiner.c b/tests/intel/kms_joiner.c index
> 86226a3ba..765572d98 100644
> --- a/tests/intel/kms_joiner.c
> +++ b/tests/intel/kms_joiner.c
> @@ -572,6 +572,7 @@ static void test_ultra_joiner(data_t *data, bool
> invalid_pipe, bool two_display, static void test_basic_max_non_joiner(data_t
> *data) {
> igt_display_t *display = &data->display;
> + int max_hdisplay = intel_get_max_pipe_hdisplay(data->drm_fd);
> int count;
> enum pipe pipe;
> igt_output_t **outputs, *output;
> @@ -597,6 +598,9 @@ static void test_basic_max_non_joiner(data_t *data)
>
> igt_require(max_non_joiner_mode_found(data->drm_fd,
> output-
> >config.connector,
>
> max_dotclock, &mode));
> + igt_require_f(mode.hdisplay >= max_hdisplay,
> + "Max non-joiner mode %dx%d
> below single-pipe limit %d\n",
> + mode.hdisplay, mode.vdisplay,
> max_hdisplay);
> igt_output_override_mode(output, &mode);
> igt_info("Appplying mode = %dx%d@%d\n",
> mode.hdisplay,
> mode.vdisplay, mode.vrefresh);
> --
> 2.25.1