Re: [PATCH i-g-t 6/7] tests/intel/kms_joiner: Require boundary mode for basic-max-non-joiner

Karthik B S
2026-04-06T06:07:10Z

Hi Kunal,

On 4/1/2026 9:36 PM, Kunal Joshi wrote:
> Skip when the returned mode's hdisplay is below the
> platform's single-pipe limit.
>
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
> tests/intel/kms_joiner.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/intel/kms_joiner.c b/tests/intel/kms_joiner.c
> index 86226a3ba..765572d98 100644
> --- a/tests/intel/kms_joiner.c
> +++ b/tests/intel/kms_joiner.c
> @@ -572,6 +572,7 @@ static void test_ultra_joiner(data_t *data, bool invalid_pipe, bool two_display,
> static void test_basic_max_non_joiner(data_t *data)
> {
> igt_display_t *display = &data->display;
> + int max_hdisplay = intel_get_max_pipe_hdisplay(data->drm_fd);
> int count;
> enum pipe pipe;
> igt_output_t **outputs, *output;
> @@ -597,6 +598,9 @@ static void test_basic_max_non_joiner(data_t *data)
> igt_require(max_non_joiner_mode_found(data->drm_fd,
> output->config.connector,
> max_dotclock, &mode));
> + igt_require_f(mode.hdisplay >= max_hdisplay,
> + "Max non-joiner mode %dx%d below single-pipe limit %d\n",
> + mode.hdisplay, mode.vdisplay, max_hdisplay);

This will break when we've a case where the highest mode returned is
based on clock and might not always be the mode which has max_hdisplay.
So we might need to have an independent function to handle this?

Thanks and Regards,
Karthik.B.S
> igt_output_override_mode(output, &mode);
> igt_info("Appplying mode = %dx%d@%d\n", mode.hdisplay,
> mode.vdisplay, mode.vrefresh);