public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Ashutosh Dixit <ashutosh.dixit@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
Subject: [PATCH i-g-t] tests/intel/xe_oa: Use MAP_FAILED for mmap failures
Date: Wed,  1 Apr 2026 15:32:15 -0700	[thread overview]
Message-ID: <20260401223215.111418-1-ashutosh.dixit@intel.com> (raw)

Detect mmap failure using MAP_FAILED instead of NULL.

Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
---
 tests/intel/xe_oa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
index 387f29535e..9444f70cd6 100644
--- a/tests/intel/xe_oa.c
+++ b/tests/intel/xe_oa.c
@@ -4367,7 +4367,7 @@ static void *map_oa_buffer(u32 *size)
 {
 	void *vaddr = mmap(0, default_oa_buffer_size, PROT_READ, MAP_PRIVATE, stream_fd, 0);
 
-	igt_assert(vaddr != NULL);
+	igt_assert(vaddr != MAP_FAILED);
 	*size = default_oa_buffer_size;
 	return vaddr;
 }
-- 
2.48.1


             reply	other threads:[~2026-04-01 22:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-01 22:32 Ashutosh Dixit [this message]
2026-04-01 23:08 ` ✓ Xe.CI.BAT: success for tests/intel/xe_oa: Use MAP_FAILED for mmap failures Patchwork
2026-04-01 23:22 ` ✓ i915.CI.BAT: " Patchwork
2026-04-02  7:09 ` ✓ Xe.CI.FULL: " Patchwork
2026-04-02  9:39 ` [PATCH i-g-t] " Kamil Konieczny
2026-04-02 18:51 ` ✗ i915.CI.Full: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260401223215.111418-1-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=umesh.nerlige.ramappa@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox