public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, santhosh.reddy.guddati@intel.com,
	swati2.sharma@intel.com, jani.nikula@intel.com,
	ville.syrjala@intel.com
Subject: [PATCH i-g-t v2 1/8] tests/intel/kms_frontbuffer_tracking: update the outdated fbc status checks
Date: Tue,  7 Apr 2026 12:58:36 +0300	[thread overview]
Message-ID: <20260407095843.43679-2-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20260407095843.43679-1-vinod.govindapillai@intel.com>

Replace the fbc status check for "mode too large for compression" wchich
is no longer being set by the driver with "plane size too big" and
"surface size too big" fbc status checks.

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 tests/intel/kms_frontbuffer_tracking.c | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index c16f63199..e764c9ce1 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -1664,15 +1664,23 @@ static bool fbc_stride_not_supported(void)
 	char buf[128];
 
 	debugfs_read_crtc("i915_fbc_status", buf);
-	return strstr(buf, "FBC disabled: framebuffer stride not supported\n");
+	return strstr(buf, "FBC disabled: stride not supported\n");
 }
 
-static bool fbc_mode_too_large(void)
+static bool fbc_plane_size_too_big(void)
 {
 	char buf[128];
 
 	debugfs_read_crtc("i915_fbc_status", buf);
-	return strstr(buf, "FBC disabled: mode too large for compression\n");
+	return strstr(buf, "FBC disabled: plane size too big\n");
+}
+
+static bool fbc_surface_size_too_big(void)
+{
+	char buf[128];
+
+	debugfs_read_crtc("i915_fbc_status", buf);
+	return strstr(buf, "FBC disabled: surface size too big\n");
 }
 
 static bool fbc_psr_not_possible(void)
@@ -2356,7 +2364,8 @@ static void do_status_assertions(int flags)
 	if (flags & ASSERT_FBC_ENABLED) {
 		igt_require(!fbc_not_enough_stolen());
 		igt_require(!fbc_stride_not_supported());
-		igt_require(!fbc_mode_too_large());
+		igt_require(!fbc_plane_size_too_big());
+		igt_require(!fbc_surface_size_too_big());
 		igt_require(!fbc_psr_not_possible());
 		if (!intel_fbc_wait_until_enabled(prim_mode_params.crtc)) {
 			igt_assert_f(intel_fbc_is_enabled(prim_mode_params.crtc, IGT_LOG_WARN),
-- 
2.43.0


  reply	other threads:[~2026-04-07  9:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07  9:58 [PATCH i-g-t v2 0/8] updates to fbc tests Vinod Govindapillai
2026-04-07  9:58 ` Vinod Govindapillai [this message]
2026-04-07  9:58 ` [PATCH i-g-t v2 2/8] tests/intel/kms_frontbuffer_tracking: avoid multiple fbc status queries Vinod Govindapillai
2026-04-07 11:14   ` Jani Nikula
2026-04-07  9:58 ` [PATCH i-g-t v2 3/8] lib/i915/fbc: extract intel_fbc_get_fbc_status() Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 4/8] tests/intel/kms_frontbuffer_tracking: use intel_fbc_get_fbc_status() Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 5/8] tests/intel/kms_frontbuffer_tracking: use a bigger fbc status buffer Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 6/8] tests/intel/kms_fbcon_fbt: " Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 7/8] tests/intel/kms_fbcon_fbt: update the outdated fbc skip reasons Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 8/8] tests/intel/kms_fbcon_fbt: use a common source for checking fbc tests skips Vinod Govindapillai
2026-04-07 11:21   ` Jani Nikula
2026-04-09  5:38 ` ✓ Xe.CI.BAT: success for updates to fbc tests (rev2) Patchwork
2026-04-09  5:56 ` ✓ i915.CI.BAT: " Patchwork
2026-04-09  7:00 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-09 16:43 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260407095843.43679-2-vinod.govindapillai@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=santhosh.reddy.guddati@intel.com \
    --cc=swati2.sharma@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox