From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, santhosh.reddy.guddati@intel.com,
swati2.sharma@intel.com, jani.nikula@intel.com,
ville.syrjala@intel.com
Subject: [PATCH i-g-t v2 3/8] lib/i915/fbc: extract intel_fbc_get_fbc_status()
Date: Tue, 7 Apr 2026 12:58:38 +0300 [thread overview]
Message-ID: <20260407095843.43679-4-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20260407095843.43679-1-vinod.govindapillai@intel.com>
Code to read the FBC status from the debugfs is being duplicated
in many places. Extract intel_fbc_get_fbc_status() to be used as
the single source to read the current FBC status.
Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
lib/i915/intel_fbc.c | 35 +++++++++++++++++++++++++----------
lib/i915/intel_fbc.h | 1 +
2 files changed, 26 insertions(+), 10 deletions(-)
diff --git a/lib/i915/intel_fbc.c b/lib/i915/intel_fbc.c
index b8c714d43..81aa5c5a5 100644
--- a/lib/i915/intel_fbc.c
+++ b/lib/i915/intel_fbc.c
@@ -22,6 +22,27 @@ void intel_fbc_disable(igt_display_t *display)
igt_set_module_param_int(display->drm_fd, "enable_fbc", 0);
}
+/**
+ * intel_fbc_get_fbc_status
+ * @crtc: CRTC
+ * @fbc_status: Buffer to fill the current fbc status
+ * @buf_size: Size of the buffer to be filled
+ *
+ * Read the debugfs entry for current fbc status of a crtc
+ *
+ * Returns:
+ * None
+ */
+void intel_fbc_get_fbc_status(igt_crtc_t *crtc, char *fbc_status, int buf_size)
+{
+ int dir;
+
+ dir = igt_crtc_debugfs_dir(crtc);
+ igt_require_fd(dir);
+ igt_debugfs_simple_read(dir, "i915_fbc_status", fbc_status, buf_size);
+ close(dir);
+}
+
/**
* intel_fbc_supported:
* @crtc: CRTC
@@ -34,12 +55,9 @@ void intel_fbc_disable(igt_display_t *display)
bool intel_fbc_supported(igt_crtc_t *crtc)
{
char buf[FBC_STATUS_BUF_LEN];
- int dir;
- dir = igt_crtc_debugfs_dir(crtc);
- igt_require_fd(dir);
- igt_debugfs_simple_read(dir, "i915_fbc_status", buf, sizeof(buf));
- close(dir);
+ intel_fbc_get_fbc_status(crtc, buf, sizeof(buf));
+
if (*buf == '\0')
return false;
@@ -51,12 +69,9 @@ static bool _intel_fbc_is_enabled(igt_crtc_t *crtc, int log_level, char *last_fb
{
char buf[FBC_STATUS_BUF_LEN];
bool print = true;
- int dir;
- dir = igt_crtc_debugfs_dir(crtc);
- igt_require_fd(dir);
- igt_debugfs_simple_read(dir, "i915_fbc_status", buf, sizeof(buf));
- close(dir);
+ intel_fbc_get_fbc_status(crtc, buf, sizeof(buf));
+
if (log_level != IGT_LOG_DEBUG)
last_fbc_buf[0] = '\0';
else if (strcmp(last_fbc_buf, buf))
diff --git a/lib/i915/intel_fbc.h b/lib/i915/intel_fbc.h
index b4596cca5..d62ad73fc 100644
--- a/lib/i915/intel_fbc.h
+++ b/lib/i915/intel_fbc.h
@@ -25,5 +25,6 @@ bool intel_fbc_wait_until_enabled(igt_crtc_t *crtc);
bool intel_fbc_is_enabled(igt_crtc_t *crtc, int log_level);
bool intel_fbc_plane_size_supported(igt_display_t *display, uint32_t width, uint32_t height);
bool intel_fbc_supported_for_psr_mode(igt_display_t *display, enum psr_mode mode);
+void intel_fbc_get_fbc_status(igt_crtc_t *crtc, char *fbc_status, int buf_size);
#endif
--
2.43.0
next prev parent reply other threads:[~2026-04-07 9:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 9:58 [PATCH i-g-t v2 0/8] updates to fbc tests Vinod Govindapillai
2026-04-07 9:58 ` [PATCH i-g-t v2 1/8] tests/intel/kms_frontbuffer_tracking: update the outdated fbc status checks Vinod Govindapillai
2026-04-07 9:58 ` [PATCH i-g-t v2 2/8] tests/intel/kms_frontbuffer_tracking: avoid multiple fbc status queries Vinod Govindapillai
2026-04-07 11:14 ` Jani Nikula
2026-04-07 9:58 ` Vinod Govindapillai [this message]
2026-04-07 9:58 ` [PATCH i-g-t v2 4/8] tests/intel/kms_frontbuffer_tracking: use intel_fbc_get_fbc_status() Vinod Govindapillai
2026-04-07 9:58 ` [PATCH i-g-t v2 5/8] tests/intel/kms_frontbuffer_tracking: use a bigger fbc status buffer Vinod Govindapillai
2026-04-07 9:58 ` [PATCH i-g-t v2 6/8] tests/intel/kms_fbcon_fbt: " Vinod Govindapillai
2026-04-07 9:58 ` [PATCH i-g-t v2 7/8] tests/intel/kms_fbcon_fbt: update the outdated fbc skip reasons Vinod Govindapillai
2026-04-07 9:58 ` [PATCH i-g-t v2 8/8] tests/intel/kms_fbcon_fbt: use a common source for checking fbc tests skips Vinod Govindapillai
2026-04-07 11:21 ` Jani Nikula
2026-04-09 5:38 ` ✓ Xe.CI.BAT: success for updates to fbc tests (rev2) Patchwork
2026-04-09 5:56 ` ✓ i915.CI.BAT: " Patchwork
2026-04-09 7:00 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-09 16:43 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260407095843.43679-4-vinod.govindapillai@intel.com \
--to=vinod.govindapillai@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=santhosh.reddy.guddati@intel.com \
--cc=swati2.sharma@intel.com \
--cc=ville.syrjala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox