Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, santhosh.reddy.guddati@intel.com,
	swati2.sharma@intel.com, jani.nikula@intel.com,
	ville.syrjala@intel.com
Subject: [PATCH i-g-t v2 5/8] tests/intel/kms_frontbuffer_tracking: use a bigger fbc status buffer
Date: Tue,  7 Apr 2026 12:58:40 +0300	[thread overview]
Message-ID: <20260407095843.43679-6-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20260407095843.43679-1-vinod.govindapillai@intel.com>

As the FBC status now include plane specific FBC status as well, we
need a bigger buffer to capture the complete FBC status. Define the
buffer length in a single place and use it across places where the
test need to assess the FBC status

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 lib/i915/intel_fbc.c                   |  2 --
 lib/i915/intel_fbc.h                   |  2 ++
 tests/intel/kms_frontbuffer_tracking.c | 10 +++++-----
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/lib/i915/intel_fbc.c b/lib/i915/intel_fbc.c
index 81aa5c5a5..a7a18cba2 100644
--- a/lib/i915/intel_fbc.c
+++ b/lib/i915/intel_fbc.c
@@ -10,8 +10,6 @@
 
 #include "intel_fbc.h"
 
-#define FBC_STATUS_BUF_LEN 128
-
 void intel_fbc_enable(igt_display_t *display)
 {
 	igt_set_module_param_int(display->drm_fd, "enable_fbc", 1);
diff --git a/lib/i915/intel_fbc.h b/lib/i915/intel_fbc.h
index d62ad73fc..3dd15de31 100644
--- a/lib/i915/intel_fbc.h
+++ b/lib/i915/intel_fbc.h
@@ -8,6 +8,8 @@
 
 #include "igt.h"
 
+#define FBC_STATUS_BUF_LEN 512
+
 enum psr_mode;
 
 const char *const no_fbc_reasons[] = {
diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
index 602dd86d0..36797c143 100644
--- a/tests/intel/kms_frontbuffer_tracking.c
+++ b/tests/intel/kms_frontbuffer_tracking.c
@@ -1570,7 +1570,7 @@ static void drrs_print_status(void)
 static struct timespec fbc_get_last_action(void)
 {
 	struct timespec ret = { 0, 0 };
-	char buf[128];
+	char buf[FBC_STATUS_BUF_LEN];
 	char *action;
 	ssize_t n_read;
 
@@ -1620,7 +1620,7 @@ static void fbc_update_last_action(void)
 static void fbc_setup_last_action(void)
 {
 	ssize_t n_read;
-	char buf[128];
+	char buf[FBC_STATUS_BUF_LEN];
 	char *action;
 
 	intel_fbc_get_fbc_status(prim_mode_params.crtc, buf, sizeof(buf));
@@ -1640,7 +1640,7 @@ static void fbc_setup_last_action(void)
 
 static bool fbc_is_compressing(void)
 {
-	char buf[128];
+	char buf[FBC_STATUS_BUF_LEN];
 
 	intel_fbc_get_fbc_status(prim_mode_params.crtc, buf, sizeof(buf));
 
@@ -1655,7 +1655,7 @@ static bool fbc_wait_for_compression(void)
 static bool fbc_found_skip_reason(void)
 {
 	bool found_reason = false;
-	char fbc_status[128];
+	char fbc_status[FBC_STATUS_BUF_LEN];
 	int i;
 
 	intel_fbc_get_fbc_status(prim_mode_params.crtc, fbc_status, sizeof(fbc_status));
@@ -1671,7 +1671,7 @@ static bool fbc_found_skip_reason(void)
 
 static bool fbc_enable_per_plane(int plane_index, igt_crtc_t *crtc)
 {
-	char buf[PATH_MAX];
+	char buf[FBC_STATUS_BUF_LEN];
 	char buf_plane[128];
 
 	sprintf(buf_plane, "%d%s", plane_index, igt_crtc_name(crtc));
-- 
2.43.0


  parent reply	other threads:[~2026-04-07 10:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07  9:58 [PATCH i-g-t v2 0/8] updates to fbc tests Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 1/8] tests/intel/kms_frontbuffer_tracking: update the outdated fbc status checks Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 2/8] tests/intel/kms_frontbuffer_tracking: avoid multiple fbc status queries Vinod Govindapillai
2026-04-07 11:14   ` Jani Nikula
2026-04-07  9:58 ` [PATCH i-g-t v2 3/8] lib/i915/fbc: extract intel_fbc_get_fbc_status() Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 4/8] tests/intel/kms_frontbuffer_tracking: use intel_fbc_get_fbc_status() Vinod Govindapillai
2026-04-07  9:58 ` Vinod Govindapillai [this message]
2026-04-07  9:58 ` [PATCH i-g-t v2 6/8] tests/intel/kms_fbcon_fbt: use a bigger fbc status buffer Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 7/8] tests/intel/kms_fbcon_fbt: update the outdated fbc skip reasons Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 8/8] tests/intel/kms_fbcon_fbt: use a common source for checking fbc tests skips Vinod Govindapillai
2026-04-07 11:21   ` Jani Nikula
2026-04-09  5:38 ` ✓ Xe.CI.BAT: success for updates to fbc tests (rev2) Patchwork
2026-04-09  5:56 ` ✓ i915.CI.BAT: " Patchwork
2026-04-09  7:00 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-09 16:43 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260407095843.43679-6-vinod.govindapillai@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=santhosh.reddy.guddati@intel.com \
    --cc=swati2.sharma@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox