public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Vinod Govindapillai <vinod.govindapillai@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: vinod.govindapillai@intel.com, santhosh.reddy.guddati@intel.com,
	swati2.sharma@intel.com, jani.nikula@intel.com,
	ville.syrjala@intel.com
Subject: [PATCH i-g-t v2 6/8] tests/intel/kms_fbcon_fbt: use a bigger fbc status buffer
Date: Tue,  7 Apr 2026 12:58:41 +0300	[thread overview]
Message-ID: <20260407095843.43679-7-vinod.govindapillai@intel.com> (raw)
In-Reply-To: <20260407095843.43679-1-vinod.govindapillai@intel.com>

As the FBC status now include plane specific FBC status as well, we
need a bigger buffer to capture the complete FBC status. Use the
already defined buffer length to assess the FBC status

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 tests/intel/kms_fbcon_fbt.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/intel/kms_fbcon_fbt.c b/tests/intel/kms_fbcon_fbt.c
index e44be15f6..b36582011 100644
--- a/tests/intel/kms_fbcon_fbt.c
+++ b/tests/intel/kms_fbcon_fbt.c
@@ -33,6 +33,7 @@
  * Mega feature: General Display Features
  */
 
+#include "i915/intel_fbc.h"
 #include "igt.h"
 #include "igt_device.h"
 #include "igt_psr.h"
@@ -81,7 +82,7 @@ static void wait_user(const char *msg)
 
 static bool fbc_supported_on_chipset(int device, int debugfs_fd)
 {
-	char buf[128];
+	char buf[FBC_STATUS_BUF_LEN];
 	int ret;
 
 	ret = igt_debugfs_simple_read(debugfs_fd, "i915_fbc_status",
@@ -100,7 +101,7 @@ static bool connector_can_fbc(drmModeConnectorPtr connector)
 
 static void fbc_print_status(int debugfs_fd)
 {
-	static char buf[128];
+	static char buf[FBC_STATUS_BUF_LEN];
 
 	igt_debugfs_simple_read(debugfs_fd, "i915_fbc_status", buf,
 				sizeof(buf));
@@ -109,7 +110,7 @@ static void fbc_print_status(int debugfs_fd)
 
 static bool fbc_check_status(int debugfs_fd, bool enabled)
 {
-	char buf[128];
+	char buf[FBC_STATUS_BUF_LEN];
 
 	igt_debugfs_simple_read(debugfs_fd, "i915_fbc_status", buf,
 				sizeof(buf));
@@ -310,7 +311,7 @@ static void fbc_skips_on_fbcon(int debugfs_fd)
 		"plane height + offset is non-modulo of 4"
 	};
 	bool skip = false;
-	char buf[128];
+	char buf[FBC_STATUS_BUF_LEN];
 	int i;
 
 	igt_debugfs_simple_read(debugfs_fd, "i915_fbc_status", buf, sizeof(buf));
-- 
2.43.0


  parent reply	other threads:[~2026-04-07 10:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07  9:58 [PATCH i-g-t v2 0/8] updates to fbc tests Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 1/8] tests/intel/kms_frontbuffer_tracking: update the outdated fbc status checks Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 2/8] tests/intel/kms_frontbuffer_tracking: avoid multiple fbc status queries Vinod Govindapillai
2026-04-07 11:14   ` Jani Nikula
2026-04-07  9:58 ` [PATCH i-g-t v2 3/8] lib/i915/fbc: extract intel_fbc_get_fbc_status() Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 4/8] tests/intel/kms_frontbuffer_tracking: use intel_fbc_get_fbc_status() Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 5/8] tests/intel/kms_frontbuffer_tracking: use a bigger fbc status buffer Vinod Govindapillai
2026-04-07  9:58 ` Vinod Govindapillai [this message]
2026-04-07  9:58 ` [PATCH i-g-t v2 7/8] tests/intel/kms_fbcon_fbt: update the outdated fbc skip reasons Vinod Govindapillai
2026-04-07  9:58 ` [PATCH i-g-t v2 8/8] tests/intel/kms_fbcon_fbt: use a common source for checking fbc tests skips Vinod Govindapillai
2026-04-07 11:21   ` Jani Nikula
2026-04-09  5:38 ` ✓ Xe.CI.BAT: success for updates to fbc tests (rev2) Patchwork
2026-04-09  5:56 ` ✓ i915.CI.BAT: " Patchwork
2026-04-09  7:00 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-09 16:43 ` ✗ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260407095843.43679-7-vinod.govindapillai@intel.com \
    --to=vinod.govindapillai@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=santhosh.reddy.guddati@intel.com \
    --cc=swati2.sharma@intel.com \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox