public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: Swati Sharma <swati2.sharma@intel.com>,
	Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Subject: [PATCH i-g-t, v2] tests/intel/kms_cdclk: Skip CDCLK bump validation on eDP with fixed clock modes
Date: Wed,  8 Apr 2026 23:41:26 +0530	[thread overview]
Message-ID: <20260408181126.997093-1-swati2.sharma@intel.com> (raw)

eDP panels may expose modes with the same resolution and pixel clock
but different vtotal. Since only the vblank region differs, the CDCLK
requirement remains identical across such modes, so no CDCLK bump is
expected.

Skip CDCLK bump validation on eDP connectors where modes share the
same hdisplay, vdisplay and clock but vary only in vtotal.

Suggested-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/intel/kms_cdclk.c | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/tests/intel/kms_cdclk.c b/tests/intel/kms_cdclk.c
index 20b8a5f0a..a015afa29 100644
--- a/tests/intel/kms_cdclk.c
+++ b/tests/intel/kms_cdclk.c
@@ -72,6 +72,24 @@ static bool hardware_supported(data_t *data)
 	return false;
 }
 
+static bool edp_has_fixed_clock_modes(igt_output_t *output)
+{
+	drmModeConnector *connector = output->config.connector;
+
+	if (connector->connector_type != DRM_MODE_CONNECTOR_eDP)
+		return false;
+
+	for (int i = 0; i < connector->count_modes; i++)
+		for (int j = i + 1; j < connector->count_modes; j++)
+			if (connector->modes[i].hdisplay == connector->modes[j].hdisplay &&
+			    connector->modes[i].vdisplay == connector->modes[j].vdisplay &&
+			    connector->modes[i].clock == connector->modes[j].clock &&
+			    connector->modes[i].vtotal != connector->modes[j].vtotal)
+				return true;
+
+	return false;
+}
+
 static __u64 get_mode_data_rate(drmModeModeInfo *mode)
 {
 	__u64 data_rate = (__u64)mode->hdisplay * (__u64)mode->vdisplay * (__u64)mode->vrefresh;
@@ -329,6 +347,20 @@ static void run_cdclk_test(data_t *data, uint32_t flags)
 	igt_crtc_t *crtc;
 
 	for_each_crtc_with_valid_output(display, crtc, output) {
+		/*
+		 * eDP panels may expose modes with the same resolution and
+		 * pixel clock but different vtotal. Since only the vblank
+		 * region differs, the CDCLK requirement remains identical
+		 * across such modes, so no CDCLK bump is expected and
+		 * validating it would lead to false failures.
+		 */
+		if ((flags & TEST_MODETRANSITION) &&
+		    edp_has_fixed_clock_modes(output)) {
+			igt_info("Skipping %s: eDP has modes with same clock "
+				 "but different vtotal\n", output->name);
+			continue;
+		}
+
 		igt_output_set_crtc(output,
 				    crtc);
 		if (!intel_pipe_output_combo_valid(display)) {
-- 
2.25.1


             reply	other threads:[~2026-04-08 18:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-08 18:11 Swati Sharma [this message]
2026-04-09 18:44 ` ✓ Xe.CI.BAT: success for tests/intel/kms_cdclk: Skip CDCLK bump validation on eDP with fixed clock modes Patchwork
2026-04-09 19:02 ` ✓ i915.CI.BAT: " Patchwork
2026-04-09 19:45 ` ✓ Xe.CI.FULL: " Patchwork
2026-04-10 10:25 ` ✗ i915.CI.Full: failure " Patchwork
2026-04-10 10:45 ` [PATCH i-g-t, v2] " Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260408181126.997093-1-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox