[PATCH] tests/kms_writeback: fix coding style issues

[PATCH] tests/kms_writeback: fix coding style issues

[Alex Hung]

Fix missing spaces after comma in two igt_skip_on_f() calls and
in the writeback-invalid-parameters subtest description strings.

Signed-off-by: Alex Hung <alex.hung@amd.com>
---
 tests/kms_writeback.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c
index f15abba96..5031fcb83 100644
--- a/tests/kms_writeback.c
+++ b/tests/kms_writeback.c
@@ -58,8 +58,8 @@
  * Description: Validate WRITEBACK_FB_ID with valid and invalid options
  *
  * SUBTEST: writeback-invalid-parameters
- * Description: Writeback has a couple of parameters linked together(output
- *              framebuffer and fence); this test goes throughthe combination
+ * Description: Writeback has a couple of parameters linked together (output
+ *              framebuffer and fence); this test goes through the combination
  *              of possible bad options
  *
  * SUBTEST: writeback-pixel-formats
@@ -620,8 +620,8 @@ int igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)
 		drmModeFreePropertyBlob(formats_blob);
 	}
 
-	igt_describe("Writeback has a couple of parameters linked together"
-		     "(output framebuffer and fence); this test goes through"
+	igt_describe("Writeback has a couple of parameters linked together "
+		     "(output framebuffer and fence); this test goes through "
 		     "the combination of possible bad options");
 	igt_subtest("writeback-invalid-parameters") {
 		igt_fb_t invalid_output_fb;
@@ -644,7 +644,7 @@ int igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)
 		igt_fb_t output_fb;
 
 		igt_skip_on(data.dump_check || data.list_modes);
-		igt_skip_on_f(!(data.supported_colors & XRGB8888),"DRM_FORMAT_XRGB8888 is unsupported\n");
+		igt_skip_on_f(!(data.supported_colors & XRGB8888), "DRM_FORMAT_XRGB8888 is unsupported\n");
 		fb_id = igt_create_fb(display.drm_fd, mode.hdisplay, mode.vdisplay,
 				      DRM_FORMAT_XRGB8888,
 				      DRM_FORMAT_MOD_LINEAR,
@@ -678,7 +678,7 @@ int igt_main_args("b:c:f:dl", long_options, help_str, opt_handler, NULL)
 		igt_fb_t output_fb;
 
 		igt_skip_on(data.dump_check || data.list_modes);
-		igt_skip_on_f(!(data.supported_colors & XRGB8888),"DRM_FORMAT_XRGB8888 is unsupported\n");
+		igt_skip_on_f(!(data.supported_colors & XRGB8888), "DRM_FORMAT_XRGB8888 is unsupported\n");
 		fb_id = igt_create_fb(display.drm_fd, mode.hdisplay, mode.vdisplay,
 				      DRM_FORMAT_XRGB8888,
 				      igt_fb_mod_to_tiling(0),
-- 
2.43.0

RE: [PATCH] tests/kms_writeback: fix coding style issues

[Kandpal, Suraj]

> Subject: [PATCH] tests/kms_writeback: fix coding style issues
> 
> Fix missing spaces after comma in two igt_skip_on_f() calls and in the
> writeback-invalid-parameters subtest description strings.
> 
> Signed-off-by: Alex Hung <alex.hung@amd.com>

LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>

> ---
>  tests/kms_writeback.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c index
> f15abba96..5031fcb83 100644
> --- a/tests/kms_writeback.c
> +++ b/tests/kms_writeback.c
> @@ -58,8 +58,8 @@
>   * Description: Validate WRITEBACK_FB_ID with valid and invalid options
>   *
>   * SUBTEST: writeback-invalid-parameters
> - * Description: Writeback has a couple of parameters linked together(output
> - *              framebuffer and fence); this test goes throughthe combination
> + * Description: Writeback has a couple of parameters linked together (output
> + *              framebuffer and fence); this test goes through the combination
>   *              of possible bad options
>   *
>   * SUBTEST: writeback-pixel-formats
> @@ -620,8 +620,8 @@ int igt_main_args("b:c:f:dl", long_options, help_str,
> opt_handler, NULL)
>  		drmModeFreePropertyBlob(formats_blob);
>  	}
> 
> -	igt_describe("Writeback has a couple of parameters linked together"
> -		     "(output framebuffer and fence); this test goes through"
> +	igt_describe("Writeback has a couple of parameters linked together "
> +		     "(output framebuffer and fence); this test goes through "
>  		     "the combination of possible bad options");
>  	igt_subtest("writeback-invalid-parameters") {
>  		igt_fb_t invalid_output_fb;
> @@ -644,7 +644,7 @@ int igt_main_args("b:c:f:dl", long_options, help_str,
> opt_handler, NULL)
>  		igt_fb_t output_fb;
> 
>  		igt_skip_on(data.dump_check || data.list_modes);
> -		igt_skip_on_f(!(data.supported_colors &
> XRGB8888),"DRM_FORMAT_XRGB8888 is unsupported\n");
> +		igt_skip_on_f(!(data.supported_colors & XRGB8888),
> +"DRM_FORMAT_XRGB8888 is unsupported\n");
>  		fb_id = igt_create_fb(display.drm_fd, mode.hdisplay,
> mode.vdisplay,
>  				      DRM_FORMAT_XRGB8888,
>  				      DRM_FORMAT_MOD_LINEAR,
> @@ -678,7 +678,7 @@ int igt_main_args("b:c:f:dl", long_options, help_str,
> opt_handler, NULL)
>  		igt_fb_t output_fb;
> 
>  		igt_skip_on(data.dump_check || data.list_modes);
> -		igt_skip_on_f(!(data.supported_colors &
> XRGB8888),"DRM_FORMAT_XRGB8888 is unsupported\n");
> +		igt_skip_on_f(!(data.supported_colors & XRGB8888),
> +"DRM_FORMAT_XRGB8888 is unsupported\n");
>  		fb_id = igt_create_fb(display.drm_fd, mode.hdisplay,
> mode.vdisplay,
>  				      DRM_FORMAT_XRGB8888,
>  				      igt_fb_mod_to_tiling(0),
> --
> 2.43.0

Re: [PATCH] tests/kms_writeback: fix coding style issues

[Kamil Konieczny]

Hi Kandpal,,
On 2026-04-09 at 08:06:17 +0000, Kandpal, Suraj wrote:
> > Subject: [PATCH] tests/kms_writeback: fix coding style issues
> > 
> > Fix missing spaces after comma in two igt_skip_on_f() calls and in the
> > writeback-invalid-parameters subtest description strings.
> > 
> > Signed-off-by: Alex Hung <alex.hung@amd.com>
> 
> LGTM,
> Reviewed-by: Suraj Kandpal <suraj.kandpal@intel.com>
> 

Thank you all, pushed.

Regards,
Kamil

> > ---
> >  tests/kms_writeback.c | 12 ++++++------
> >  1 file changed, 6 insertions(+), 6 deletions(-)
> > 
> > diff --git a/tests/kms_writeback.c b/tests/kms_writeback.c index
> > f15abba96..5031fcb83 100644
> > --- a/tests/kms_writeback.c
> > +++ b/tests/kms_writeback.c
> > @@ -58,8 +58,8 @@
> >   * Description: Validate WRITEBACK_FB_ID with valid and invalid options
> >   *
> >   * SUBTEST: writeback-invalid-parameters
> > - * Description: Writeback has a couple of parameters linked together(output
> > - *              framebuffer and fence); this test goes throughthe combination
> > + * Description: Writeback has a couple of parameters linked together (output
> > + *              framebuffer and fence); this test goes through the combination
> >   *              of possible bad options
> >   *
> >   * SUBTEST: writeback-pixel-formats
> > @@ -620,8 +620,8 @@ int igt_main_args("b:c:f:dl", long_options, help_str,
> > opt_handler, NULL)
> >  		drmModeFreePropertyBlob(formats_blob);
> >  	}
> > 
> > -	igt_describe("Writeback has a couple of parameters linked together"
> > -		     "(output framebuffer and fence); this test goes through"
> > +	igt_describe("Writeback has a couple of parameters linked together "
> > +		     "(output framebuffer and fence); this test goes through "
> >  		     "the combination of possible bad options");
> >  	igt_subtest("writeback-invalid-parameters") {
> >  		igt_fb_t invalid_output_fb;
> > @@ -644,7 +644,7 @@ int igt_main_args("b:c:f:dl", long_options, help_str,
> > opt_handler, NULL)
> >  		igt_fb_t output_fb;
> > 
> >  		igt_skip_on(data.dump_check || data.list_modes);
> > -		igt_skip_on_f(!(data.supported_colors &
> > XRGB8888),"DRM_FORMAT_XRGB8888 is unsupported\n");
> > +		igt_skip_on_f(!(data.supported_colors & XRGB8888),
> > +"DRM_FORMAT_XRGB8888 is unsupported\n");
> >  		fb_id = igt_create_fb(display.drm_fd, mode.hdisplay,
> > mode.vdisplay,
> >  				      DRM_FORMAT_XRGB8888,
> >  				      DRM_FORMAT_MOD_LINEAR,
> > @@ -678,7 +678,7 @@ int igt_main_args("b:c:f:dl", long_options, help_str,
> > opt_handler, NULL)
> >  		igt_fb_t output_fb;
> > 
> >  		igt_skip_on(data.dump_check || data.list_modes);
> > -		igt_skip_on_f(!(data.supported_colors &
> > XRGB8888),"DRM_FORMAT_XRGB8888 is unsupported\n");
> > +		igt_skip_on_f(!(data.supported_colors & XRGB8888),
> > +"DRM_FORMAT_XRGB8888 is unsupported\n");
> >  		fb_id = igt_create_fb(display.drm_fd, mode.hdisplay,
> > mode.vdisplay,
> >  				      DRM_FORMAT_XRGB8888,
> >  				      igt_fb_mod_to_tiling(0),
> > --
> > 2.43.0
> 

✗ Fi.CI.BAT: failure for tests/kms_writeback: fix coding style issues

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

== Series Details ==

Series: tests/kms_writeback: fix coding style issues
URL   : https://patchwork.freedesktop.org/series/164575/
State : failure

== Summary ==

Series 164575 revision 1 was fully merged or fully failed: no git log



[-- Attachment #2: Type: text/html, Size: 705 bytes --]