public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] tests/kms_flip: Fix regression on non-Intel devices in event_loop
@ 2026-04-09 23:28 Alex Hung
  2026-04-10  4:52 ` ✓ i915.CI.BAT: success for " Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Alex Hung @ 2026-04-09 23:28 UTC (permalink / raw)
  To: igt-dev; +Cc: alex.hung, sunpeng.li, Ethan.Cheung

Guard the device-id query with is_intel_device() so the "wa" flag is
only computed on Intel hardware, restoring the pre-regression behavior
for all other drivers.

This fixes the following regression:

(kms_flip:15463) intel_chipset-CRITICAL: Test assertion failure function intel_get_drm_devid, file ../lib/intel_chipset.c:145:
(kms_flip:15463) intel_chipset-CRITICAL: Failed assertion: is_intel_device(fd)

Fixes: 2a9f1c1ae ("tests/kms_flip: test suspend at most twice on SNB && BMG")
Signed-off-by: Alex Hung <alex.hung@amd.com>
---
 tests/kms_flip.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/tests/kms_flip.c b/tests/kms_flip.c
index 81fa8dd5c..1ef9492ba 100755
--- a/tests/kms_flip.c
+++ b/tests/kms_flip.c
@@ -1327,11 +1327,12 @@ static bool event_loop(struct test_output *o, unsigned duration_ms,
 	unsigned long start, end;
 	uint32_t devid;
 	int count = 0;
-	bool wa;
+	bool wa = false;
 
-	devid = intel_get_drm_devid(drm_fd);
-
-	wa = IS_SANDYBRIDGE(devid) || IS_BATTLEMAGE(devid);
+	if (is_intel_device(drm_fd)) {
+		devid = intel_get_drm_devid(drm_fd);
+		wa = IS_SANDYBRIDGE(devid) || IS_BATTLEMAGE(devid);
+	}
 
 	start = gettime_us();
 
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2026-04-11  1:23 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-04-09 23:28 [PATCH] tests/kms_flip: Fix regression on non-Intel devices in event_loop Alex Hung
2026-04-10  4:52 ` ✓ i915.CI.BAT: success for " Patchwork
2026-04-10  4:57 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-10  8:17 ` [PATCH] " Michał Grzelak
2026-04-10 11:23 ` ✓ Xe.CI.FULL: success for " Patchwork
2026-04-10 11:44 ` [PATCH] " Kamil Konieczny
2026-04-11  1:23 ` ✗ i915.CI.Full: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox