public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Swati Sharma <swati2.sharma@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: "Swati Sharma" <swati2.sharma@intel.com>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: [PATCH i-g-t] tests/intel/kms_cdclk: Skip CDCLK bump validation when dotclocks match
Date: Fri, 10 Apr 2026 18:11:43 +0530	[thread overview]
Message-ID: <20260410124143.1015272-1-swati2.sharma@intel.com> (raw)

When the highest and lowest resolution modes share the same dotclock,
no CDCLK bump is expected.

Skip CDCLK bump validation when the highres and lowres modes have the
same dotclock, replacing the previous resolution-based is_equal() check
with a dotclock comparison via has_same_dotclock().

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
---
 tests/intel/kms_cdclk.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/tests/intel/kms_cdclk.c b/tests/intel/kms_cdclk.c
index 662bdbe43..48bd7276f 100644
--- a/tests/intel/kms_cdclk.c
+++ b/tests/intel/kms_cdclk.c
@@ -84,11 +84,9 @@ static bool is_4k(drmModeModeInfo mode)
 	        mode.vrefresh >= VREFRESH);
 }
 
-static bool is_equal(drmModeModeInfo mode_hi, drmModeModeInfo mode_lo)
+static bool has_same_dotclock(drmModeModeInfo mode_hi, drmModeModeInfo mode_lo)
 {
-	return (mode_hi.hdisplay == mode_lo.hdisplay &&
-		mode_hi.vdisplay == mode_lo.vdisplay &&
-		mode_hi.vrefresh == mode_lo.vrefresh);
+	return mode_hi.clock == mode_lo.clock;
 }
 
 static drmModeModeInfo *get_lowres_mode(igt_output_t *output)
@@ -204,7 +202,7 @@ static void test_mode_transition(data_t *data, igt_crtc_t *crtc,
 	igt_require_f(is_4k(mode_hi), "Mode >= 4K not found on output %s\n",
 	              igt_output_name(output));
 
-	igt_skip_on_f(is_equal(mode_hi, mode_lo), "Highest and lowest mode resolutions are same; no transition\n");
+	igt_skip_on_f(has_same_dotclock(mode_hi, mode_lo), "Highest and lowest modes have same dotclock; no CDCLK bump expected\n");
 
 	primary = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
 
@@ -278,8 +276,8 @@ static void test_mode_transition_on_all_outputs(data_t *data)
 
 		mode_lowres[count] = *get_lowres_mode(output);
 
-		if (is_equal(mode_highres[count], mode_lowres[count])) {
-			igt_info("Highest and lowest mode resolutions are same on output %s; no transition will occur, skipping\n",
+		if (has_same_dotclock(mode_highres[count], mode_lowres[count])) {
+			igt_info("Highest and lowest modes have same dotclock on output %s; no CDCLK bump expected, skipping\n",
 				  igt_output_name(output));
 			continue;
 		}
-- 
2.25.1


             reply	other threads:[~2026-04-10 12:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-10 12:41 Swati Sharma [this message]
2026-04-10 18:33 ` ✓ Xe.CI.BAT: success for tests/intel/kms_cdclk: Skip CDCLK bump validation when dotclocks match Patchwork
2026-04-10 18:48 ` ✓ i915.CI.BAT: " Patchwork
2026-04-11  7:20 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-04-11 19:27 ` ✓ i915.CI.Full: success " Patchwork
2026-04-14  9:53 ` [PATCH i-g-t] " Karthik B S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260410124143.1015272-1-swati2.sharma@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox