From: Jan Maslak <jan.maslak@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: zbigniew.kempczynski@intel.com, Jan Maslak <jan.maslak@intel.com>
Subject: [PATCH 09/10] lib/rendercopy: Convert render op and entry points to genxml
Date: Thu, 16 Apr 2026 00:07:19 +0200 [thread overview]
Message-ID: <20260415220720.1594414-10-jan.maslak@intel.com> (raw)
In-Reply-To: <20260415220720.1594414-1-jan.maslak@intel.com>
Update _gen9_render_op() and the public render/clear entry points to use
igt_genxml_emit macros backed by the genxml pack headers.
Signed-off-by: Jan Maslak <jan.maslak@intel.com>
---
lib/rendercopy_gen9.c | 52 +++++++++++++++++++++++++------------------
1 file changed, 30 insertions(+), 22 deletions(-)
diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c
index 1c3eff217..295c5cae5 100644
--- a/lib/rendercopy_gen9.c
+++ b/lib/rendercopy_gen9.c
@@ -1218,8 +1218,13 @@ void _gen9_render_op(struct intel_bb *ibb,
/* Start emitting the commands. The order roughly follows the mesa blorp
* order */
- intel_bb_out(ibb, G4X_PIPELINE_SELECT | PIPELINE_SELECT_3D |
- GEN9_PIPELINE_SELECTION_MASK);
+ igt_genxml_emit(ibb, GFX9_PIPELINE_SELECT, ps) {
+ ps.PipelineSelection = GFX9_3D;
+ /* MaskBits 15:8 is a write-enable mask for bits 5:4 (Force Media
+ * Awake and Media Sampler DOP Clock Gate Enable). Value 0x3
+ * enables writes to both bits so PipelineSelection takes effect. */
+ ps.MaskBits = 3;
+ }
gen12_emit_aux_pgtable_state(ibb, aux_pgtable_state, true);
@@ -1250,17 +1255,21 @@ void _gen9_render_op(struct intel_bb *ibb,
gen9_emit_state_base_address(ibb);
if (HAS_4TILE(ibb->devid) || intel_gen(ibb->devid) > 12) {
- intel_bb_out(ibb, GEN4_3DSTATE_BINDING_TABLE_POOL_ALLOC | 2);
- intel_bb_emit_reloc(ibb, ibb->handle,
- I915_GEM_DOMAIN_RENDER | I915_GEM_DOMAIN_INSTRUCTION, 0,
- 0, ibb->batch_offset);
- intel_bb_out(ibb, 1 << 12);
+ igt_genxml_emit(ibb, GFX9_3DSTATE_BINDING_TABLE_POOL_ALLOC, btpa) {
+ btpa.MOCS = intel_get_wb_mocs(ibb->fd);
+ btpa.BindingTablePoolBaseAddress =
+ igt_address_of_batch(ibb,
+ I915_GEM_DOMAIN_RENDER | I915_GEM_DOMAIN_INSTRUCTION, 0);
+ btpa.BindingTablePoolBufferSize = 1;
+ }
}
- intel_bb_out(ibb, GEN7_3DSTATE_VIEWPORT_STATE_POINTERS_CC);
- intel_bb_out(ibb, viewport.cc_state);
- intel_bb_out(ibb, GEN8_3DSTATE_VIEWPORT_STATE_POINTERS_SF_CLIP);
- intel_bb_out(ibb, viewport.sf_clip_state);
+ igt_genxml_emit(ibb, GFX9_3DSTATE_VIEWPORT_STATE_POINTERS_CC, vp) {
+ vp.CCViewportPointer = viewport.cc_state;
+ }
+ igt_genxml_emit(ibb, GFX9_3DSTATE_VIEWPORT_STATE_POINTERS_SF_CLIP, vp) {
+ vp.SFClipViewportPointer = viewport.sf_clip_state;
+ }
gen7_emit_urb(ibb);
@@ -1270,11 +1279,7 @@ void _gen9_render_op(struct intel_bb *ibb,
gen8_emit_null_state(ibb);
- intel_bb_out(ibb, GEN7_3DSTATE_STREAMOUT | (5 - 2));
- intel_bb_out(ibb, 0);
- intel_bb_out(ibb, 0);
- intel_bb_out(ibb, 0);
- intel_bb_out(ibb, 0);
+ igt_genxml_emit(ibb, GFX9_3DSTATE_STREAMOUT, so) { }
gen7_emit_clip(ibb);
@@ -1282,14 +1287,17 @@ void _gen9_render_op(struct intel_bb *ibb,
gen8_emit_ps(ibb, ps_kernel_off, fast_clear);
- intel_bb_out(ibb, GEN7_3DSTATE_BINDING_TABLE_POINTERS_PS);
- intel_bb_out(ibb, ps_binding_table);
+ igt_genxml_emit(ibb, GFX9_3DSTATE_BINDING_TABLE_POINTERS_PS, bt) {
+ bt.PointertoPSBindingTable = ps_binding_table;
+ }
- intel_bb_out(ibb, GEN7_3DSTATE_SAMPLER_STATE_POINTERS_PS);
- intel_bb_out(ibb, ps_sampler_state);
+ igt_genxml_emit(ibb, GFX9_3DSTATE_SAMPLER_STATE_POINTERS_PS, sp) {
+ sp.PointertoPSSamplerState = ps_sampler_state;
+ }
- intel_bb_out(ibb, GEN8_3DSTATE_SCISSOR_STATE_POINTERS);
- intel_bb_out(ibb, scissor_state);
+ igt_genxml_emit(ibb, GFX9_3DSTATE_SCISSOR_STATE_POINTERS, ssp) {
+ ssp.ScissorRectPointer = scissor_state;
+ }
gen9_emit_depth(ibb);
--
2.34.1
next prev parent reply other threads:[~2026-04-15 22:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 22:07 [PATCH 00/10] lib/genxml: Introduce Mesa genxml infrastructure to IGT Jan Maslak
2026-04-15 22:07 ` [PATCH 01/10] lib/intel/genxml: Add genxml generators, headers, and build integration Jan Maslak
2026-04-23 9:32 ` Zbigniew Kempczyński
2026-04-23 11:04 ` Kamil Konieczny
2026-04-24 6:54 ` Zbigniew Kempczyński
2026-04-15 22:07 ` [PATCH 02/10] lib/intel/genxml: Import gen4-gen8 XML hardware definitions from Mesa Jan Maslak
2026-04-23 9:33 ` Zbigniew Kempczyński
2026-04-15 22:07 ` [PATCH 03/10] lib/intel/genxml: Import gen9-gen12.5 " Jan Maslak
2026-04-23 9:34 ` Zbigniew Kempczyński
2026-04-15 22:07 ` [PATCH 04/10] lib/intel/genxml: Import Xe2/Xe3/Xe3p " Jan Maslak
2026-04-23 9:35 ` Zbigniew Kempczyński
2026-04-15 22:07 ` [PATCH 05/10] lib/mocs: Add intel_get_wb_mocs() and intel_buf_mocs() for genxml MOCS fields Jan Maslak
2026-04-23 15:24 ` Zbigniew Kempczyński
2026-04-15 22:07 ` [PATCH 06/10] lib/rendercopy: Convert surface state and sampler setup to genxml Jan Maslak
2026-04-27 8:54 ` Zbigniew Kempczyński
2026-04-15 22:07 ` [PATCH 07/10] lib/rendercopy: Convert vertex data and CC state " Jan Maslak
2026-04-27 11:15 ` Zbigniew Kempczyński
2026-04-15 22:07 ` [PATCH 08/10] lib/rendercopy: Convert pipeline emit commands " Jan Maslak
2026-04-15 22:07 ` Jan Maslak [this message]
2026-04-15 22:07 ` [PATCH 10/10] lib: Add genxml annotated batch buffer decode Jan Maslak
2026-04-23 10:56 ` Kamil Konieczny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260415220720.1594414-10-jan.maslak@intel.com \
--to=jan.maslak@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox